All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcelo Tosatti <mtosatti@redhat.com>
To: kvm-ia64@vger.kernel.org
Subject: Re: [RFC]RE: [PATCH] kvm-ia64 irq assignment 1/2  kernel
Date: Sat, 14 Jun 2008 22:58:21 +0000	[thread overview]
Message-ID: <20080614225821.GA22724@dmt.cnet> (raw)
In-Reply-To: <51CFAB8CB6883745AE7B93B3E084EBE201CC8A61@pdsmsx412.ccr.corp.intel.com>

On Fri, Jun 13, 2008 at 12:15:23AM +0800, Xu, Anthony wrote:
> > I think it would be better to avoid static PCI pin -> IOAPIC pin
> > assignments, if PCI link devices can be used (allowing the OS to route
> > IRQ's as it wishes to).
> Seems PCI link device only support irq-pin < 16,
> IOAPIC pin 16~23 can not be used.
> 
> 
> 
> > 
> > Take a look at http://www.microsoft.com/whdc/archive/acpi-mp.mspx. It
> > seems cleaner to use "bimodal link nodes" (using the parlance from URL
> > above) instead of "bimodal _PRT" as your present GSI patch is using.
> Bimodal _PRT is a great idea, I never thought of it before, thanks.
> 
> While in PIIX platform there are only 4 PCI link entries, how can we
> introduce more? Where to put these added entries?
> still in ISA bridge configure space.

Would have to write an ACPI-IOAPIC "IRQ router" to replace PIIX. It
would be queried via a SystemIO region, so QEMU can know what IRQ
has been assigned to a particular slot/func (OS can then change IRQ
assignment via link device _SRS method).

That seems to be necessary for dynamic IRQ assignment of slots/function
once you have more than one IOAPIC (note we can also assign one IRQ to
each function inside each slot, currently there's one IRQ per _slot_).

> Another concern is, can this link use irq-pin > 15?
> In the example ASL code in the web page you provided, they use irq-pin
> <\x15

Sure it can, as long as the OS has notified its not using PIIX's PIC
(via the _PIC method).


WARNING: multiple messages have this Message-ID (diff)
From: Marcelo Tosatti <mtosatti@redhat.com>
To: "Xu, Anthony" <anthony.xu@intel.com>
Cc: Alexander Graf <agraf@suse.de>, Avi Kivity <avi@qumranet.com>,
	Jes Sorensen <jes@sgi.com>,
	kvm@vger.kernel.org, kvm-ia64@vger.kernel.org
Subject: Re: [RFC]RE: [PATCH] kvm-ia64 irq assignment 1/2  kernel
Date: Sat, 14 Jun 2008 19:58:21 -0300	[thread overview]
Message-ID: <20080614225821.GA22724@dmt.cnet> (raw)
In-Reply-To: <51CFAB8CB6883745AE7B93B3E084EBE201CC9071@pdsmsx412.ccr.corp.intel.com>

On Fri, Jun 13, 2008 at 12:15:23AM +0800, Xu, Anthony wrote:
> > I think it would be better to avoid static PCI pin -> IOAPIC pin
> > assignments, if PCI link devices can be used (allowing the OS to route
> > IRQ's as it wishes to).
> Seems PCI link device only support irq-pin < 16,
> IOAPIC pin 16~23 can not be used.
> 
> 
> 
> > 
> > Take a look at http://www.microsoft.com/whdc/archive/acpi-mp.mspx. It
> > seems cleaner to use "bimodal link nodes" (using the parlance from URL
> > above) instead of "bimodal _PRT" as your present GSI patch is using.
> Bimodal _PRT is a great idea, I never thought of it before, thanks.
> 
> While in PIIX platform there are only 4 PCI link entries, how can we
> introduce more? Where to put these added entries?
> still in ISA bridge configure space.

Would have to write an ACPI-IOAPIC "IRQ router" to replace PIIX. It
would be queried via a SystemIO region, so QEMU can know what IRQ
has been assigned to a particular slot/func (OS can then change IRQ
assignment via link device _SRS method).

That seems to be necessary for dynamic IRQ assignment of slots/function
once you have more than one IOAPIC (note we can also assign one IRQ to
each function inside each slot, currently there's one IRQ per _slot_).

> Another concern is, can this link use irq-pin > 15?
> In the example ASL code in the web page you provided, they use irq-pin
> <=15

Sure it can, as long as the OS has notified its not using PIIX's PIC
(via the _PIC method).


  parent reply	other threads:[~2008-06-14 22:58 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-10  7:57 [RFC]RE: [PATCH] kvm-ia64 irq assignment 1/2 kernel Xu, Anthony
2008-06-10  7:57 ` Xu, Anthony
2008-06-11 14:24 ` Alexander Graf
2008-06-11 14:24   ` Alexander Graf
2008-06-11 16:02 ` Marcelo Tosatti
2008-06-11 16:02   ` Marcelo Tosatti
2008-06-11 16:16 ` Marcelo Tosatti
2008-06-11 16:16   ` Marcelo Tosatti
2008-06-12 12:34 ` Avi Kivity
2008-06-12 12:34   ` Avi Kivity
2008-06-12 16:08 ` Xu, Anthony
2008-06-12 16:08   ` Xu, Anthony
2008-06-12 16:15 ` Xu, Anthony
2008-06-12 16:15   ` Xu, Anthony
2008-06-12 16:19 ` Xu, Anthony
2008-06-12 16:19   ` Xu, Anthony
2008-06-12 16:20 ` Xu, Anthony
2008-06-12 16:20   ` Xu, Anthony
2008-06-14 22:58 ` Marcelo Tosatti [this message]
2008-06-14 22:58   ` Marcelo Tosatti
2008-06-16  1:13 ` Xu, Anthony
2008-06-16  1:13   ` Xu, Anthony
2008-07-02  9:11 ` Jes Sorensen
2008-07-02  9:11   ` Jes Sorensen
2008-07-03  1:22 ` Xu, Anthony
2008-07-03  1:22   ` Xu, Anthony
  -- strict thread matches above, loose matches on Subject: below --
2008-06-06 15:58 Xu, Anthony
2008-06-06 15:58 ` Xu, Anthony
2008-06-06 19:58 ` Avi Kivity
2008-06-06 19:58   ` Avi Kivity
2008-06-09  8:58 ` Alexander Graf
2008-06-09  8:58   ` Alexander Graf
2008-06-09  9:16 ` Alexander Graf
2008-06-09  9:16   ` Alexander Graf
2008-06-10  6:33 ` Xu, Anthony
2008-06-10  6:33   ` Xu, Anthony
2008-06-10  7:25 ` Alexander Graf
2008-06-10  7:25   ` Alexander Graf
2008-06-12 12:24 ` Avi Kivity
2008-06-12 12:24   ` Avi Kivity
2008-06-12 12:30 ` Avi Kivity
2008-06-12 12:30   ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080614225821.GA22724@dmt.cnet \
    --to=mtosatti@redhat.com \
    --cc=kvm-ia64@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.