All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Millan <rmh@aybabtu.com>
To: grub-devel@gnu.org
Subject: new patch (boot from LVM / RAID)
Date: Sun, 15 Jun 2008 23:33:32 +0200	[thread overview]
Message-ID: <20080615213332.GA9442@thorin> (raw)
In-Reply-To: <20080615182219.GA12911@thorin>

On Sun, Jun 15, 2008 at 08:22:19PM +0200, Robert Millan wrote:
> 
> The memdisk part of this was basicaly a bugfix, so I checked it in.  The rest
> seems to duplicate stuff that grub-setup was already doing, and I think I'll
> have to take a closer look (I'll send another mail about that later).

I think I sorted this out.  The tip of the iceberg was that grub-setup is
prepending a drive to prefix twice when we run LVM on RAID.  However, it is
actually wrong that grub-setup mangles prefix in first place!  core.img might
be loaded by other means (e.g. from GRUB Legacy), and then these adjustments
have no effect.

I also think it's more flexible if these kind of decisions are taken in a
higher layer, so my patch moves this to grub-install, which relies on
grub-probe.  Then with grub-mkimage being capable of prepending a drive
to prefix, there's no need to do it in grub-setup.

This also fixes some minor issues I found along the way.

Any comments?

-- 
Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What good is a phone call… if you are unable to speak?
(as seen on /.)



  reply	other threads:[~2008-06-15 21:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-06 16:09 [PATCH] boot from LVM / RAID Robert Millan
2008-06-15 18:22 ` Robert Millan
2008-06-15 21:33   ` Robert Millan [this message]
2008-06-15 21:34     ` new patch (boot from LVM / RAID) Robert Millan
2008-06-17 20:42       ` Robert Millan
2008-06-18 17:35         ` Robert Millan
2008-06-22 17:56         ` Guntsche Michael

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080615213332.GA9442@thorin \
    --to=rmh@aybabtu.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.