From: Marcelo Tosatti <mtosatti@redhat.com>
To: kvm-ia64@vger.kernel.org
Subject: Re: [RFC] kvm irq assignment
Date: Mon, 16 Jun 2008 15:52:18 +0000 [thread overview]
Message-ID: <20080616155218.GA30371@dmt.cnet> (raw)
In-Reply-To: <51CFAB8CB6883745AE7B93B3E084EBE201CC9077@pdsmsx412.ccr.corp.intel.com>
On Mon, Jun 16, 2008 at 01:31:21PM +0800, Xu, Anthony wrote:
> >> I think you should avoid any changes to pci.c. Perhaps create a new
> >> ioapic_and_pic_map / ioapic_and_pic_set pair of functions and change
> >> pc.c to use that instead of piix_set_irq.
> > I'll consider how to do this
> >
>
> But pci.c includes below code section, which implements irq_num mapping
> through interrupt link, While ioapic_set_irq doesn't
> need this modification.
> Seems, it's unavoidable to modify pci.c
Just do a dummy mapping function?
int ioapic_pic_map_irq(PCIDevice *dev, int irq_num)
{
return irq_num;
}
> Thanks,
> Anthony
>
>
>
> pci_dev->irq_state[irq_num] = level;
> for (;;) {
> bus = pci_dev->bus;
> irq_num = bus->map_irq(pci_dev, irq_num);
> if (bus->set_irq)
> break;
> pci_dev = bus->parent_dev;
WARNING: multiple messages have this Message-ID (diff)
From: Marcelo Tosatti <mtosatti@redhat.com>
To: "Xu, Anthony" <anthony.xu@intel.com>
Cc: Avi Kivity <avi@qumranet.com>, Alexander Graf <agraf@suse.de>,
Jes Sorensen <jes@sgi.com>,
kvm@vger.kernel.org, kvm-ia64@vger.kernel.org
Subject: Re: [RFC] kvm irq assignment
Date: Mon, 16 Jun 2008 12:52:18 -0300 [thread overview]
Message-ID: <20080616155218.GA30371@dmt.cnet> (raw)
In-Reply-To: <51CFAB8CB6883745AE7B93B3E084EBE201D2BF59@pdsmsx412.ccr.corp.intel.com>
On Mon, Jun 16, 2008 at 01:31:21PM +0800, Xu, Anthony wrote:
> >> I think you should avoid any changes to pci.c. Perhaps create a new
> >> ioapic_and_pic_map / ioapic_and_pic_set pair of functions and change
> >> pc.c to use that instead of piix_set_irq.
> > I'll consider how to do this
> >
>
> But pci.c includes below code section, which implements irq_num mapping
> through interrupt link, While ioapic_set_irq doesn't
> need this modification.
> Seems, it's unavoidable to modify pci.c
Just do a dummy mapping function?
int ioapic_pic_map_irq(PCIDevice *dev, int irq_num)
{
return irq_num;
}
> Thanks,
> Anthony
>
>
>
> pci_dev->irq_state[irq_num] = level;
> for (;;) {
> bus = pci_dev->bus;
> irq_num = bus->map_irq(pci_dev, irq_num);
> if (bus->set_irq)
> break;
> pci_dev = bus->parent_dev;
next prev parent reply other threads:[~2008-06-16 15:52 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-12 16:39 [RFC] kvm irq assignment Xu, Anthony
2008-06-12 16:39 ` Xu, Anthony
2008-06-12 19:16 ` Avi Kivity
2008-06-12 19:16 ` Avi Kivity
2008-06-13 2:45 ` Xu, Anthony
2008-06-13 2:45 ` Xu, Anthony
2008-06-13 6:38 ` Xu, Anthony
2008-06-13 6:38 ` Xu, Anthony
2008-06-13 14:22 ` Avi Kivity
2008-06-13 14:22 ` Avi Kivity
2008-06-14 23:32 ` Marcelo Tosatti
2008-06-14 23:32 ` Marcelo Tosatti
2008-06-16 1:26 ` Xu, Anthony
2008-06-16 1:26 ` Xu, Anthony
2008-06-16 1:34 ` Xu, Anthony
2008-06-16 1:34 ` Xu, Anthony
2008-06-16 1:36 ` Xu, Anthony
2008-06-16 1:36 ` Xu, Anthony
2008-06-16 5:31 ` Xu, Anthony
2008-06-16 5:31 ` Xu, Anthony
2008-06-16 5:40 ` Xu, Anthony
2008-06-16 5:40 ` Xu, Anthony
2008-06-16 15:52 ` Marcelo Tosatti [this message]
2008-06-16 15:52 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080616155218.GA30371@dmt.cnet \
--to=mtosatti@redhat.com \
--cc=kvm-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.