From: Joel Becker <Joel.Becker@oracle.com>
To: Louis Rilling <Louis.Rilling@kerlabs.com>
Cc: linux-kernel@vger.kernel.org, ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH][BUGFIX] configfs: Fix symlink() to a removing item
Date: Mon, 16 Jun 2008 15:29:00 -0700 [thread overview]
Message-ID: <20080616222900.GD6441@mail.oracle.com> (raw)
In-Reply-To: <20080616180911.GV30804@localhost>
On Mon, Jun 16, 2008 at 08:09:11PM +0200, Louis Rilling wrote:
> This patch introduces a similar (weird?) behavior as with mkdir failures making
> rmdir fail: if symlink() races with rmdir() of the parent directory (or its
> youngest user-created ancestor if parent is a default group) or rmdir() of the
> target directory, and then fails in configfs_create(), this can make the racing
> rmdir() fail despite the concerned directory having no user-created entry (resp.
> no symlink pointing to it or one of its default groups) in the end.
> If this behavior is found unacceptable, I'll submit a fix in the same spirit as
> the racing mkdir() fix.
Ahh, but you can't wait on the mutex like you do in mkdir(),
because they're not ordered - it can race rename again.
Joel
--
Dort wo man B?cher verbrennt, verbrennt man am Ende auch Mensch.
(Wherever they burn books, they will also end up burning people.)
- Heinrich Heine
Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127
WARNING: multiple messages have this Message-ID (diff)
From: Joel Becker <Joel.Becker@oracle.com>
To: Louis Rilling <Louis.Rilling@kerlabs.com>
Cc: linux-kernel@vger.kernel.org, ocfs2-devel@oss.oracle.com
Subject: Re: [PATCH][BUGFIX] configfs: Fix symlink() to a removing item
Date: Mon, 16 Jun 2008 15:29:00 -0700 [thread overview]
Message-ID: <20080616222900.GD6441@mail.oracle.com> (raw)
In-Reply-To: <20080616180911.GV30804@localhost>
On Mon, Jun 16, 2008 at 08:09:11PM +0200, Louis Rilling wrote:
> This patch introduces a similar (weird?) behavior as with mkdir failures making
> rmdir fail: if symlink() races with rmdir() of the parent directory (or its
> youngest user-created ancestor if parent is a default group) or rmdir() of the
> target directory, and then fails in configfs_create(), this can make the racing
> rmdir() fail despite the concerned directory having no user-created entry (resp.
> no symlink pointing to it or one of its default groups) in the end.
> If this behavior is found unacceptable, I'll submit a fix in the same spirit as
> the racing mkdir() fix.
Ahh, but you can't wait on the mutex like you do in mkdir(),
because they're not ordered - it can race rename again.
Joel
--
Dort wo man Bücher verbrennt, verbrennt man am Ende auch Mensch.
(Wherever they burn books, they will also end up burning people.)
- Heinrich Heine
Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker@oracle.com
Phone: (650) 506-8127
next prev parent reply other threads:[~2008-06-16 22:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-16 18:09 [Ocfs2-devel] [PATCH][BUGFIX] configfs: Fix symlink() to a removing item Louis Rilling
2008-06-16 18:09 ` Louis Rilling
2008-06-16 22:29 ` Joel Becker [this message]
2008-06-16 22:29 ` Joel Becker
2008-06-17 10:42 ` [Ocfs2-devel] " Louis Rilling
2008-06-17 10:42 ` Louis Rilling
2008-06-17 12:56 ` [Ocfs2-devel] " Louis Rilling
2008-06-17 12:56 ` Louis Rilling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080616222900.GD6441@mail.oracle.com \
--to=joel.becker@oracle.com \
--cc=Louis.Rilling@kerlabs.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.