From: Colin D Bennett <colin@gibibit.com>
To: grub-devel@gnu.org
Subject: Re: [PATCH] Fix grub-install to use prefix for modules dir
Date: Tue, 17 Jun 2008 13:04:04 -0700 [thread overview]
Message-ID: <20080617130404.1e225725@gibibit.com> (raw)
In-Reply-To: <1213731972.31285.13.camel@dv>
On Tue, 17 Jun 2008 15:46:12 -0400
Pavel Roskin <proski@gnu.org> wrote:
> On Tue, 2008-06-17 at 10:51 -0700, Colin D Bennett wrote:
> > I fixed ``grub-install`` so it can function when installed
> > to a prefix other than ``/usr/local``. This simply meant adding
> >
> > --directory="${pkglibdir}
> >
> > to the command line arguments for grub_mkimage.
>
> The default is GRUB_LIBDIR, which is set to pkglibdir at the compile
> time. Your patch would have no effect if anything is compiled and
> installed properly.
>
> Maybe you are trying to change prefix during "make install"? That's
> not the best approach. DESTDIR should be used to install to a
> temporary location.
>
> Or maybe you have some other scenario in mind?
I'm not sure. All I know is that I did
./configure --prefix=/home/cdb/bin/grub && make && make install,
then I tried to do /home/cdb/bin/grub/bin/grub-install /media/sdc1 and
grub-mkimage was getting called with /usr/local/lib/something. Since I
specified --prefix to configure, I expect grub never ever to refer
to /usr/local. This patch fixed my problem.
Colin
next prev parent reply other threads:[~2008-06-17 21:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-17 17:51 [PATCH] Fix grub-install to use prefix for modules dir Colin D Bennett
2008-06-17 19:46 ` Pavel Roskin
2008-06-17 20:04 ` Colin D Bennett [this message]
2008-06-18 0:04 ` Pavel Roskin
2008-06-18 6:09 ` Colin D Bennett
2008-06-19 5:15 ` Pavel Roskin
2008-06-17 20:11 ` Isaac Dupree
2008-06-17 20:39 ` Colin D Bennett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080617130404.1e225725@gibibit.com \
--to=colin@gibibit.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.