All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bill Fink <billfink@mindspring.com>
To: Laurent Pinchart <laurentp@cse-semaphore.com>
Cc: linuxppc-dev@ozlabs.org, vbordug@ru.mvista.com, netdev@vger.kernel.org
Subject: Re: [PATCH] fs_enet: restore promiscuous and multicast settings in restart()
Date: Fri, 20 Jun 2008 13:50:13 -0400	[thread overview]
Message-ID: <20080620135013.36fbafa7.billfink@mindspring.com> (raw)
In-Reply-To: <200806201025.28768.laurentp@cse-semaphore.com>

On Fri, 20 Jun 2008, Laurent Pinchart wrote:

> On Friday 20 June 2008 05:01, Bill Fink wrote:
> > On Wed, 18 Jun 2008, Laurent Pinchart wrote:
> > 
> > > The restart() function is called when the link state changes and resets
> > > multicast and promiscous settings. This patch restores those settings at 
> the
> > > end of restart().
> > > 
> > > Signed-off-by: Laurent Pinchart <laurentp@cse-semaphore.com>
> > > ---
> > >  drivers/net/fs_enet/mac-fcc.c     |    3 +++
> > >  2 files changed, 4 insertions(+), 1 deletions(-)
> > 
> > Is the whole patch here?  The above says 2 files changed and 5 lines
> > changed, but what's included here is only 1 file and 3 line changes.
> 
> Yes it is. I've hand-removed a completely unrelated change that I had 
> committed to my git tree in the same go (back when I wasn't very familiar 
> with git). Do I need to resubmit ?

I can't answer that.  I just wanted to make sure part of the patch
wasn't accidentally left out.

						-Bill

WARNING: multiple messages have this Message-ID (diff)
From: Bill Fink <billfink@mindspring.com>
To: Laurent Pinchart <laurentp@cse-semaphore.com>
Cc: linuxppc-dev@ozlabs.org, netdev@vger.kernel.org,
	pantelis.antoniou@gmail.com, vbordug@ru.mvista.com
Subject: Re: [PATCH] fs_enet: restore promiscuous and multicast settings in restart()
Date: Fri, 20 Jun 2008 13:50:13 -0400	[thread overview]
Message-ID: <20080620135013.36fbafa7.billfink@mindspring.com> (raw)
In-Reply-To: <200806201025.28768.laurentp@cse-semaphore.com>

On Fri, 20 Jun 2008, Laurent Pinchart wrote:

> On Friday 20 June 2008 05:01, Bill Fink wrote:
> > On Wed, 18 Jun 2008, Laurent Pinchart wrote:
> > 
> > > The restart() function is called when the link state changes and resets
> > > multicast and promiscous settings. This patch restores those settings at 
> the
> > > end of restart().
> > > 
> > > Signed-off-by: Laurent Pinchart <laurentp@cse-semaphore.com>
> > > ---
> > >  drivers/net/fs_enet/mac-fcc.c     |    3 +++
> > >  2 files changed, 4 insertions(+), 1 deletions(-)
> > 
> > Is the whole patch here?  The above says 2 files changed and 5 lines
> > changed, but what's included here is only 1 file and 3 line changes.
> 
> Yes it is. I've hand-removed a completely unrelated change that I had 
> committed to my git tree in the same go (back when I wasn't very familiar 
> with git). Do I need to resubmit ?

I can't answer that.  I just wanted to make sure part of the patch
wasn't accidentally left out.

						-Bill

  parent reply	other threads:[~2008-06-20 17:50 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-18 15:07 [PATCH] fs_enet: restore promiscuous and multicast settings in restart() Laurent Pinchart
2008-06-18 18:45 ` Matvejchikov Ilya
2008-06-18 18:45   ` Matvejchikov Ilya
2008-06-19 18:20   ` Vitaly Bordug
2008-06-19 18:20     ` Vitaly Bordug
2008-06-19 18:47     ` Jon Loeliger
2008-06-19 18:47       ` Jon Loeliger
2008-06-19 19:15       ` Olof Johansson
2008-06-19 19:41     ` Matvejchikov Ilya
2008-06-19 19:41       ` Matvejchikov Ilya
2008-06-20  3:01 ` Bill Fink
2008-06-20  3:01   ` Bill Fink
2008-06-20  8:25   ` Laurent Pinchart
2008-06-20  8:25     ` Laurent Pinchart
2008-06-20  8:55     ` Matvejchikov Ilya
2008-06-20  8:55       ` Matvejchikov Ilya
2008-06-26  9:38       ` Laurent Pinchart
2008-06-26  9:38         ` Laurent Pinchart
2008-06-20 17:50     ` Bill Fink [this message]
2008-06-20 17:50       ` Bill Fink

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080620135013.36fbafa7.billfink@mindspring.com \
    --to=billfink@mindspring.com \
    --cc=laurentp@cse-semaphore.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=netdev@vger.kernel.org \
    --cc=vbordug@ru.mvista.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.