From: Joel Becker <Joel.Becker@oracle.com>
To: Louis Rilling <louis.rilling@kerlabs.com>
Cc: linux-kernel@vger.kernel.org, ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH] configfs: Fix failing symlink() making rmdir() fail
Date: Fri, 20 Jun 2008 15:42:42 -0700 [thread overview]
Message-ID: <20080620224242.GE21416@mail.oracle.com> (raw)
In-Reply-To: <1213963762-11678-1-git-send-email-louis.rilling@kerlabs.com>
On Fri, Jun 20, 2008 at 02:09:22PM +0200, Louis Rilling wrote:
> What about this other solution? By the way, it does not even need to
> rename CONFIGFS_USET_IN_MKDIR.
I like it. My first thought was "why doesn't he take the mutex
during configfs_unlink()?", but the unlink is protected enough by
dirent_lock.
Joel
--
"Reality is merely an illusion, albeit a very persistent one."
- Albert Einstien
Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127
WARNING: multiple messages have this Message-ID (diff)
From: Joel Becker <Joel.Becker@oracle.com>
To: Louis Rilling <louis.rilling@kerlabs.com>
Cc: linux-kernel@vger.kernel.org, ocfs2-devel@oss.oracle.com
Subject: Re: [PATCH] configfs: Fix failing symlink() making rmdir() fail
Date: Fri, 20 Jun 2008 15:42:42 -0700 [thread overview]
Message-ID: <20080620224242.GE21416@mail.oracle.com> (raw)
In-Reply-To: <1213963762-11678-1-git-send-email-louis.rilling@kerlabs.com>
On Fri, Jun 20, 2008 at 02:09:22PM +0200, Louis Rilling wrote:
> What about this other solution? By the way, it does not even need to
> rename CONFIGFS_USET_IN_MKDIR.
I like it. My first thought was "why doesn't he take the mutex
during configfs_unlink()?", but the unlink is protected enough by
dirent_lock.
Joel
--
"Reality is merely an illusion, albeit a very persistent one."
- Albert Einstien
Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker@oracle.com
Phone: (650) 506-8127
next prev parent reply other threads:[~2008-06-20 22:42 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-17 17:37 [Ocfs2-devel] [BUGFIX][PATCH 0/3] configfs: symlink() fixes Louis Rilling
2008-06-17 17:37 ` Louis Rilling
2008-06-17 17:37 ` [Ocfs2-devel] [BUGFIX][PATCH 1/3] configfs: Fix symlink() to a removing item Louis Rilling
2008-06-17 17:37 ` Louis Rilling
2008-06-17 22:17 ` [Ocfs2-devel] " Joel Becker
2008-06-17 22:17 ` Joel Becker
2008-06-17 17:37 ` [Ocfs2-devel] [BUGFIX][PATCH 2/3] configfs: Rename CONFIGFS_USET_IN_MKDIR to CONFIGFS_USET_ATTACHING Louis Rilling
2008-06-17 17:37 ` Louis Rilling
2008-06-17 17:37 ` [Ocfs2-devel] [BUGFIX][PATCH 3/3] configfs: Fix failing symlink() making rmdir() fail Louis Rilling
2008-06-17 17:37 ` Louis Rilling
2008-06-17 22:15 ` [Ocfs2-devel] " Joel Becker
2008-06-17 22:15 ` Joel Becker
2008-06-18 11:40 ` [Ocfs2-devel] " Louis Rilling
2008-06-18 11:40 ` Louis Rilling
2008-06-18 20:11 ` [Ocfs2-devel] " Joel Becker
2008-06-18 20:11 ` Joel Becker
2008-06-19 9:28 ` [Ocfs2-devel] " Louis Rilling
2008-06-19 9:28 ` Louis Rilling
2008-06-19 22:03 ` [Ocfs2-devel] " Joel Becker
2008-06-19 22:03 ` Joel Becker
2008-06-19 22:16 ` [Ocfs2-devel] " Joel Becker
2008-06-19 22:16 ` Joel Becker
2008-06-20 12:09 ` [Ocfs2-devel] [PATCH] " Louis Rilling
2008-06-20 12:09 ` Louis Rilling
2008-06-20 22:42 ` Joel Becker [this message]
2008-06-20 22:42 ` Joel Becker
2008-06-20 22:44 ` [Ocfs2-devel] " Joel Becker
2008-06-20 22:44 ` Joel Becker
2008-06-23 12:05 ` [Ocfs2-devel] " Louis Rilling
2008-06-23 12:05 ` Louis Rilling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080620224242.GE21416@mail.oracle.com \
--to=joel.becker@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=louis.rilling@kerlabs.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.