* - pnp-remove-ratelimit-on-add-resource-failures.patch removed from -mm tree
@ 2008-05-14 2:43 akpm
0 siblings, 0 replies; 2+ messages in thread
From: akpm @ 2008-05-14 2:43 UTC (permalink / raw)
To: bjorn.helgaas, abelay, castet.matthieu, lenb, perex, rene.herman,
shaohua.li, tiwai, trenn, mm-commit
The patch titled
pnp: remove ratelimit on add resource failures
has been removed from the -mm tree. Its filename was
pnp-remove-ratelimit-on-add-resource-failures.patch
This patch was dropped because it had testing failures
The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
------------------------------------------------------
Subject: pnp: remove ratelimit on add resource failures
From: Bjorn Helgaas <bjorn.helgaas@hp.com>
We used to have a fixed-size resource table. If a device had twenty resources
when the table only had space for ten, we didn't need ten warnings, so we
added the ratelimit.
Now that we can dynamically allocate new resources, we should only get
failures if the allocation fails. That should be rare enough that we don't
need to ratelimit the messages.
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Cc: Len Brown <lenb@kernel.org>
Cc: Adam M Belay <abelay@mit.edu>
Cc: Li Shaohua <shaohua.li@intel.com>
Cc: Matthieu Castet <castet.matthieu@free.fr>
Cc: Thomas Renninger <trenn@suse.de>
Cc: Rene Herman <rene.herman@keyaccess.nl>
Cc: Jaroslav Kysela <perex@perex.cz>
Cc: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
drivers/pnp/resource.c | 34 ++++++++--------------------------
1 file changed, 8 insertions(+), 26 deletions(-)
diff -puN drivers/pnp/resource.c~pnp-remove-ratelimit-on-add-resource-failures drivers/pnp/resource.c
--- a/drivers/pnp/resource.c~pnp-remove-ratelimit-on-add-resource-failures
+++ a/drivers/pnp/resource.c
@@ -537,15 +537,10 @@ struct pnp_resource *pnp_add_irq_resourc
{
struct pnp_resource *pnp_res;
struct resource *res;
- static unsigned char warned;
pnp_res = pnp_new_resource(dev);
if (!pnp_res) {
- if (!warned) {
- dev_err(&dev->dev, "can't add resource for IRQ %d\n",
- irq);
- warned = 1;
- }
+ dev_err(&dev->dev, "can't add resource for IRQ %d\n", irq);
return NULL;
}
@@ -563,15 +558,10 @@ struct pnp_resource *pnp_add_dma_resourc
{
struct pnp_resource *pnp_res;
struct resource *res;
- static unsigned char warned;
pnp_res = pnp_new_resource(dev);
if (!pnp_res) {
- if (!warned) {
- dev_err(&dev->dev, "can't add resource for DMA %d\n",
- dma);
- warned = 1;
- }
+ dev_err(&dev->dev, "can't add resource for DMA %d\n", dma);
return NULL;
}
@@ -590,16 +580,12 @@ struct pnp_resource *pnp_add_io_resource
{
struct pnp_resource *pnp_res;
struct resource *res;
- static unsigned char warned;
pnp_res = pnp_new_resource(dev);
if (!pnp_res) {
- if (!warned) {
- dev_err(&dev->dev, "can't add resource for IO "
- "%#llx-%#llx\n",(unsigned long long) start,
- (unsigned long long) end);
- warned = 1;
- }
+ dev_err(&dev->dev, "can't add resource for IO %#llx-%#llx\n",
+ (unsigned long long) start,
+ (unsigned long long) end);
return NULL;
}
@@ -619,16 +605,12 @@ struct pnp_resource *pnp_add_mem_resourc
{
struct pnp_resource *pnp_res;
struct resource *res;
- static unsigned char warned;
pnp_res = pnp_new_resource(dev);
if (!pnp_res) {
- if (!warned) {
- dev_err(&dev->dev, "can't add resource for MEM "
- "%#llx-%#llx\n",(unsigned long long) start,
- (unsigned long long) end);
- warned = 1;
- }
+ dev_err(&dev->dev, "can't add resource for MEM %#llx-%#llx\n",
+ (unsigned long long) start,
+ (unsigned long long) end);
return NULL;
}
_
Patches currently in -mm which might be from bjorn.helgaas@hp.com are
origin.patch
acpi_pm_device_sleep_state-cleanup.patch
acpi-fix-drivers-acpi-gluec-build-error.patch
mm-only-enforce-acpi-resource-conflict-checks.patch
pnp-cleanup-pnp_fixup_device.patch
pnp-add-pnp_build_option-to-the-api.patch
pnp-add-isapnp-mpu-option-quirks.patch
pnp-add-detail-to-debug-resource-dump.patch
pnp-remove-pnp_resourceindex.patch
pnp-add-pnp_resource_type-internal-interface.patch
pnp-add-pnp_resource_type_name-helper-function.patch
pnp-remove-ratelimit-on-add-resource-failures.patch
pnp-dont-sort-by-type-in-sys-resources.patch
make-pnp_add_card_id-static.patch
^ permalink raw reply [flat|nested] 2+ messages in thread
* - pnp-remove-ratelimit-on-add-resource-failures.patch removed from -mm tree
@ 2008-06-23 21:03 akpm
0 siblings, 0 replies; 2+ messages in thread
From: akpm @ 2008-06-23 21:03 UTC (permalink / raw)
To: bjorn.helgaas, abelay, ambx1, castet.matthieu, perex, rene.herman,
shaohua.li, tiwai, trenn, mm-commi
The patch titled
pnp: remove ratelimit on add resource failures
has been removed from the -mm tree. Its filename was
pnp-remove-ratelimit-on-add-resource-failures.patch
This patch was dropped because it was merged into mainline or a subsystem tree
The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
------------------------------------------------------
Subject: pnp: remove ratelimit on add resource failures
From: Bjorn Helgaas <bjorn.helgaas@hp.com>
We used to have a fixed-size resource table. If a device had
twenty resources when the table only had space for ten, we didn't
need ten warnings, so we added the ratelimit.
Now that we can dynamically allocate new resources, we should
only get failures if the allocation fails. That should be
rare enough that we don't need to ratelimit the messages.
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Cc: Adam Belay <ambx1@neo.rr.com>
Cc: Adam M Belay <abelay@mit.edu>
Cc: Li Shaohua <shaohua.li@intel.com>
Cc: Matthieu Castet <castet.matthieu@free.fr>
Cc: Thomas Renninger <trenn@suse.de>
Cc: Rene Herman <rene.herman@keyaccess.nl>
Cc: Jaroslav Kysela <perex@perex.cz>
Cc: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
drivers/pnp/resource.c | 34 ++++++++--------------------------
1 file changed, 8 insertions(+), 26 deletions(-)
diff -puN drivers/pnp/resource.c~pnp-remove-ratelimit-on-add-resource-failures drivers/pnp/resource.c
--- a/drivers/pnp/resource.c~pnp-remove-ratelimit-on-add-resource-failures
+++ a/drivers/pnp/resource.c
@@ -537,15 +537,10 @@ struct pnp_resource *pnp_add_irq_resourc
{
struct pnp_resource *pnp_res;
struct resource *res;
- static unsigned char warned;
pnp_res = pnp_new_resource(dev);
if (!pnp_res) {
- if (!warned) {
- dev_err(&dev->dev, "can't add resource for IRQ %d\n",
- irq);
- warned = 1;
- }
+ dev_err(&dev->dev, "can't add resource for IRQ %d\n", irq);
return NULL;
}
@@ -563,15 +558,10 @@ struct pnp_resource *pnp_add_dma_resourc
{
struct pnp_resource *pnp_res;
struct resource *res;
- static unsigned char warned;
pnp_res = pnp_new_resource(dev);
if (!pnp_res) {
- if (!warned) {
- dev_err(&dev->dev, "can't add resource for DMA %d\n",
- dma);
- warned = 1;
- }
+ dev_err(&dev->dev, "can't add resource for DMA %d\n", dma);
return NULL;
}
@@ -590,16 +580,12 @@ struct pnp_resource *pnp_add_io_resource
{
struct pnp_resource *pnp_res;
struct resource *res;
- static unsigned char warned;
pnp_res = pnp_new_resource(dev);
if (!pnp_res) {
- if (!warned) {
- dev_err(&dev->dev, "can't add resource for IO "
- "%#llx-%#llx\n",(unsigned long long) start,
- (unsigned long long) end);
- warned = 1;
- }
+ dev_err(&dev->dev, "can't add resource for IO %#llx-%#llx\n",
+ (unsigned long long) start,
+ (unsigned long long) end);
return NULL;
}
@@ -619,16 +605,12 @@ struct pnp_resource *pnp_add_mem_resourc
{
struct pnp_resource *pnp_res;
struct resource *res;
- static unsigned char warned;
pnp_res = pnp_new_resource(dev);
if (!pnp_res) {
- if (!warned) {
- dev_err(&dev->dev, "can't add resource for MEM "
- "%#llx-%#llx\n",(unsigned long long) start,
- (unsigned long long) end);
- warned = 1;
- }
+ dev_err(&dev->dev, "can't add resource for MEM %#llx-%#llx\n",
+ (unsigned long long) start,
+ (unsigned long long) end);
return NULL;
}
_
Patches currently in -mm which might be from bjorn.helgaas@hp.com are
linux-next.patch
mm-only-enforce-acpi-resource-conflict-checks.patch
pnp-set-the-pnp_card-dma_mask-for-use-by-isapnp-cards.patch
isa-set-24-bit-dma_mask-for-isa-devices.patch
make-pnp_add_card_id-static.patch
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-06-23 21:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-06-23 21:03 - pnp-remove-ratelimit-on-add-resource-failures.patch removed from -mm tree akpm
-- strict thread matches above, loose matches on Subject: below --
2008-05-14 2:43 akpm
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.