All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joel Becker <Joel.Becker@oracle.com>
To: Louis Rilling <louis.rilling@kerlabs.com>
Cc: linux-kernel@vger.kernel.org, ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH 0/2]v2 configfs: symlink() fixes
Date: Mon, 23 Jun 2008 15:20:44 -0700	[thread overview]
Message-ID: <20080623222043.GG592@mail.oracle.com> (raw)
In-Reply-To: <1214223378-14203-1-git-send-email-louis.rilling@kerlabs.com>

On Mon, Jun 23, 2008 at 02:16:16PM +0200, Louis Rilling wrote:
> The following patchset fixes incorrect symlinks to dead items in configfs, which
> are forbidden by specification.
> 
> The first patch actually prevents such dangling symlinks from being created, but
> introduces a weird(?) behavior where a failing symlink() can make a racing
> rmdir() fail in the symlink's parent and in the symlink's target as well. This
> behavior is fixed with the next patch.

	Silly question: you've tested this, right?

Joel

-- 

"I almost ran over an angel
 He had a nice big fat cigar.
 'In a sense,' he said, 'You're alone here
 So if you jump, you'd best jump far.'"

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127

WARNING: multiple messages have this Message-ID (diff)
From: Joel Becker <Joel.Becker@oracle.com>
To: Louis Rilling <louis.rilling@kerlabs.com>
Cc: linux-kernel@vger.kernel.org, ocfs2-devel@oss.oracle.com
Subject: Re: [PATCH 0/2]v2 configfs: symlink() fixes
Date: Mon, 23 Jun 2008 15:20:44 -0700	[thread overview]
Message-ID: <20080623222043.GG592@mail.oracle.com> (raw)
In-Reply-To: <1214223378-14203-1-git-send-email-louis.rilling@kerlabs.com>

On Mon, Jun 23, 2008 at 02:16:16PM +0200, Louis Rilling wrote:
> The following patchset fixes incorrect symlinks to dead items in configfs, which
> are forbidden by specification.
> 
> The first patch actually prevents such dangling symlinks from being created, but
> introduces a weird(?) behavior where a failing symlink() can make a racing
> rmdir() fail in the symlink's parent and in the symlink's target as well. This
> behavior is fixed with the next patch.

	Silly question: you've tested this, right?

Joel

-- 

"I almost ran over an angel
 He had a nice big fat cigar.
 'In a sense,' he said, 'You're alone here
 So if you jump, you'd best jump far.'"

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker@oracle.com
Phone: (650) 506-8127

  parent reply	other threads:[~2008-06-23 22:20 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-23 12:16 [Ocfs2-devel] [PATCH 0/2]v2 configfs: symlink() fixes Louis Rilling
2008-06-23 12:16 ` Louis Rilling
2008-06-23 12:16 ` [Ocfs2-devel] [PATCH 1/2] configfs: Fix symlink() to a removing item Louis Rilling
2008-06-23 12:16   ` Louis Rilling
2008-06-23 12:16 ` [Ocfs2-devel] [PATCH 2/2] configfs: Fix failing symlink() making rmdir() fail Louis Rilling
2008-06-23 12:16   ` Louis Rilling
2008-06-23 22:20 ` Joel Becker [this message]
2008-06-23 22:20   ` [PATCH 0/2]v2 configfs: symlink() fixes Joel Becker
2008-06-24 13:20   ` [Ocfs2-devel] " Louis Rilling
2008-06-24 13:20     ` Louis Rilling
2008-06-24 17:04     ` [Ocfs2-devel] " Joel Becker
2008-06-24 17:04       ` Joel Becker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080623222043.GG592@mail.oracle.com \
    --to=joel.becker@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=louis.rilling@kerlabs.com \
    --cc=ocfs2-devel@oss.oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.