From: Joel Becker <Joel.Becker@oracle.com>
To: Louis Rilling <Louis.Rilling@kerlabs.com>
Cc: linux-kernel@vger.kernel.org, ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] configfs: Q: item leak in a failing configfs_attach_group()?
Date: Tue, 24 Jun 2008 10:10:51 -0700 [thread overview]
Message-ID: <20080624171051.GD4184@ca-server1.us.oracle.com> (raw)
In-Reply-To: <20080624141649.GH7621@hawkmoon.kerlabs.com>
On Tue, Jun 24, 2008 at 04:16:49PM +0200, Louis Rilling wrote:
> Hi,
>
> I'd like an opinion on the following scenario:
>
> process 1: process 2:
> configfs_mkdir("A")
> attach_group("A")
> attach_item("A")
> d_instantiate("A")
> populate_groups("A")
> mutex_lock("A")
> attach_group("A/B")
> attach_item("A")
> d_instantiate("A/B")
> mkdir("A/B/C")
> do_path_lookup("A/B/C", LOOKUP_PARENT)
This has to sleep until
configfs_mkdir("A") finishes.
It's waiting on A->d_parent's
i_mutex, which is held by
sys_mkdirat().
Joel
--
"Sometimes one pays most for the things one gets for nothing."
- Albert Einstein
Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127
WARNING: multiple messages have this Message-ID (diff)
From: Joel Becker <Joel.Becker@oracle.com>
To: Louis Rilling <Louis.Rilling@kerlabs.com>
Cc: linux-kernel@vger.kernel.org, ocfs2-devel@oss.oracle.com
Subject: Re: configfs: Q: item leak in a failing configfs_attach_group()?
Date: Tue, 24 Jun 2008 10:10:51 -0700 [thread overview]
Message-ID: <20080624171051.GD4184@ca-server1.us.oracle.com> (raw)
In-Reply-To: <20080624141649.GH7621@hawkmoon.kerlabs.com>
On Tue, Jun 24, 2008 at 04:16:49PM +0200, Louis Rilling wrote:
> Hi,
>
> I'd like an opinion on the following scenario:
>
> process 1: process 2:
> configfs_mkdir("A")
> attach_group("A")
> attach_item("A")
> d_instantiate("A")
> populate_groups("A")
> mutex_lock("A")
> attach_group("A/B")
> attach_item("A")
> d_instantiate("A/B")
> mkdir("A/B/C")
> do_path_lookup("A/B/C", LOOKUP_PARENT)
This has to sleep until
configfs_mkdir("A") finishes.
It's waiting on A->d_parent's
i_mutex, which is held by
sys_mkdirat().
Joel
--
"Sometimes one pays most for the things one gets for nothing."
- Albert Einstein
Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker@oracle.com
Phone: (650) 506-8127
next prev parent reply other threads:[~2008-06-24 17:10 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-24 14:16 [Ocfs2-devel] configfs: Q: item leak in a failing configfs_attach_group()? Louis Rilling
2008-06-24 14:16 ` Louis Rilling
2008-06-24 17:10 ` Joel Becker [this message]
2008-06-24 17:10 ` Joel Becker
2008-06-24 18:04 ` [Ocfs2-devel] " Louis Rilling
2008-06-24 18:04 ` Louis Rilling
2008-06-24 21:34 ` [Ocfs2-devel] " Joel Becker
2008-06-24 21:34 ` Joel Becker
2008-06-25 9:55 ` [Ocfs2-devel] " Louis Rilling
2008-06-25 9:55 ` Louis Rilling
2008-06-25 20:20 ` [Ocfs2-devel] " Joel Becker
2008-06-25 20:20 ` Joel Becker
2008-06-25 20:29 ` [Ocfs2-devel] " Joel Becker
2008-06-25 20:29 ` Joel Becker
2008-06-26 2:12 ` [Ocfs2-devel] " Joel Becker
2008-06-26 2:12 ` Joel Becker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080624171051.GD4184@ca-server1.us.oracle.com \
--to=joel.becker@oracle.com \
--cc=Louis.Rilling@kerlabs.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.