* [PATCH] maple: tidy maple_driver code by removing redundant
@ 2008-06-15 19:48 ` Adrian McMenamin
0 siblings, 0 replies; 8+ messages in thread
From: Adrian McMenamin @ 2008-06-15 19:48 UTC (permalink / raw)
To: Paul Mundt; +Cc: lkml, linux-sh
The connect and disconnect functions are unnecessary - everything they do can be
accomplished in the initial probe - so remove them.
Signed-off-by: Adrian McMenamin <adrian@mcmen.demon.co.uk>
---
diff --git a/include/linux/maple.h b/include/linux/maple.h
index 39a125a..d49e2d3 100644
--- a/include/linux/maple.h
+++ b/include/linux/maple.h
@@ -62,8 +62,6 @@ struct maple_device {
struct maple_driver {
unsigned long function;
- int (*connect) (struct maple_device * dev);
- void (*disconnect) (struct maple_device * dev);
struct device_driver drv;
};
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH] maple: tidy maple_driver code by removing redundant connect/disconnect
@ 2008-06-15 19:48 ` Adrian McMenamin
0 siblings, 0 replies; 8+ messages in thread
From: Adrian McMenamin @ 2008-06-15 19:48 UTC (permalink / raw)
To: Paul Mundt; +Cc: lkml, linux-sh
The connect and disconnect functions are unnecessary - everything they do can be
accomplished in the initial probe - so remove them.
Signed-off-by: Adrian McMenamin <adrian@mcmen.demon.co.uk>
---
diff --git a/include/linux/maple.h b/include/linux/maple.h
index 39a125a..d49e2d3 100644
--- a/include/linux/maple.h
+++ b/include/linux/maple.h
@@ -62,8 +62,6 @@ struct maple_device {
struct maple_driver {
unsigned long function;
- int (*connect) (struct maple_device * dev);
- void (*disconnect) (struct maple_device * dev);
struct device_driver drv;
};
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] maple: tidy maple_driver code by removing redundant connect/disconnect
2008-06-15 19:48 ` [PATCH] maple: tidy maple_driver code by removing redundant connect/disconnect Adrian McMenamin
@ 2008-06-24 4:01 ` Paul Mundt
-1 siblings, 0 replies; 8+ messages in thread
From: Paul Mundt @ 2008-06-24 4:01 UTC (permalink / raw)
To: Adrian McMenamin; +Cc: lkml, linux-sh
On Sun, Jun 15, 2008 at 08:48:09PM +0100, Adrian McMenamin wrote:
> The connect and disconnect functions are unnecessary - everything they do can be
> accomplished in the initial probe - so remove them.
>
> Signed-off-by: Adrian McMenamin <adrian@mcmen.demon.co.uk>
Applied, thanks.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] maple: tidy maple_driver code by removing redundant connect/disconnect
@ 2008-06-24 4:01 ` Paul Mundt
0 siblings, 0 replies; 8+ messages in thread
From: Paul Mundt @ 2008-06-24 4:01 UTC (permalink / raw)
To: Adrian McMenamin; +Cc: lkml, linux-sh
On Sun, Jun 15, 2008 at 08:48:09PM +0100, Adrian McMenamin wrote:
> The connect and disconnect functions are unnecessary - everything they do can be
> accomplished in the initial probe - so remove them.
>
> Signed-off-by: Adrian McMenamin <adrian@mcmen.demon.co.uk>
Applied, thanks.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] maple: tidy maple_driver code by removing redundant
2008-06-24 4:01 ` Paul Mundt
@ 2008-06-24 10:59 ` Adrian McMenamin
-1 siblings, 0 replies; 8+ messages in thread
From: Adrian McMenamin @ 2008-06-24 10:59 UTC (permalink / raw)
To: Paul Mundt, lkml, linux-sh
On Tue, June 24, 2008 5:01 am, Paul Mundt wrote:
> On Sun, Jun 15, 2008 at 08:48:09PM +0100, Adrian McMenamin wrote:
>> The connect and disconnect functions are unnecessary - everything they
>> do can be
>> accomplished in the initial probe - so remove them.
>>
>> Signed-off-by: Adrian McMenamin <adrian@mcmen.demon.co.uk>
>
> Applied, thanks.
>
Paul,
Just to note that this (http://lkml.org/lkml/2008/6/15/122) will break the
keyboard driver unless this (http://lkml.org/lkml/2008/6/15/121) is also
applied.
I haven't heard back from Dmitry on the keyboard patch yet.
Adrian
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] maple: tidy maple_driver code by removing redundant connect/disconnect
@ 2008-06-24 10:59 ` Adrian McMenamin
0 siblings, 0 replies; 8+ messages in thread
From: Adrian McMenamin @ 2008-06-24 10:59 UTC (permalink / raw)
To: Paul Mundt, lkml, linux-sh
On Tue, June 24, 2008 5:01 am, Paul Mundt wrote:
> On Sun, Jun 15, 2008 at 08:48:09PM +0100, Adrian McMenamin wrote:
>> The connect and disconnect functions are unnecessary - everything they
>> do can be
>> accomplished in the initial probe - so remove them.
>>
>> Signed-off-by: Adrian McMenamin <adrian@mcmen.demon.co.uk>
>
> Applied, thanks.
>
Paul,
Just to note that this (http://lkml.org/lkml/2008/6/15/122) will break the
keyboard driver unless this (http://lkml.org/lkml/2008/6/15/121) is also
applied.
I haven't heard back from Dmitry on the keyboard patch yet.
Adrian
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] maple: tidy maple_driver code by removing redundant
2008-06-24 10:59 ` [PATCH] maple: tidy maple_driver code by removing redundant connect/disconnect Adrian McMenamin
@ 2008-06-24 20:01 ` Paul Mundt
-1 siblings, 0 replies; 8+ messages in thread
From: Paul Mundt @ 2008-06-24 20:01 UTC (permalink / raw)
To: Adrian McMenamin; +Cc: lkml, linux-sh
On Tue, Jun 24, 2008 at 11:59:07AM +0100, Adrian McMenamin wrote:
> On Tue, June 24, 2008 5:01 am, Paul Mundt wrote:
> > On Sun, Jun 15, 2008 at 08:48:09PM +0100, Adrian McMenamin wrote:
> >> The connect and disconnect functions are unnecessary - everything they
> >> do can be
> >> accomplished in the initial probe - so remove them.
> >>
> >> Signed-off-by: Adrian McMenamin <adrian@mcmen.demon.co.uk>
> >
> > Applied, thanks.
> >
> Paul,
>
> Just to note that this (http://lkml.org/lkml/2008/6/15/122) will break the
> keyboard driver unless this (http://lkml.org/lkml/2008/6/15/121) is also
> applied.
>
> I haven't heard back from Dmitry on the keyboard patch yet.
>
Yes, I'm aware of that. This should fix itself in linux-next once it is
merged in the input tree, and I don't intend on pushing my changes until
that's in place, so we don't break bisection.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] maple: tidy maple_driver code by removing redundant connect/disconnect
@ 2008-06-24 20:01 ` Paul Mundt
0 siblings, 0 replies; 8+ messages in thread
From: Paul Mundt @ 2008-06-24 20:01 UTC (permalink / raw)
To: Adrian McMenamin; +Cc: lkml, linux-sh
On Tue, Jun 24, 2008 at 11:59:07AM +0100, Adrian McMenamin wrote:
> On Tue, June 24, 2008 5:01 am, Paul Mundt wrote:
> > On Sun, Jun 15, 2008 at 08:48:09PM +0100, Adrian McMenamin wrote:
> >> The connect and disconnect functions are unnecessary - everything they
> >> do can be
> >> accomplished in the initial probe - so remove them.
> >>
> >> Signed-off-by: Adrian McMenamin <adrian@mcmen.demon.co.uk>
> >
> > Applied, thanks.
> >
> Paul,
>
> Just to note that this (http://lkml.org/lkml/2008/6/15/122) will break the
> keyboard driver unless this (http://lkml.org/lkml/2008/6/15/121) is also
> applied.
>
> I haven't heard back from Dmitry on the keyboard patch yet.
>
Yes, I'm aware of that. This should fix itself in linux-next once it is
merged in the input tree, and I don't intend on pushing my changes until
that's in place, so we don't break bisection.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2008-06-24 20:01 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-06-15 19:48 [PATCH] maple: tidy maple_driver code by removing redundant Adrian McMenamin
2008-06-15 19:48 ` [PATCH] maple: tidy maple_driver code by removing redundant connect/disconnect Adrian McMenamin
2008-06-24 4:01 ` Paul Mundt
2008-06-24 4:01 ` Paul Mundt
2008-06-24 10:59 ` [PATCH] maple: tidy maple_driver code by removing redundant Adrian McMenamin
2008-06-24 10:59 ` [PATCH] maple: tidy maple_driver code by removing redundant connect/disconnect Adrian McMenamin
2008-06-24 20:01 ` [PATCH] maple: tidy maple_driver code by removing redundant Paul Mundt
2008-06-24 20:01 ` [PATCH] maple: tidy maple_driver code by removing redundant connect/disconnect Paul Mundt
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.