From: Peter Baumann <waste.manager@gmx.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Christian Holtje <docwhat@gmail.com>
Subject: Re: [PATCH] Ship sample hooks with .sample suffix
Date: Wed, 25 Jun 2008 05:18:54 +0000 [thread overview]
Message-ID: <20080625051854.GA11813@m62s10.vlinux.de> (raw)
In-Reply-To: <7vtzfi8dvk.fsf_-_@gitster.siamese.dyndns.org>
On Tue, Jun 24, 2008 at 07:09:03PM -0700, Junio C Hamano wrote:
> We used to mark hooks we ship as samples by making them unexecutable, but
> some filesystems cannot tell what is executable and what is not.
>
> This makes it much more explicit. The hooks are suffixed with .sample
> (but now are made executable), so enabling it is still one step operation
> (instead of "chmod +x $hook", you would do "mv $hook.sample $hook") but
> now they won't get accidentally enabled on systems without executable bit.
>
Wouldn't it be better to name the hooks $hook.deactivated so its obvious
to anybody that they are not executed? Just my 2 cents.
-Peter
prev parent reply other threads:[~2008-06-25 5:20 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-24 16:23 [PATCH] pre-commit hook should ignore carriage returns at EOL Christian Holtje
2008-06-24 18:22 ` Alf Clement
2008-06-24 18:26 ` Ian Hilt
2008-06-24 19:05 ` Jakub Narebski
2008-06-24 19:54 ` Ian Hilt
2008-06-24 20:09 ` Jakub Narebski
2008-06-24 20:36 ` Ian Hilt
2008-06-24 19:16 ` Christian Holtje
2008-06-24 22:31 ` Junio C Hamano
2008-06-24 23:25 ` Christian Holtje
2008-06-24 23:34 ` Jakub Narebski
2008-06-24 23:39 ` Junio C Hamano
2008-06-25 0:19 ` Christian Holtje
2008-06-24 23:59 ` Junio C Hamano
2008-06-25 2:09 ` [PATCH] Ship sample hooks with .sample suffix Junio C Hamano
2008-06-25 2:48 ` Junio C Hamano
2008-06-25 6:51 ` Johannes Sixt
2008-06-25 8:09 ` Junio C Hamano
2008-06-26 7:19 ` Johannes Sixt
2008-06-26 7:28 ` Junio C Hamano
2008-06-25 5:18 ` Peter Baumann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080625051854.GA11813@m62s10.vlinux.de \
--to=waste.manager@gmx.de \
--cc=docwhat@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.