All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Johannes Sixt <johannes.sixt@telecom.at>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Ship sample hooks with .sample suffix
Date: Tue, 24 Jun 2008 19:48:18 -0700	[thread overview]
Message-ID: <7vod5q8c25.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <7vtzfi8dvk.fsf_-_@gitster.siamese.dyndns.org> (Junio C. Hamano's message of "Tue, 24 Jun 2008 19:09:03 -0700")

I'll queue the patch to 'master' and I suspect that this will make 31d6632
(Windows: Change the name of hook scripts to make them not executable.,
2007-11-30) unnecessary.

I've looked at diff between ee1e0a3 (the original "pull" request) and
8fd39ba (after WS fixup on borrowed code and other changes).

They all looked fine except for git.c::main() where do .. while does not
have a { } around the body (which is not required by C language but it
just looked funny).

I am very tempted to pull MinGW series directly to 'master', or at least
to 'next', perhaps after dropping 31d6632.  What's your confidence level
on the series?  I think we should give this series extra priority so that
any potential issues with other series (like dr/ceil) that do pathname
traversal will become more apparent sooner rather than later.

  reply	other threads:[~2008-06-25  2:49 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-24 16:23 [PATCH] pre-commit hook should ignore carriage returns at EOL Christian Holtje
2008-06-24 18:22 ` Alf Clement
2008-06-24 18:26 ` Ian Hilt
2008-06-24 19:05   ` Jakub Narebski
2008-06-24 19:54     ` Ian Hilt
2008-06-24 20:09       ` Jakub Narebski
2008-06-24 20:36         ` Ian Hilt
2008-06-24 19:16   ` Christian Holtje
2008-06-24 22:31     ` Junio C Hamano
2008-06-24 23:25       ` Christian Holtje
2008-06-24 23:34         ` Jakub Narebski
2008-06-24 23:39           ` Junio C Hamano
2008-06-25  0:19             ` Christian Holtje
2008-06-24 23:59         ` Junio C Hamano
2008-06-25  2:09           ` [PATCH] Ship sample hooks with .sample suffix Junio C Hamano
2008-06-25  2:48             ` Junio C Hamano [this message]
2008-06-25  6:51               ` Johannes Sixt
2008-06-25  8:09                 ` Junio C Hamano
2008-06-26  7:19               ` Johannes Sixt
2008-06-26  7:28                 ` Junio C Hamano
2008-06-25  5:18             ` Peter Baumann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vod5q8c25.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=johannes.sixt@telecom.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.