From: Teemu Likonen <tlikonen@iki.fi>
To: Nicolas Pitre <nico@cam.org>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH] factorize pack structure allocation
Date: Wed, 25 Jun 2008 10:19:20 +0300 [thread overview]
Message-ID: <20080625071920.GA3307@mithlond.arda.local> (raw)
In-Reply-To: <alpine.LFD.1.10.0806241851420.2979@xanadu.home>
Nicolas Pitre wrote (2008-06-24 18:58 -0400):
> New pack structures are currently allocated in 2 different places
> and all members have to be initialized explicitly. This is prone
> to errors leading to segmentation faults as found by Teemu Likonen.
>
> Let's have a common place where this structure is allocated, and have
> all members implicitly initialized to zero.
>
> Signed-off-by: Nicolas Pitre <nico@cam.org>
Because of time zone issues I didn't get a chance to check this until
now. This fixes the segfault issue for me. Thanks!
next prev parent reply other threads:[~2008-06-25 7:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-24 22:58 [PATCH] factorize pack structure allocation Nicolas Pitre
2008-06-24 23:13 ` Jon Loeliger
2008-06-25 3:22 ` Junio C Hamano
2008-06-25 7:19 ` Teemu Likonen [this message]
2008-06-26 6:40 ` Andreas Ericsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080625071920.GA3307@mithlond.arda.local \
--to=tlikonen@iki.fi \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=nico@cam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.