All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Nicolas Pitre <nico@cam.org>
Cc: git@vger.kernel.org, Teemu Likonen <tlikonen@iki.fi>
Subject: Re: [PATCH] factorize pack structure allocation
Date: Tue, 24 Jun 2008 20:22:36 -0700	[thread overview]
Message-ID: <7vtzfi6vwj.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: alpine.LFD.1.10.0806241851420.2979@xanadu.home

Nicolas Pitre <nico@cam.org> writes:

> New pack structures are currently allocated in 2 different places
> and all members have to be initialized explicitly.  This is prone
> to errors leading to segmentation faults as found by Teemu Likonen.

Thanks.  This is a much better equivalent to the "probably fixed with
this" patch you sent earlier ;-)

  parent reply	other threads:[~2008-06-25  3:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-24 22:58 [PATCH] factorize pack structure allocation Nicolas Pitre
2008-06-24 23:13 ` Jon Loeliger
2008-06-25  3:22 ` Junio C Hamano [this message]
2008-06-25  7:19 ` Teemu Likonen
2008-06-26  6:40 ` Andreas Ericsson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vtzfi6vwj.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=nico@cam.org \
    --cc=tlikonen@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.