From: Eric Wong <normalperson@yhbt.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Avery Pennarun <apenwarr@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH/RFC] git-svn: sanitize_remote_name should accept underscores.
Date: Wed, 25 Jun 2008 00:45:48 -0700 [thread overview]
Message-ID: <20080625074548.GA8984@hand.yhbt.net> (raw)
In-Reply-To: <7vfxr23s6m.fsf@gitster.siamese.dyndns.org>
Junio C Hamano <gitster@pobox.com> wrote:
> Eric Wong <normalperson@yhbt.net> writes:
>
> > Wait, nevermind, this is for remotes, not remote *branches*.
> >
> > Umm... are underscores now allowed in git config files?
>
> In
>
> [foo "bar"] baz = value
>
> foo and baz must be config.c::iskeychar() (and baz must be isalpha()), but
> "bar" can be almost anything.
>
> Isn't "not underscore" coming from DNS hostname part restriction?
No, nothing to do with DNS hostnames in the remote names. I think I
just looked at remotes2config.sh one day and used it as a reference :x
It's late and I've had a rough few days, but shouldn't
sanitize_remote_name() just escape . and "? Right now it's converting
stuff to . which has me very confused...
--
Eric Wong (in need of sleep and sanity atm...)
next prev parent reply other threads:[~2008-06-25 7:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-24 15:54 [PATCH/RFC] git-svn: sanitize_remote_name should accept underscores Avery Pennarun
2008-06-25 6:44 ` Eric Wong
2008-06-25 6:55 ` Eric Wong
2008-06-25 7:11 ` Junio C Hamano
2008-06-25 7:45 ` Eric Wong [this message]
2008-06-25 15:01 ` Avery Pennarun
2008-06-29 3:40 ` [PATCH] git-svn: don't sanitize remote names in config Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080625074548.GA8984@hand.yhbt.net \
--to=normalperson@yhbt.net \
--cc=apenwarr@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.