All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Eric Wong <normalperson@yhbt.net>
Cc: Avery Pennarun <apenwarr@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH/RFC] git-svn: sanitize_remote_name should accept underscores.
Date: Wed, 25 Jun 2008 00:11:13 -0700	[thread overview]
Message-ID: <7vfxr23s6m.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20080625065556.GM21299@hand.yhbt.net> (Eric Wong's message of "Tue, 24 Jun 2008 23:55:56 -0700")

Eric Wong <normalperson@yhbt.net> writes:

> Wait, nevermind, this is for remotes, not remote *branches*.
>
> Umm... are underscores now allowed in git config files?

In

	[foo "bar"] baz = value

foo and baz must be config.c::iskeychar() (and baz must be isalpha()), but
"bar" can be almost anything.

Isn't "not underscore" coming from DNS hostname part restriction?

  reply	other threads:[~2008-06-25  7:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-24 15:54 [PATCH/RFC] git-svn: sanitize_remote_name should accept underscores Avery Pennarun
2008-06-25  6:44 ` Eric Wong
2008-06-25  6:55   ` Eric Wong
2008-06-25  7:11     ` Junio C Hamano [this message]
2008-06-25  7:45       ` Eric Wong
2008-06-25 15:01         ` Avery Pennarun
2008-06-29  3:40           ` [PATCH] git-svn: don't sanitize remote names in config Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vfxr23s6m.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=apenwarr@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=normalperson@yhbt.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.