All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcelo Tosatti <mtosatti@redhat.com>
To: Avi Kivity <avi@qumranet.com>, Anthony Liguori <aliguori@us.ibm.com>
Cc: Alexandre Oliva <aoliva@redhat.com>, kvm-devel <kvm@vger.kernel.org>
Subject: KVM: pvmmu breakage with gcc 4.3.0
Date: Wed, 25 Jun 2008 23:10:47 -0300	[thread overview]
Message-ID: <20080626021047.GA10263@dmt.cnet> (raw)


Some pvmmu functions store their commands on stack, and newer GCC
versions conclude that these commands are unused.

So stick an inline asm statement to convince the compiler otherwise.

Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>


diff --git a/arch/x86/kernel/kvm.c b/arch/x86/kernel/kvm.c
index 8b7a3cf..c892752 100644
--- a/arch/x86/kernel/kvm.c
+++ b/arch/x86/kernel/kvm.c
@@ -55,6 +55,12 @@ static void kvm_mmu_op(void *buffer, unsigned len)
 	int r;
 	unsigned long a1, a2;
 
+	/*
+   	 * GCC 4.3.0 concludes that on-stack kvm_mmu_op* is unused and
+   	 * optimizes its initialization away.
+ 	 */
+        asm ("" : : "p" (buffer));
+
 	do {
 		a1 = __pa(buffer);
 		a2 = 0;   /* on i386 __pa() always returns <4G */

             reply	other threads:[~2008-06-26  2:11 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-26  2:10 Marcelo Tosatti [this message]
2008-06-26  3:10 ` KVM: pvmmu breakage with gcc 4.3.0 Anthony Liguori
2008-06-26 13:18   ` Christian Borntraeger
2008-06-26 18:06   ` Alexandre Oliva
2008-06-29  8:56     ` Avi Kivity
2008-06-26 11:43 ` Avi Kivity
2008-06-26 12:47   ` Anthony Liguori
2008-06-27 16:11     ` Bill Davidsen
2008-06-26 15:08   ` Christian Borntraeger
2008-06-26 15:21     ` Anthony Liguori
2008-06-26 15:41     ` Anthony Liguori
2008-06-26 16:34       ` Christian Borntraeger
2008-06-29 10:16     ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080626021047.GA10263@dmt.cnet \
    --to=mtosatti@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=aoliva@redhat.com \
    --cc=avi@qumranet.com \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.