From: Nye Liu <nyet@mrv.com>
To: linux-kernel@vger.kernel.org
Cc: scottwood@freescale.com, linuxppc-dev@ozlabs.org
Subject: [PATCH] POWERPC CPM: Minor cosmetic changes to udbg_putc
Date: Fri, 27 Jun 2008 13:01:00 -0700 [thread overview]
Message-ID: <20080627200100.GA16661@mrv.com> (raw)
From: Nye Liu <nyet@mrv.com>
udbg_putc is a *function pointer* that is initialized during
udbg_init_cpm. It might not be initialized properly when called from
udbg_putc_cpm(), so (recursively) call udbg_putc_cpm() directly.
Printing an "X" on initialization is ugly. How about a "\n" instead?
Signed-off-by: Nye Liu <nyet@mrv.com>
---
diff --git a/arch/powerpc/sysdev/cpm_common.c b/arch/powerpc/sysdev/cpm_common.c
index cb7df2d..dcde743 100644
--- a/arch/powerpc/sysdev/cpm_common.c
+++ b/arch/powerpc/sysdev/cpm_common.c
@@ -37,7 +37,7 @@ static void udbg_putc_cpm(char c)
u8 __iomem *txbuf = (u8 __iomem __force *)in_be32(&cpm_udbg_txdesc[1]);
if (c == '\n')
- udbg_putc('\r');
+ udbg_putc_cpm('\r');
while (in_be32(&cpm_udbg_txdesc[0]) & 0x80000000)
;
@@ -53,7 +53,7 @@ void __init udbg_init_cpm(void)
setbat(1, 0xf0000000, 0xf0000000, 1024*1024, _PAGE_IO);
#endif
udbg_putc = udbg_putc_cpm;
- udbg_putc('X');
+ udbg_putc('\n');
}
}
#endif
--
Nye Liu
nliu@mrv.com
(818) 772-6235x248
(818) 772-0576 fax
"Who would be stupid enough to quote a fictitious character?"
-- Don Quixote
next reply other threads:[~2008-06-27 20:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-27 20:01 Nye Liu [this message]
2008-06-27 20:11 ` [PATCH] POWERPC CPM: Minor cosmetic changes to udbg_putc Scott Wood
2008-06-27 20:11 ` Scott Wood
2008-07-02 7:37 ` Kumar Gala
2008-07-02 7:37 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080627200100.GA16661@mrv.com \
--to=nyet@mrv.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.