From: Scott Wood <scottwood@freescale.com>
To: Nye Liu <nyet@mrv.com>
Cc: linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] POWERPC CPM: Minor cosmetic changes to udbg_putc
Date: Fri, 27 Jun 2008 15:11:32 -0500 [thread overview]
Message-ID: <48654974.6060200@freescale.com> (raw)
In-Reply-To: <20080627200100.GA16661@mrv.com>
Nye Liu wrote:
> udbg_putc is a *function pointer* that is initialized during
> udbg_init_cpm. It might not be initialized properly when called from
> udbg_putc_cpm(), so (recursively) call udbg_putc_cpm() directly.
ACK
> Printing an "X" on initialization is ugly. How about a "\n" instead?
D'oh, that was a debugging leftover that I missed when cleaning things
up. Just remove it.
-Scott
WARNING: multiple messages have this Message-ID (diff)
From: Scott Wood <scottwood@freescale.com>
To: Nye Liu <nyet@mrv.com>
Cc: linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] POWERPC CPM: Minor cosmetic changes to udbg_putc
Date: Fri, 27 Jun 2008 15:11:32 -0500 [thread overview]
Message-ID: <48654974.6060200@freescale.com> (raw)
In-Reply-To: <20080627200100.GA16661@mrv.com>
Nye Liu wrote:
> udbg_putc is a *function pointer* that is initialized during
> udbg_init_cpm. It might not be initialized properly when called from
> udbg_putc_cpm(), so (recursively) call udbg_putc_cpm() directly.
ACK
> Printing an "X" on initialization is ugly. How about a "\n" instead?
D'oh, that was a debugging leftover that I missed when cleaning things
up. Just remove it.
-Scott
next prev parent reply other threads:[~2008-06-27 20:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-27 20:01 [PATCH] POWERPC CPM: Minor cosmetic changes to udbg_putc Nye Liu
2008-06-27 20:11 ` Scott Wood [this message]
2008-06-27 20:11 ` Scott Wood
2008-07-02 7:37 ` Kumar Gala
2008-07-02 7:37 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48654974.6060200@freescale.com \
--to=scottwood@freescale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=nyet@mrv.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.