From: Ingo Molnar <mingo@elte.hu>
To: Abhishek Sagar <sagar.abhishek@gmail.com>
Cc: David Miller <davem@davemloft.net>,
Alexander Beregalov <a.beregalov@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-next@vger.kernel.org, sparclinux@vger.kernel.org,
rostedt@goodmis.org
Subject: Re: next-0630: sparc64: build failed
Date: Tue, 1 Jul 2008 22:03:44 +0200 [thread overview]
Message-ID: <20080701200344.GA4896@elte.hu> (raw)
In-Reply-To: <486A7C19.5080905@gmail.com>
* Abhishek Sagar <sagar.abhishek@gmail.com> wrote:
> Hi Ingo/David,
>
> CONFIG_MCOUNT currently controls the compilation with -pg flag and the
> export of _mcount. But with ftrace, the former is redundant and the
> latter should be made unconditional since _mcount is always defined.
> In which case, does the inlined patch (untested) make sense? It should
> solve the build failure as well.
hm, mcount is the facility - so it makes sense to have that defined.
Here you basically hide CONFIG_MCOUNT:
> -ifeq ($(CONFIG_MCOUNT),y)
> - KBUILD_CFLAGS += -pg
> +ifneq ($(CONFIG_FTRACE),y)
> +ifeq ($(CONFIG_STACK_DEBUG),y)
> +KBUILD_CFLAGS += -pg
> +endif
> endif
via two conditions. I'm not sure that's a win and i found CONFIG_MCOUNT
a logical switch - but it's David's call.
Ingo
WARNING: multiple messages have this Message-ID (diff)
From: Ingo Molnar <mingo@elte.hu>
To: Abhishek Sagar <sagar.abhishek@gmail.com>
Cc: David Miller <davem@davemloft.net>,
Alexander Beregalov <a.beregalov@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-next@vger.kernel.org, sparclinux@vger.kernel.org,
rostedt@goodmis.org
Subject: Re: next-0630: sparc64: build failed
Date: Tue, 01 Jul 2008 20:03:44 +0000 [thread overview]
Message-ID: <20080701200344.GA4896@elte.hu> (raw)
In-Reply-To: <486A7C19.5080905@gmail.com>
* Abhishek Sagar <sagar.abhishek@gmail.com> wrote:
> Hi Ingo/David,
>
> CONFIG_MCOUNT currently controls the compilation with -pg flag and the
> export of _mcount. But with ftrace, the former is redundant and the
> latter should be made unconditional since _mcount is always defined.
> In which case, does the inlined patch (untested) make sense? It should
> solve the build failure as well.
hm, mcount is the facility - so it makes sense to have that defined.
Here you basically hide CONFIG_MCOUNT:
> -ifeq ($(CONFIG_MCOUNT),y)
> - KBUILD_CFLAGS += -pg
> +ifneq ($(CONFIG_FTRACE),y)
> +ifeq ($(CONFIG_STACK_DEBUG),y)
> +KBUILD_CFLAGS += -pg
> +endif
> endif
via two conditions. I'm not sure that's a win and i found CONFIG_MCOUNT
a logical switch - but it's David's call.
Ingo
next prev parent reply other threads:[~2008-07-01 20:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-01 15:25 next-0630: sparc64: build failed Alexander Beregalov
2008-07-01 15:25 ` Alexander Beregalov
2008-07-01 15:25 ` Alexander Beregalov
2008-07-01 15:46 ` Ingo Molnar
2008-07-01 15:46 ` Ingo Molnar
2008-07-01 18:48 ` Abhishek Sagar
2008-07-01 18:52 ` Abhishek Sagar
2008-07-01 20:03 ` Ingo Molnar [this message]
2008-07-01 20:03 ` Ingo Molnar
2008-07-02 4:22 ` Abhishek Sagar
2008-07-02 4:34 ` Abhishek Sagar
2008-07-02 9:10 ` Alexander Beregalov
2008-07-02 9:10 ` Alexander Beregalov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080701200344.GA4896@elte.hu \
--to=mingo@elte.hu \
--cc=a.beregalov@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=sagar.abhishek@gmail.com \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.