* [PATCH] mfd: fix a bug in the asic3 irq demux code @ 2008-07-02 17:42 Philipp Zabel 2008-07-02 17:53 ` Andrew Morton 2008-07-03 9:25 ` Samuel Ortiz 0 siblings, 2 replies; 8+ messages in thread From: Philipp Zabel @ 2008-07-02 17:42 UTC (permalink / raw) To: LKML; +Cc: Andrew Morton, Samuel Ortiz Wrong irq numbers were given to desc->handle_irq, which on some devices caused endless loops (asic3_irq_demux calling itself, basically). Signed-off-by: Philipp Zabel <philipp.zabel@gmail.com> --- drivers/mfd/asic3.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/mfd/asic3.c b/drivers/mfd/asic3.c index 8e41130..59ec9c6 100644 --- a/drivers/mfd/asic3.c +++ b/drivers/mfd/asic3.c @@ -308,7 +308,7 @@ static void asic3_irq_demux(unsigned int irq, struct irq_desc *desc) for (i = ASIC3_NUM_GPIOS; i < ASIC3_NR_IRQS; i++) { /* They start at bit 4 and go up */ if (status & (1 << (i - ASIC3_NUM_GPIOS + 4))) { - desc = irq_desc + + i; + desc = irq_desc + asic->irq_base + i; desc->handle_irq(asic->irq_base + i, desc); } -- 1.5.6 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] mfd: fix a bug in the asic3 irq demux code 2008-07-02 17:42 [PATCH] mfd: fix a bug in the asic3 irq demux code Philipp Zabel @ 2008-07-02 17:53 ` Andrew Morton 2008-07-02 18:22 ` Samuel Ortiz 2008-07-03 9:25 ` Samuel Ortiz 1 sibling, 1 reply; 8+ messages in thread From: Andrew Morton @ 2008-07-02 17:53 UTC (permalink / raw) To: Philipp Zabel; +Cc: LKML, Samuel Ortiz On Wed, 02 Jul 2008 19:42:53 +0200 Philipp Zabel <philipp.zabel@gmail.com> wrote: > Wrong irq numbers were given to desc->handle_irq, which > on some devices caused endless loops (asic3_irq_demux > calling itself, basically). > > Signed-off-by: Philipp Zabel <philipp.zabel@gmail.com> > --- > drivers/mfd/asic3.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/mfd/asic3.c b/drivers/mfd/asic3.c > index 8e41130..59ec9c6 100644 > --- a/drivers/mfd/asic3.c > +++ b/drivers/mfd/asic3.c > @@ -308,7 +308,7 @@ static void asic3_irq_demux(unsigned int irq, struct irq_desc *desc) > for (i = ASIC3_NUM_GPIOS; i < ASIC3_NR_IRQS; i++) { > /* They start at bit 4 and go up */ > if (status & (1 << (i - ASIC3_NUM_GPIOS + 4))) { > - desc = irq_desc + + i; > + desc = irq_desc + asic->irq_base + i; > desc->handle_irq(asic->irq_base + i, > desc); > } hm, I seem to have a pile of mfd patches. I'll look to offload those on Samuel. Samuel, will you be setting up an MFD git tree for linux-next? (You should, please). ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] mfd: fix a bug in the asic3 irq demux code 2008-07-02 17:53 ` Andrew Morton @ 2008-07-02 18:22 ` Samuel Ortiz 2008-07-02 18:57 ` Andrew Morton 2008-07-02 18:59 ` Andrew Morton 0 siblings, 2 replies; 8+ messages in thread From: Samuel Ortiz @ 2008-07-02 18:22 UTC (permalink / raw) To: Andrew Morton; +Cc: Philipp Zabel, LKML Hi Andrew, On Wed, Jul 02, 2008 at 10:53:03AM -0700, Andrew Morton wrote: > On Wed, 02 Jul 2008 19:42:53 +0200 Philipp Zabel <philipp.zabel@gmail.com> wrote: > > > Wrong irq numbers were given to desc->handle_irq, which > > on some devices caused endless loops (asic3_irq_demux > > calling itself, basically). > > > > Signed-off-by: Philipp Zabel <philipp.zabel@gmail.com> > > --- > > drivers/mfd/asic3.c | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/drivers/mfd/asic3.c b/drivers/mfd/asic3.c > > index 8e41130..59ec9c6 100644 > > --- a/drivers/mfd/asic3.c > > +++ b/drivers/mfd/asic3.c > > @@ -308,7 +308,7 @@ static void asic3_irq_demux(unsigned int irq, struct irq_desc *desc) > > for (i = ASIC3_NUM_GPIOS; i < ASIC3_NR_IRQS; i++) { > > /* They start at bit 4 and go up */ > > if (status & (1 << (i - ASIC3_NUM_GPIOS + 4))) { > > - desc = irq_desc + + i; > > + desc = irq_desc + asic->irq_base + i; > > desc->handle_irq(asic->irq_base + i, > > desc); > > } > > hm, I seem to have a pile of mfd patches. I'll look to offload those > on Samuel. > > Samuel, will you be setting up an MFD git tree for linux-next? (You > should, please). I have set up an mfd tree here: http://git.o-hand.com/?r=linux-mfd with a for-next branch. I havent asked Stephen to pull from it yet, and I havent Cc'ed you on the mfd patches that are sitting there as I was mostly setting things up. I will clean things up and re-apply them so that you get a notification for all the mfd patches that are already on -mm. I also requested for an account on kernel.org, but I'm still waiting for an answer. Cheers, Samuel. ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] mfd: fix a bug in the asic3 irq demux code 2008-07-02 18:22 ` Samuel Ortiz @ 2008-07-02 18:57 ` Andrew Morton 2008-07-02 21:18 ` Samuel Ortiz 2008-07-02 18:59 ` Andrew Morton 1 sibling, 1 reply; 8+ messages in thread From: Andrew Morton @ 2008-07-02 18:57 UTC (permalink / raw) To: Samuel Ortiz; +Cc: philipp.zabel, linux-kernel On Wed, 2 Jul 2008 20:22:20 +0200 Samuel Ortiz <sameo@openedhand.com> wrote: > Hi Andrew, > > On Wed, Jul 02, 2008 at 10:53:03AM -0700, Andrew Morton wrote: > > On Wed, 02 Jul 2008 19:42:53 +0200 Philipp Zabel <philipp.zabel@gmail.com> wrote: > > > > > Wrong irq numbers were given to desc->handle_irq, which > > > on some devices caused endless loops (asic3_irq_demux > > > calling itself, basically). > > > > > > Signed-off-by: Philipp Zabel <philipp.zabel@gmail.com> > > > --- > > > drivers/mfd/asic3.c | 2 +- > > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > > > diff --git a/drivers/mfd/asic3.c b/drivers/mfd/asic3.c > > > index 8e41130..59ec9c6 100644 > > > --- a/drivers/mfd/asic3.c > > > +++ b/drivers/mfd/asic3.c > > > @@ -308,7 +308,7 @@ static void asic3_irq_demux(unsigned int irq, struct irq_desc *desc) > > > for (i = ASIC3_NUM_GPIOS; i < ASIC3_NR_IRQS; i++) { > > > /* They start at bit 4 and go up */ > > > if (status & (1 << (i - ASIC3_NUM_GPIOS + 4))) { > > > - desc = irq_desc + + i; > > > + desc = irq_desc + asic->irq_base + i; > > > desc->handle_irq(asic->irq_base + i, > > > desc); > > > } > > > > hm, I seem to have a pile of mfd patches. I'll look to offload those > > on Samuel. > > > > Samuel, will you be setting up an MFD git tree for linux-next? (You > > should, please). > I have set up an mfd tree here: http://git.o-hand.com/?r=linux-mfd > with a for-next branch. OK, thanks. Linus gets upset over git-over-http for some reason, so I'd suggest that you move to kernel.org when that is set up. Plus: I pull from lots of different git servers and it's quite common that at least one of them is dead. It was git://www.linux-m32r.org yesterday. > I havent asked Stephen to pull from it yet, > and I havent Cc'ed you on the mfd patches that are sitting there as > I was mostly setting things up. I will clean things up and re-apply > them so that you get a notification for all the mfd patches that are > already on -mm. > > I also requested for an account on kernel.org, but I'm still waiting > for an answer. Cool. I assume that sameo@openedhand.com is now the preferred address? Will samuel@sortiz.org continue to work? ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] mfd: fix a bug in the asic3 irq demux code 2008-07-02 18:57 ` Andrew Morton @ 2008-07-02 21:18 ` Samuel Ortiz 0 siblings, 0 replies; 8+ messages in thread From: Samuel Ortiz @ 2008-07-02 21:18 UTC (permalink / raw) To: Andrew Morton; +Cc: philipp.zabel, linux-kernel On Wed, Jul 02, 2008 at 11:57:26AM -0700, Andrew Morton wrote: > On Wed, 2 Jul 2008 20:22:20 +0200 > Samuel Ortiz <sameo@openedhand.com> wrote: > > > Hi Andrew, > > > > On Wed, Jul 02, 2008 at 10:53:03AM -0700, Andrew Morton wrote: > > > On Wed, 02 Jul 2008 19:42:53 +0200 Philipp Zabel <philipp.zabel@gmail.com> wrote: > > > > > > > Wrong irq numbers were given to desc->handle_irq, which > > > > on some devices caused endless loops (asic3_irq_demux > > > > calling itself, basically). > > > > > > > > Signed-off-by: Philipp Zabel <philipp.zabel@gmail.com> > > > > --- > > > > drivers/mfd/asic3.c | 2 +- > > > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > > > > > diff --git a/drivers/mfd/asic3.c b/drivers/mfd/asic3.c > > > > index 8e41130..59ec9c6 100644 > > > > --- a/drivers/mfd/asic3.c > > > > +++ b/drivers/mfd/asic3.c > > > > @@ -308,7 +308,7 @@ static void asic3_irq_demux(unsigned int irq, struct irq_desc *desc) > > > > for (i = ASIC3_NUM_GPIOS; i < ASIC3_NR_IRQS; i++) { > > > > /* They start at bit 4 and go up */ > > > > if (status & (1 << (i - ASIC3_NUM_GPIOS + 4))) { > > > > - desc = irq_desc + + i; > > > > + desc = irq_desc + asic->irq_base + i; > > > > desc->handle_irq(asic->irq_base + i, > > > > desc); > > > > } > > > > > > hm, I seem to have a pile of mfd patches. I'll look to offload those > > > on Samuel. > > > > > > Samuel, will you be setting up an MFD git tree for linux-next? (You > > > should, please). > > I have set up an mfd tree here: http://git.o-hand.com/?r=linux-mfd > > with a for-next branch. > > OK, thanks. Linus gets upset over git-over-http for some reason, so > I'd suggest that you move to kernel.org when that is set up. Oh, this is only the gitweb interface, the git address is: git://git.o-hand.com/linux-mfd.git But please dont pull from it right now. I'll let you (and Stephen) know whenever it is ready for pulling. > Plus: I pull from lots of different git servers and it's quite common > that at least one of them is dead. It was git://www.linux-m32r.org > yesterday. If I get an account on kernel.org, I'll definitely move over there. > > I havent asked Stephen to pull from it yet, > > and I havent Cc'ed you on the mfd patches that are sitting there as > > I was mostly setting things up. I will clean things up and re-apply > > them so that you get a notification for all the mfd patches that are > > already on -mm. > > > > I also requested for an account on kernel.org, but I'm still waiting > > for an answer. > > Cool. > > I assume that sameo@openedhand.com is now the preferred address? Will > samuel@sortiz.org continue to work? Both will work. I'll do the MFD work from my @openedhand.com address and my IrDA one from @sortiz.org Cheers, Samuel. ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] mfd: fix a bug in the asic3 irq demux code 2008-07-02 18:22 ` Samuel Ortiz 2008-07-02 18:57 ` Andrew Morton @ 2008-07-02 18:59 ` Andrew Morton 2008-07-02 21:20 ` Samuel Ortiz 1 sibling, 1 reply; 8+ messages in thread From: Andrew Morton @ 2008-07-02 18:59 UTC (permalink / raw) To: Samuel Ortiz; +Cc: philipp.zabel, linux-kernel On Wed, 2 Jul 2008 20:22:20 +0200 Samuel Ortiz <sameo@openedhand.com> wrote: > I have set up an mfd tree here: http://git.o-hand.com/?r=linux-mfd > with a for-next branch Hang on, that's not a git URL. What's the preferred git:// URL? Thanks. ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] mfd: fix a bug in the asic3 irq demux code 2008-07-02 18:59 ` Andrew Morton @ 2008-07-02 21:20 ` Samuel Ortiz 0 siblings, 0 replies; 8+ messages in thread From: Samuel Ortiz @ 2008-07-02 21:20 UTC (permalink / raw) To: Andrew Morton; +Cc: philipp.zabel, linux-kernel On Wed, Jul 02, 2008 at 11:59:03AM -0700, Andrew Morton wrote: > On Wed, 2 Jul 2008 20:22:20 +0200 > Samuel Ortiz <sameo@openedhand.com> wrote: > > > I have set up an mfd tree here: http://git.o-hand.com/?r=linux-mfd > > with a for-next branch > > Hang on, that's not a git URL. What's the preferred git:// URL? git://git.o-hand.com/linux-mfd.git should do it. Cheers, Samuel. ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] mfd: fix a bug in the asic3 irq demux code 2008-07-02 17:42 [PATCH] mfd: fix a bug in the asic3 irq demux code Philipp Zabel 2008-07-02 17:53 ` Andrew Morton @ 2008-07-03 9:25 ` Samuel Ortiz 1 sibling, 0 replies; 8+ messages in thread From: Samuel Ortiz @ 2008-07-03 9:25 UTC (permalink / raw) To: Philipp Zabel; +Cc: LKML, Andrew Morton Hi Philipp, On Wed, Jul 02, 2008 at 07:42:53PM +0200, Philipp Zabel wrote: > Wrong irq numbers were given to desc->handle_irq, which > on some devices caused endless loops (asic3_irq_demux > calling itself, basically). Thanks, applied to my mfd tree. Cheers, Samuel. > Signed-off-by: Philipp Zabel <philipp.zabel@gmail.com> > --- > drivers/mfd/asic3.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/mfd/asic3.c b/drivers/mfd/asic3.c > index 8e41130..59ec9c6 100644 > --- a/drivers/mfd/asic3.c > +++ b/drivers/mfd/asic3.c > @@ -308,7 +308,7 @@ static void asic3_irq_demux(unsigned int irq, struct irq_desc *desc) > for (i = ASIC3_NUM_GPIOS; i < ASIC3_NR_IRQS; i++) { > /* They start at bit 4 and go up */ > if (status & (1 << (i - ASIC3_NUM_GPIOS + 4))) { > - desc = irq_desc + + i; > + desc = irq_desc + asic->irq_base + i; > desc->handle_irq(asic->irq_base + i, > desc); > } > -- > 1.5.6 > > ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2008-07-03 12:58 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2008-07-02 17:42 [PATCH] mfd: fix a bug in the asic3 irq demux code Philipp Zabel 2008-07-02 17:53 ` Andrew Morton 2008-07-02 18:22 ` Samuel Ortiz 2008-07-02 18:57 ` Andrew Morton 2008-07-02 21:18 ` Samuel Ortiz 2008-07-02 18:59 ` Andrew Morton 2008-07-02 21:20 ` Samuel Ortiz 2008-07-03 9:25 ` Samuel Ortiz
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.