Re: [Bridge] [patch] data element sizes netlink fixes for rstpd

Re: [Bridge] [patch] data element sizes netlink fixes for rstpd

[Srinivas M.A.]

Sorry for the delayed reply.
Thanks for the fix.
I have applied this to my local git repository.

On Thu, Jun 5, 2008 at 2:42 AM, Solomon Peachy <solomon@linux-wlan.com> wrote:
> The attached patch, against Srinivas's git snapshot of May 7, fixes
> two releated problems.  The kernel's netlink handlers relating to the
> IFLA_OPERSTATE attribute use an 8-bit field, while the rstpd code was
> assuming a 32-bit integer.
>
> This might have worked on little-endian target, but the BE boxen I'm
> using crap all over the place with bogus numbers.
>
> With this patch, my BE boxen (with 2.6.22.x) come up and RSTP-away.
>
>  - Solomon
> --
> Solomon Peachy                        solomon@linux-wlan.com
> AbsoluteValue Systems                 http://www.linux-wlan.com
> 721-D North Drive                     +1 (321) 259-0737  (office)
> Melbourne, FL 32934                   +1 (321) 259-0286  (fax)
>

Re: [Bridge] [patch] data element sizes netlink fixes for rstpd

[Solomon Peachy]

[-- Attachment #1: Type: text/plain, Size: 688 bytes --]

On Wed, Jul 02, 2008 at 10:07:53PM +0530, Srinivas M.A. wrote:
> Sorry for the delayed reply.
> Thanks for the fix.
> I have applied this to my local git repository.

Have there been any other changes since the last snapshot you published?

We've had some unexplained crashes of rstpd that I'm trying to diagnose 
now, but my gut feeling is that there are other endian-related bugs in 
the codebase. 

 - Solomon
-- 
Solomon Peachy                        solomon@linux-wlan.com
AbsoluteValue Systems                 http://www.linux-wlan.com
721-D North Drive                     +1 (321) 259-0737  (office)
Melbourne, FL 32934                   +1 (321) 259-0286  (fax)

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

Re: [Bridge] [patch] data element sizes netlink fixes for rstpd

[Srinivas M.A.]

On Thu, Jul 3, 2008 at 1:53 AM, Solomon Peachy <solomon@linux-wlan.com> wrote:
> On Wed, Jul 02, 2008 at 10:07:53PM +0530, Srinivas M.A. wrote:

> Have there been any other changes since the last snapshot you published?

Nothing of significance. I put in a slightly simpler bridge-stp script.

>
> We've had some unexplained crashes of rstpd that I'm trying to diagnose
> now, but my gut feeling is that there are other endian-related bugs in
> the codebase.

Possible, we have only tested on x86 and x86_64.
If you can send me backtraces of the crashes, I will try and debug.