From: Christoph Hellwig <hch@infradead.org>
To: Denys Vlasenko <vda.linux@googlemail.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Deinline a few functions in mmap.c
Date: Sat, 5 Jul 2008 13:10:24 -0400 [thread overview]
Message-ID: <20080705171024.GA4723@infradead.org> (raw)
In-Reply-To: <200807051837.30219.vda.linux@googlemail.com>
On Sat, Jul 05, 2008 at 06:37:30PM +0200, Denys Vlasenko wrote:
> #if defined(CONFIG_STACK_GROWSUP) || defined(CONFIG_IA64)
> /*
> * PA-RISC uses this for its stack; IA64 for its Register Backing Store.
> * vma is the last one with address > vma->vm_end. Have to extend vma.
> */
> #ifndef CONFIG_IA64
> -static inline
> +static
> #endif
Unrelated note, but I think this ifdef should go. We've always prefered
slightly less possible optimizations over horribly ugly ifdefs.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Denys Vlasenko <vda.linux@googlemail.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Deinline a few functions in mmap.c
Date: Sat, 5 Jul 2008 13:10:24 -0400 [thread overview]
Message-ID: <20080705171024.GA4723@infradead.org> (raw)
In-Reply-To: <200807051837.30219.vda.linux@googlemail.com>
On Sat, Jul 05, 2008 at 06:37:30PM +0200, Denys Vlasenko wrote:
> #if defined(CONFIG_STACK_GROWSUP) || defined(CONFIG_IA64)
> /*
> * PA-RISC uses this for its stack; IA64 for its Register Backing Store.
> * vma is the last one with address > vma->vm_end. Have to extend vma.
> */
> #ifndef CONFIG_IA64
> -static inline
> +static
> #endif
Unrelated note, but I think this ifdef should go. We've always prefered
slightly less possible optimizations over horribly ugly ifdefs.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-07-05 17:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-05 16:37 [PATCH] Deinline a few functions in mmap.c Denys Vlasenko
2008-07-05 16:37 ` Denys Vlasenko
2008-07-05 17:10 ` Christoph Hellwig [this message]
2008-07-05 17:10 ` Christoph Hellwig
2008-07-22 9:37 ` Andrew Morton
2008-07-22 9:37 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080705171024.GA4723@infradead.org \
--to=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=vda.linux@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.