From: Stephen Hemminger <shemminger@vyatta.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, notting@redhat.com
Subject: Re: [Bridge] [RFC PATCH 0/2] Allow full bridge configuration via sysfs
Date: Mon, 7 Jul 2008 15:04:54 -0700 [thread overview]
Message-ID: <20080707150454.2a02a217@extreme> (raw)
In-Reply-To: <20080707.145259.103902820.davem@davemloft.net>
On Mon, 07 Jul 2008 14:52:59 -0700 (PDT)
David Miller <davem@davemloft.net> wrote:
> From: Bill Nottingham <notting@redhat.com>
> Date: Mon, 7 Jul 2008 17:34:20 -0400
>
> > I could look at wireless network configuration, but I doubt that's going to
> > help your argument.
>
> Just like any system with age, we have a lot of legacy to
> convert over. But it will happen.
>
> > That being said, how is moving from adding a bonding slave from:
> > echo "+eth0" > /sys/class/net/bond0/bonding/slaves to:
> > to:
> > http://www.linuxfoundation.org/en/Net:Generic_Netlink_HOWTO
> >
> > a worthwhile improvement for the admin? Let's see, a kernel-userspace
> > protocol with magic message formats. Hey, we reinvented ioctl!
> >
> > Why, if netlink is the standard (and it's been around for a long
> > damn time), was sysfs configuration for bonding added in 2005? Why
> > was bridge configuration added in 2005, and *extended* in 2006 and
> > 2007? Why were the user-space tools such as brctl ported from ioctl
> > to sysfs?
>
> Because often a lot of shit slips in when someone who understands
> the ramifications is too busy or on vacation.
>
> We do want everything to be netlink based.
>
> Why?
>
> Because it means that you can run one monitoring tool to listen
> for netlink events and report them to the user for diagnosis.
>
> It means that network configuration events can be sent over
> the wire and used remotely at some point.
>
> The latter can never happen as long as we keep adding ad-hoc
> config stuff.
There are always historical reasons. In this case it was because I knew
more about sysfs than netlink, and there was no netlink interface for managing
interfaces back in 2005. Sysfs is okay for simple stuff (set forward-delay to 10seconds),
but it falls down when anything interesting and transactional happens. Think of
sysfs as more an extension of per-device sysctl's or module parameters, rather
than a good configuration interface.
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Hemminger <shemminger@vyatta.com>
To: David Miller <davem@davemloft.net>
Cc: notting@redhat.com, netdev@vger.kernel.org,
bridge@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [Bridge] [RFC PATCH 0/2] Allow full bridge configuration via sysfs
Date: Mon, 7 Jul 2008 15:04:54 -0700 [thread overview]
Message-ID: <20080707150454.2a02a217@extreme> (raw)
In-Reply-To: <20080707.145259.103902820.davem@davemloft.net>
On Mon, 07 Jul 2008 14:52:59 -0700 (PDT)
David Miller <davem@davemloft.net> wrote:
> From: Bill Nottingham <notting@redhat.com>
> Date: Mon, 7 Jul 2008 17:34:20 -0400
>
> > I could look at wireless network configuration, but I doubt that's going to
> > help your argument.
>
> Just like any system with age, we have a lot of legacy to
> convert over. But it will happen.
>
> > That being said, how is moving from adding a bonding slave from:
> > echo "+eth0" > /sys/class/net/bond0/bonding/slaves to:
> > to:
> > http://www.linuxfoundation.org/en/Net:Generic_Netlink_HOWTO
> >
> > a worthwhile improvement for the admin? Let's see, a kernel-userspace
> > protocol with magic message formats. Hey, we reinvented ioctl!
> >
> > Why, if netlink is the standard (and it's been around for a long
> > damn time), was sysfs configuration for bonding added in 2005? Why
> > was bridge configuration added in 2005, and *extended* in 2006 and
> > 2007? Why were the user-space tools such as brctl ported from ioctl
> > to sysfs?
>
> Because often a lot of shit slips in when someone who understands
> the ramifications is too busy or on vacation.
>
> We do want everything to be netlink based.
>
> Why?
>
> Because it means that you can run one monitoring tool to listen
> for netlink events and report them to the user for diagnosis.
>
> It means that network configuration events can be sent over
> the wire and used remotely at some point.
>
> The latter can never happen as long as we keep adding ad-hoc
> config stuff.
There are always historical reasons. In this case it was because I knew
more about sysfs than netlink, and there was no netlink interface for managing
interfaces back in 2005. Sysfs is okay for simple stuff (set forward-delay to 10seconds),
but it falls down when anything interesting and transactional happens. Think of
sysfs as more an extension of per-device sysctl's or module parameters, rather
than a good configuration interface.
next prev parent reply other threads:[~2008-07-07 22:04 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-07 20:05 [Bridge] [RFC PATCH 0/2] Allow full bridge configuration via sysfs Bill Nottingham
2008-07-07 20:05 ` Bill Nottingham
2008-07-07 20:05 ` [Bridge] [PATCH 1/2] Add a 'bridging_masters' file in sysfs under class/net Bill Nottingham
2008-07-07 20:05 ` Bill Nottingham
2008-07-07 20:05 ` [Bridge] [PATCH 2/2] Add a 'interfaces' file to the bridge device configuration in sysfs Bill Nottingham
2008-07-07 20:05 ` Bill Nottingham
2008-07-07 20:50 ` [Bridge] [RFC PATCH 0/2] Allow full bridge configuration via sysfs Patrick McHardy
2008-07-07 20:50 ` Patrick McHardy
2008-07-07 20:53 ` [Bridge] " Bill Nottingham
2008-07-07 20:53 ` Bill Nottingham
2008-07-07 20:58 ` [Bridge] " Patrick McHardy
2008-07-07 20:58 ` Patrick McHardy
2008-07-07 21:34 ` [Bridge] " Bill Nottingham
2008-07-07 21:34 ` Bill Nottingham
2008-07-07 21:52 ` [Bridge] " David Miller
2008-07-07 21:52 ` David Miller
2008-07-07 22:04 ` Stephen Hemminger [this message]
2008-07-07 22:04 ` [Bridge] " Stephen Hemminger
2008-07-10 2:34 ` Bill Nottingham
2008-07-10 2:34 ` Bill Nottingham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080707150454.2a02a217@extreme \
--to=shemminger@vyatta.com \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=notting@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.