All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] pci: Move PCI device configuration check into a separate weak function
Date: Wed, 9 Jul 2008 08:16:33 +0200	[thread overview]
Message-ID: <200807090816.33491.sr@denx.de> (raw)
In-Reply-To: <29ab51dc0807082307m33644dccxfcd3cc4110571cb9@mail.gmail.com>

On Wednesday 09 July 2008, Nobuhiro Iwamatsu wrote:
> >> When PCI_BDF was 0,0,0, does the board of PPC have the device which
> >> do not want to initialize?
> >
> > This is the current situation, yes. At least on PPC4xx. With this new
> > patch all platforms can overwrite this default behavior without breaking
> > backward compatibility.
>
> OK, I see.
>
> > Does it work for you?
>
> Work fine. Thank you.

OK.

> But I have suggestion.
>
> If these cords depend on PPC4xx and other PPC platform, I think that move
> these code to PPC platform.
> Do you think this suggestion?

I don't know if this current implementation only works for PPC. Its used on 
all platforms using this PCI code right now. So I think we should keep this 
version in this file as default behavior.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

  reply	other threads:[~2008-07-09  6:16 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-08 10:01 [U-Boot-Users] [PATCH] pci: Move PCI device configuration check into a separate weak function Stefan Roese
2008-07-09  5:08 ` Nobuhiro Iwamatsu
2008-07-09  5:33   ` Stefan Roese
2008-07-09  6:07     ` Nobuhiro Iwamatsu
2008-07-09  6:16       ` Stefan Roese [this message]
2008-07-09  6:30         ` Nobuhiro Iwamatsu
2008-07-10  6:59           ` Stefan Roese
2008-07-10  7:39             ` Wolfgang Denk
2008-07-10  7:51               ` Stefan Roese
2008-07-10  8:10 ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200807090816.33491.sr@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.