From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Dmitry <dbaryshkov@gmail.com>
Cc: ian <spyro@f2s.com>,
linux-kernel@vger.kernel.org, Ben Dooks <ben-linux@fluff.org>,
linux-arm-kernel@lists.arm.linux.org.uk
Subject: Re: [patch 4/4] MFD: Change mfd platform device usage to wrapper platform_device
Date: Wed, 9 Jul 2008 22:03:14 +0100 [thread overview]
Message-ID: <20080709210314.GF26734@flint.arm.linux.org.uk> (raw)
In-Reply-To: <bc64b4640807090452vc923216gfb14bb2c5974a61@mail.gmail.com>
On Wed, Jul 09, 2008 at 03:52:08PM +0400, Dmitry wrote:
> 2008/7/9 ian <spyro@f2s.com>:
> > On Wed, 2008-07-09 at 15:15 +0400, Dmitry wrote:
> >> NAK.
> >> 0) It was discussed yesterday on the list and the decision was to go
> >> in a different way.
> >
> > It was?
> >
> > I prefer the wrapped way personally...
>
> In any case IMO it's better to call platform_device_register() rather than
> device_initialise()/platform_device_add().
>
> Samuel? Russell?
WTF??? That's just completely wrong - assuming the internals of how the
platform device alloc API works...
What it's clear from my *brief* read of this thread is that the MFD
support doesn't seem to be ready for mainline yet - there's clearly issues
here that need further work.
Given that, and where we are (there's maybe two of *my* days left until
the merge window opens) I'm *very* tempted to drop the MFD support out
of my tree for this merge window - which basically means removing
5127/1, 5128/1 and 5129/1.
next prev parent reply other threads:[~2008-07-09 21:03 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-09 10:49 [patch 0/4] mfd updates and proposed changes Ben Dooks
2008-07-09 10:49 ` [patch 1/4] MFD: Use to_platform_device instead of container_of Ben Dooks
2008-07-09 11:10 ` Dmitry
2008-07-10 14:47 ` Samuel Ortiz
2008-07-29 0:06 ` Samuel Ortiz
2008-07-09 10:49 ` [patch 2/4] MFD: Coding style fixes Ben Dooks
2008-07-09 11:11 ` Dmitry
2008-07-09 11:12 ` Ben Dooks
2008-07-10 14:48 ` Samuel Ortiz
2008-07-09 11:46 ` ian
2008-07-29 0:07 ` Samuel Ortiz
2008-07-09 10:49 ` [patch 3/4] MFD: Remove unnecessary fields if mfd_cell structure Ben Dooks
2008-07-09 11:09 ` Dmitry
2008-07-09 11:12 ` Ben Dooks
2008-07-09 11:16 ` Dmitry
2008-07-09 11:38 ` Ben Dooks
2008-07-09 11:44 ` Dmitry
2008-07-09 10:49 ` [patch 4/4] MFD: Change mfd platform device usage to wrapper platform_device Ben Dooks
2008-07-09 11:15 ` Dmitry
2008-07-09 11:24 ` Ben Dooks
2008-07-09 11:31 ` Dmitry
2008-07-09 11:50 ` Ben Dooks
2008-07-09 11:56 ` Dmitry
2008-07-09 12:07 ` Ben Dooks
2008-07-09 12:31 ` Dmitry
2008-07-09 13:28 ` ian
2008-07-09 13:34 ` pHilipp Zabel
2008-07-09 13:37 ` ian
2008-07-11 21:37 ` Samuel Ortiz
2008-07-09 12:13 ` ian
2008-07-09 12:29 ` pHilipp Zabel
2008-07-09 11:45 ` ian
2008-07-09 11:52 ` Dmitry
2008-07-09 21:03 ` Russell King - ARM Linux [this message]
2008-07-09 21:13 ` Dmitry Baryshkov
2008-07-09 21:13 ` ian
2008-07-11 21:41 ` Samuel Ortiz
2008-07-09 20:56 ` Russell King - ARM Linux
2008-07-09 21:04 ` Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080709210314.GF26734@flint.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=ben-linux@fluff.org \
--cc=dbaryshkov@gmail.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=spyro@f2s.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.