From: Ben Dooks <ben-linux@fluff.org>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Ben Dooks <ben-linux@fluff.org>,
dbaryshkov@gmail.com, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.arm.linux.org.uk
Subject: Re: [patch 4/4] MFD: Change mfd platform device usage to wrapper platform_device
Date: Wed, 9 Jul 2008 22:04:44 +0100 [thread overview]
Message-ID: <20080709210444.GN8517@trinity.fluff.org> (raw)
In-Reply-To: <20080709205625.GE26734@flint.arm.linux.org.uk>
On Wed, Jul 09, 2008 at 09:56:25PM +0100, Russell King - ARM Linux wrote:
> On Wed, Jul 09, 2008 at 11:49:20AM +0100, Ben Dooks wrote:
> > This patch changes the mfd core behaviour to wrapper the platform_device
> > it creates in an struct mfd_device which contains the information
> > about the cell that was created.
>
> You can't do this. Grab a reference to the platform device (by holding
> one of its sysfs files open) and then remove all the users of the mfd-core
> module and the mfd-core module itself.
>
> Then, read from that file and close it. Watch your kernel oops.
>
> That's why device release methods inside modules are a BAD IDEA and why
> we have the platform device alloc API.
Would this be fixed by grabbing a reference to the mfd-core module whilst
the mfd device is open?
--
Ben
Q: What's a light-year?
A: One-third less calories than a regular year.
prev parent reply other threads:[~2008-07-09 21:05 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-09 10:49 [patch 0/4] mfd updates and proposed changes Ben Dooks
2008-07-09 10:49 ` [patch 1/4] MFD: Use to_platform_device instead of container_of Ben Dooks
2008-07-09 11:10 ` Dmitry
2008-07-10 14:47 ` Samuel Ortiz
2008-07-29 0:06 ` Samuel Ortiz
2008-07-09 10:49 ` [patch 2/4] MFD: Coding style fixes Ben Dooks
2008-07-09 11:11 ` Dmitry
2008-07-09 11:12 ` Ben Dooks
2008-07-10 14:48 ` Samuel Ortiz
2008-07-09 11:46 ` ian
2008-07-29 0:07 ` Samuel Ortiz
2008-07-09 10:49 ` [patch 3/4] MFD: Remove unnecessary fields if mfd_cell structure Ben Dooks
2008-07-09 11:09 ` Dmitry
2008-07-09 11:12 ` Ben Dooks
2008-07-09 11:16 ` Dmitry
2008-07-09 11:38 ` Ben Dooks
2008-07-09 11:44 ` Dmitry
2008-07-09 10:49 ` [patch 4/4] MFD: Change mfd platform device usage to wrapper platform_device Ben Dooks
2008-07-09 11:15 ` Dmitry
2008-07-09 11:24 ` Ben Dooks
2008-07-09 11:31 ` Dmitry
2008-07-09 11:50 ` Ben Dooks
2008-07-09 11:56 ` Dmitry
2008-07-09 12:07 ` Ben Dooks
2008-07-09 12:31 ` Dmitry
2008-07-09 13:28 ` ian
2008-07-09 13:34 ` pHilipp Zabel
2008-07-09 13:37 ` ian
2008-07-11 21:37 ` Samuel Ortiz
2008-07-09 12:13 ` ian
2008-07-09 12:29 ` pHilipp Zabel
2008-07-09 11:45 ` ian
2008-07-09 11:52 ` Dmitry
2008-07-09 21:03 ` Russell King - ARM Linux
2008-07-09 21:13 ` Dmitry Baryshkov
2008-07-09 21:13 ` ian
2008-07-11 21:41 ` Samuel Ortiz
2008-07-09 20:56 ` Russell King - ARM Linux
2008-07-09 21:04 ` Ben Dooks [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080709210444.GN8517@trinity.fluff.org \
--to=ben-linux@fluff.org \
--cc=dbaryshkov@gmail.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.