All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] I2C Monitor Chip ADT7460 support
Date: Fri, 11 Jul 2008 11:36:24 +0200	[thread overview]
Message-ID: <200807111136.24462.sr@denx.de> (raw)
In-Reply-To: <4618.7248-495-1777888767-1215766461@seznam.cz>

On Friday 11 July 2008, Michal Simek wrote:
> Still is there coding style issue.
>
> and you have one extra header file which is uneeded. I recommend you
> move usefull values directly to driver.
>
> WD: I looked at include/dtt.h there are many driver specific values. IMHO
> these value should be usefull move to driver c file. What do you think
> about?

Full ACK. Patches welcome. :)

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

  reply	other threads:[~2008-07-11  9:36 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-11  8:23 [U-Boot-Users] ADT7460 I2C Monitor Chip Support Ricardo Ribalda Delgado
2008-07-11  8:23 ` [U-Boot-Users] [PATCH] I2C Monitor Chip ADT7460 support Ricardo Ribalda Delgado
2008-07-11  8:46   ` Stefan Roese
2008-07-11  8:54   ` Michal Simek
2008-07-11  9:36     ` Stefan Roese [this message]
2008-07-13 13:21     ` Wolfgang Denk
2008-07-14 10:32       ` [U-Boot-Users] [PATCH] " Ricardo Ribalda Delgado
  -- strict thread matches above, loose matches on Subject: below --
2008-07-11  9:49 [U-Boot-Users] [PATCH] I2C Monitor Chip ADT7460 support (fixed) Ricardo Ribalda Delgado
2008-07-11  9:49 ` [U-Boot-Users] [PATCH] I2C Monitor Chip ADT7460 support Ricardo Ribalda Delgado
2008-07-11  9:53   ` Michal Simek
2008-07-11 10:15 Ricardo Ribalda Delgado
2008-07-11 10:15 ` Ricardo Ribalda Delgado
2008-07-11 10:58   ` Stefan Roese
2008-07-11 11:12     ` Ricardo Ribalda Delgado
2008-07-14 17:30 [U-Boot-Users] [PATCH] I2C Monitor Chip ADT7460 support (new version) Ricardo Ribalda Delgado
2008-07-16  1:05 ` [U-Boot-Users] [PATCH] I2C Monitor chip ADT7460 support Ricardo Ribalda Delgado

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200807111136.24462.sr@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.