All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Dan Magenheimer" <dan.magenheimer@oracle.com>
To: "dan.magenheimer@oracle.com" <dan.magenheimer@oracle.com>,
	"Xen-Devel (E-mail)" <xen-devel@lists.xensource.com>,
	Keir Fraser <Keir.Fraser@eu.citrix.com>
Cc: Dave Winchell <dwinchell@virtualiron.com>
Subject: RE: [PATCH] clocksource=tsc
Date: Sat, 12 Jul 2008 21:59:45 -0600	[thread overview]
Message-ID: <20080712215945875.00000080236@djm-pc> (raw)
In-Reply-To: <20080712153824937.00000080236@djm-pc>

[-- Attachment #1: Type: text/plain, Size: 2010 bytes --]

I meant to add... although this appears to be new functionality
and thus too late for 3.3, I'd like to argue that it is really
a bug fix:  Let's say there are good-tsc machines and bad-tsc
machines.  Prior to cset 17716 ("hvm: Build guest timers on
monotonic system time") all guest platform timer reads were
built directly on top of physical TSC.  This was a big problem
for bad-tsc SMP machines, but fine for good-tsc machines.  Cset 17716
made things better for bad-tsc machines, but actually made them
worse for good-tsc SMP machines (because of the inter-processor
skew).

So users with good-tsc machines moving from a pre-3.3 release
to 3.3 may see time "stopped" in 3.3 when there was no problem
with pre-3.3.    The clocksource=tsc patch partially
fixes this "regression" for good-tsc machines... at least it
provides a boot option to fix it.

Thanks,
Dan

> -----Original Message-----
> From: Dan Magenheimer [mailto:dan.magenheimer@oracle.com]
> Sent: Saturday, July 12, 2008 3:38 PM
> To: Xen-Devel (E-mail); Keir Fraser; dan.magenheimer@oracle.com
> Cc: Dave Winchell
> Subject: [PATCH] clocksource=tsc
> 
> 
> Attached patch adds clocksource=tsc boot option that
> uses TSC as clocksource.  This option should only be
> used on machines where TSC is known to be synchronized
> across all processors.  A future TODO is to dynamically
> determine if this is the case.
> 
> TSC may "beat" with another clocksource, resulting in
> cross-processor Xen system time skew.  This skew can
> be visible in PV guests and can appear as "time is stopped"
> in hvm guests.  On some systems, this patch can reduce skew
> by 30x or more.
> 
> Signed-off-by: Dan Magenheimer <dan.magenheimer@oracle.com>
> 
> ===================================
> Thanks... for the memory
> I really could use more / My throughput's on the floor
> The balloon is flat / My swap disk's fat / I've OOM's in store
> Overcommitted so much
> (with apologies to the late great Bob Hope)
> 

[-- Attachment #2: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

  reply	other threads:[~2008-07-13  3:59 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-12 21:38 [PATCH] clocksource=tsc Dan Magenheimer
2008-07-13  3:59 ` Dan Magenheimer [this message]
2008-07-14  9:24 ` Keir Fraser
2008-07-14 17:59   ` Dan Magenheimer
2008-07-15  0:35     ` Tian, Kevin
2008-07-17 23:47       ` Dan Magenheimer
2008-07-15 13:05     ` Keir Fraser
2008-07-15 14:44       ` Dan Magenheimer
2008-07-15 15:08         ` Keir Fraser
2008-07-15 15:46           ` Dan Magenheimer
2008-07-15 16:04             ` Dan Magenheimer
2008-07-16  1:15               ` Dan Magenheimer
2008-07-16  4:11                 ` Dan Magenheimer
2008-07-16 12:43                   ` Dan Magenheimer
2008-07-16 12:49                     ` Keir Fraser
2008-07-16 13:43                       ` Dan Magenheimer
2008-07-16 15:42                         ` Dan Magenheimer
2008-07-16 19:32                           ` Keir Fraser
2008-07-17 23:05                       ` Dan Magenheimer
2008-07-18  7:24                         ` Keir Fraser
2008-07-18 11:01                           ` Keir Fraser
2008-07-18 11:10                             ` Keir Fraser
2008-07-18 14:19                               ` Dan Magenheimer
2008-07-18 14:29                                 ` Keir Fraser
2008-07-18 14:56                                   ` Dan Magenheimer
2008-07-18 15:00                                     ` Keir Fraser
2008-07-18 16:51                                       ` Dan Magenheimer
2008-07-18 19:28                                         ` Keir Fraser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080712215945875.00000080236@djm-pc \
    --to=dan.magenheimer@oracle.com \
    --cc=Keir.Fraser@eu.citrix.com \
    --cc=dwinchell@virtualiron.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.