All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Dan Magenheimer" <dan.magenheimer@oracle.com>
To: Keir Fraser <keir.fraser@eu.citrix.com>,
	"Xen-Devel (E-mail)" <xen-devel@lists.xensource.com>
Cc: Dave Winchell <dwinchell@virtualiron.com>
Subject: RE: [PATCH] clocksource=tsc
Date: Tue, 15 Jul 2008 08:44:31 -0600	[thread overview]
Message-ID: <20080715084431031.00000080236@djm-pc> (raw)
In-Reply-To: <C4A25F1A.23FE1%keir.fraser@eu.citrix.com>

> Changeset 18055 is what I had in mind. I split out the
> read_counter-is-64-bit portion separately. The changeset 
> needs a bit of
> testing and it may need a tweak or two.

Hmmm... One thing I was trying to do with the special
casing in get_s_time() was to avoid using a dynamically
changing scaling (t->tsc_scale).  If I'm not mistaken,
t->tsc_scale is recalculated every EPOCH and thus is
a potential source of stime jitter.  Seems unnecessary
just to make the code look cleaner.

One other nit:  Especially if the above is changed, do
you really prefer a strcmp vs a global variable (or
checking for size == 64) for determining if the tsc
is the platform timer?

Thanks,
Dan

  reply	other threads:[~2008-07-15 14:44 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-12 21:38 [PATCH] clocksource=tsc Dan Magenheimer
2008-07-13  3:59 ` Dan Magenheimer
2008-07-14  9:24 ` Keir Fraser
2008-07-14 17:59   ` Dan Magenheimer
2008-07-15  0:35     ` Tian, Kevin
2008-07-17 23:47       ` Dan Magenheimer
2008-07-15 13:05     ` Keir Fraser
2008-07-15 14:44       ` Dan Magenheimer [this message]
2008-07-15 15:08         ` Keir Fraser
2008-07-15 15:46           ` Dan Magenheimer
2008-07-15 16:04             ` Dan Magenheimer
2008-07-16  1:15               ` Dan Magenheimer
2008-07-16  4:11                 ` Dan Magenheimer
2008-07-16 12:43                   ` Dan Magenheimer
2008-07-16 12:49                     ` Keir Fraser
2008-07-16 13:43                       ` Dan Magenheimer
2008-07-16 15:42                         ` Dan Magenheimer
2008-07-16 19:32                           ` Keir Fraser
2008-07-17 23:05                       ` Dan Magenheimer
2008-07-18  7:24                         ` Keir Fraser
2008-07-18 11:01                           ` Keir Fraser
2008-07-18 11:10                             ` Keir Fraser
2008-07-18 14:19                               ` Dan Magenheimer
2008-07-18 14:29                                 ` Keir Fraser
2008-07-18 14:56                                   ` Dan Magenheimer
2008-07-18 15:00                                     ` Keir Fraser
2008-07-18 16:51                                       ` Dan Magenheimer
2008-07-18 19:28                                         ` Keir Fraser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080715084431031.00000080236@djm-pc \
    --to=dan.magenheimer@oracle.com \
    --cc=dwinchell@virtualiron.com \
    --cc=keir.fraser@eu.citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.