From: Arnd Bergmann <arnd@arndb.de>
To: linuxppc-dev@ozlabs.org
Cc: Dave Jones <davej@codemonkey.org.uk>,
Stephen Rothwell <sfr@canb.auug.org.au>,
cpufreq@lists.linux.org.uk, Jeremy Kerr <jk@ozlabs.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
cbe-oss-dev@ozlabs.org
Subject: Re: powerpc/cell/cpufreq: add spu aware cpufreq governor
Date: Tue, 15 Jul 2008 15:02:00 +0200 [thread overview]
Message-ID: <200807151502.01540.arnd@arndb.de> (raw)
In-Reply-To: <20080709062958.GA24570@codemonkey.org.uk>
On Wednesday 09 July 2008, Dave Jones wrote:
>
> diff --git a/arch/powerpc/platforms/cell/Kconfig b/arch/powerpc/platforms/cell/Kconfig
> index 3959fcf..19f4b4d 100644
> --- a/arch/powerpc/platforms/cell/Kconfig
> +++ b/arch/powerpc/platforms/cell/Kconfig
> @@ -91,6 +91,7 @@ config CBE_THERM
> config CBE_CPUFREQ
> tristate "CBE frequency scaling"
> depends on CBE_RAS && CPU_FREQ
> + select CPU_FREQ_TABLE
> default m
> help
> This adds the cpufreq driver for Cell BE processors.
I found the problem now, there was an incorrect 'select CBE_CPUFREQ'
in the spudemand governor, but no 'depends on CPUFREQ', so it was
possible to build CBE_CPUFREQ without the base CPUFREQ support.
Fixed in the current version, will post later.
Arnd <><
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: linuxppc-dev@ozlabs.org
Cc: Dave Jones <davej@codemonkey.org.uk>,
Stephen Rothwell <sfr@canb.auug.org.au>,
cpufreq@lists.linux.org.uk, Jeremy Kerr <jk@ozlabs.org>,
cbe-oss-dev@ozlabs.org
Subject: Re: powerpc/cell/cpufreq: add spu aware cpufreq governor
Date: Tue, 15 Jul 2008 15:02:00 +0200 [thread overview]
Message-ID: <200807151502.01540.arnd@arndb.de> (raw)
In-Reply-To: <20080709062958.GA24570@codemonkey.org.uk>
On Wednesday 09 July 2008, Dave Jones wrote:
>=20
> diff --git a/arch/powerpc/platforms/cell/Kconfig b/arch/powerpc/platforms=
/cell/Kconfig
> index 3959fcf..19f4b4d 100644
> --- a/arch/powerpc/platforms/cell/Kconfig
> +++ b/arch/powerpc/platforms/cell/Kconfig
> @@ -91,6 +91,7 @@ config CBE_THERM
> =A0config CBE_CPUFREQ
> =A0=A0=A0=A0=A0=A0=A0=A0tristate "CBE frequency scaling"
> =A0=A0=A0=A0=A0=A0=A0=A0depends on CBE_RAS && CPU_FREQ
> +=A0=A0=A0=A0=A0=A0=A0select CPU_FREQ_TABLE
> =A0=A0=A0=A0=A0=A0=A0=A0default m
> =A0=A0=A0=A0=A0=A0=A0=A0help
> =A0=A0=A0=A0=A0=A0=A0=A0 =A0This adds the cpufreq driver for Cell BE proc=
essors.
I found the problem now, there was an incorrect 'select CBE_CPUFREQ'
in the spudemand governor, but no 'depends on CPUFREQ', so it was
possible to build CBE_CPUFREQ without the base CPUFREQ support.
=46ixed in the current version, will post later.
Arnd <><
next prev parent reply other threads:[~2008-07-15 13:02 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-07 15:02 powerpc/cell/cpufreq: add spu aware cpufreq governor Arnd Bergmann
2008-07-07 15:02 ` Arnd Bergmann
2008-07-07 17:17 ` [Cbe-oss-dev] " Eric Blossom
2008-07-07 21:02 ` Arnd Bergmann
2008-07-07 21:02 ` Arnd Bergmann
2008-07-07 21:31 ` Dave Jones
2008-07-07 21:31 ` Dave Jones
2008-07-08 6:43 ` Arnd Bergmann
2008-07-08 6:43 ` Arnd Bergmann
2008-07-08 15:27 ` Dave Jones
2008-07-08 15:27 ` Dave Jones
2008-07-09 3:41 ` Benjamin Herrenschmidt
2008-07-09 3:57 ` Dave Jones
2008-07-10 18:05 ` Dominik Brodowski
2008-07-10 18:05 ` Dominik Brodowski
2008-07-10 21:05 ` Arnd Bergmann
2008-07-10 21:16 ` Dominik Brodowski
2008-07-09 5:18 ` Benjamin Herrenschmidt
2008-07-09 6:29 ` Dave Jones
2008-07-15 13:02 ` Arnd Bergmann [this message]
2008-07-15 13:02 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200807151502.01540.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=benh@kernel.crashing.org \
--cc=cbe-oss-dev@ozlabs.org \
--cc=cpufreq@lists.linux.org.uk \
--cc=davej@codemonkey.org.uk \
--cc=jk@ozlabs.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.