Re: [PATCH][TOOLS] xenperf: cleanup

[Christoph Egger <Christoph.Egger@amd.com>]

On Tuesday 15 July 2008 15:52:13 Keir Fraser wrote:
> On 15/7/08 14:45, "Christoph Egger" <Christoph.Egger@amd.com> wrote:
> > One more (already sent). Then the tools build with the additional
> > compiler flags:
> >
> > -Wstrict-prototypes -Wswitch -Wmissing-prototypes -Wreturn-type
> > -Wnested-externs
> > -Wredundant-decls -Wfloat-equal -Wundef -Wimplicit-function-declaration
>
> Do we really want these? Certainly I'm not going to play whack-a-warning
> with umpteen versions of gcc before 3.3 is out.

Probably not all of them. -Wfloat-equal has no effect because there's no FPU 
code in Xen.

The flags  -Wmissing-prototypes -Wnested-externs -Wredundant-decls
and -Wimplicit-function-declaration    resulted in the patches I sent 
yesterday and today.
These flags guarantee that future patches have a higher quality.

For the xen-kernel itself I'm not yet through with these flags.
Nonetheless, I can send a patch you will like. :)

Christoph

-- 
AMD Saxony, Dresden, Germany
Operating System Research Center

Legal Information:
AMD Saxony Limited Liability Company & Co. KG
Sitz (Geschäftsanschrift):
   Wilschdorfer Landstr. 101, 01109 Dresden, Deutschland
Registergericht Dresden: HRA 4896
vertretungsberechtigter Komplementär:
   AMD Saxony LLC (Sitz Wilmington, Delaware, USA)
Geschäftsführer der AMD Saxony LLC:
   Dr. Hans-R. Deppe, Thomas McCoy