All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: linuxppc-dev@ozlabs.org
Cc: Dave Jones <davej@redhat.com>, akpm <akpm@linux-foundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [git pull] Please pull from powerpc.git merge branch
Date: Wed, 16 Jul 2008 10:51:11 +0200	[thread overview]
Message-ID: <200807161051.12545.arnd@arndb.de> (raw)
In-Reply-To: <20080716042042.GA13212@redhat.com>

On Wednesday 16 July 2008, Dave Jones wrote:
> arch/powerpc/platforms/built-in.o: In function `ep8248e_mdio_probe':
> /builddir/build/BUILD/kernel-2.6.26/linux-2.6.26.ppc/arch/powerpc/platforms/82xx/ep8248e.c:129: undefined reference to `alloc_mdio_bitbang'
> /builddir/build/BUILD/kernel-2.6.26/linux-2.6.26.ppc/arch/powerpc/platforms/82xx/ep8248e.c:143: undefined reference to `mdiobus_register'

FS_ENET and EP8248E both select MDIO_BITBANG, but not PHYLIB or MII, which
looks broken to me.

Also, I think it would be useful to split out the bitbang
driver from ep8248e.c, so that you can build it as a loadable
module if you want to have PHYLIB loadable.

	Arnd <><

WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: linuxppc-dev@ozlabs.org
Cc: Dave Jones <davej@redhat.com>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	akpm <akpm@linux-foundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [git pull] Please pull from powerpc.git merge branch
Date: Wed, 16 Jul 2008 10:51:11 +0200	[thread overview]
Message-ID: <200807161051.12545.arnd@arndb.de> (raw)
In-Reply-To: <20080716042042.GA13212@redhat.com>

On Wednesday 16 July 2008, Dave Jones wrote:
> arch/powerpc/platforms/built-in.o: In function `ep8248e_mdio_probe':
> /builddir/build/BUILD/kernel-2.6.26/linux-2.6.26.ppc/arch/powerpc/platforms/82xx/ep8248e.c:129: undefined reference to `alloc_mdio_bitbang'
> /builddir/build/BUILD/kernel-2.6.26/linux-2.6.26.ppc/arch/powerpc/platforms/82xx/ep8248e.c:143: undefined reference to `mdiobus_register'

FS_ENET and EP8248E both select MDIO_BITBANG, but not PHYLIB or MII, which
looks broken to me.

Also, I think it would be useful to split out the bitbang
driver from ep8248e.c, so that you can build it as a loadable
module if you want to have PHYLIB loadable.

	Arnd <><

  parent reply	other threads:[~2008-07-16  8:51 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-16  1:34 [git pull] Please pull from powerpc.git merge branch Benjamin Herrenschmidt
2008-07-16  1:48 ` Benjamin Herrenschmidt
2008-07-16  4:20 ` Dave Jones
2008-07-16  4:20   ` Dave Jones
2008-07-16  5:01   ` Benjamin Herrenschmidt
2008-07-16  5:01     ` Benjamin Herrenschmidt
2008-07-16 12:46     ` Kumar Gala
2008-07-16 12:46       ` Kumar Gala
2008-07-16  8:51   ` Arnd Bergmann [this message]
2008-07-16  8:51     ` Arnd Bergmann
2008-07-16 11:13     ` Benjamin Herrenschmidt
2008-07-16 11:13       ` Benjamin Herrenschmidt
2008-07-16 12:48       ` Kumar Gala
  -- strict thread matches above, loose matches on Subject: below --
2008-07-22  7:32 Benjamin Herrenschmidt
2008-07-22 13:11 ` Kumar Gala
2008-07-22 13:11   ` Kumar Gala
2008-07-25  8:13 Benjamin Herrenschmidt
2008-07-25 15:07 ` Kumar Gala
2008-07-25 15:07   ` Kumar Gala
2008-07-25 21:43   ` Benjamin Herrenschmidt
2008-07-25 21:43     ` Benjamin Herrenschmidt
2008-07-25 18:10 ` Linus Torvalds
2008-07-25 18:55   ` Grant Likely
2008-07-25 18:55     ` Grant Likely
2008-07-25 23:11 Benjamin Herrenschmidt
2008-07-26  0:38 ` Linus Torvalds
2008-07-26  4:28   ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200807161051.12545.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=akpm@linux-foundation.org \
    --cc=davej@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.