From: Paul Mundt <lethal@linux-sh.org>
To: Adrian Bunk <bunk@kernel.org>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>,
linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] fix sh ptep_get_and_clear breakage
Date: Thu, 17 Jul 2008 05:54:34 +0000 [thread overview]
Message-ID: <20080717055434.GC12007@linux-sh.org> (raw)
In-Reply-To: <20080716164540.GF17329@cs181140183.pp.htv.fi>
On Wed, Jul 16, 2008 at 07:45:40PM +0300, Adrian Bunk wrote:
> Commit 1ea0704e0da65b2b46f9142ff1391163aac24060
> (mm: add a ptep_modify_prot transaction abstraction)
> triggered on sh build errors like the following:
>
> <-- snip -->
>
> ...
> CC arch/sh/mm/pg-sh4.o
> cc1: warnings being treated as errors
> include2/asm/pgtable.h:139: error: 'ptep_get_and_clear' declared inline after being called
> include2/asm/pgtable.h:139: error: previous declaration of 'ptep_get_and_clear' was here
> make[2]: *** [arch/sh/mm/pg-sh4.o] Error 1
>
> <-- snip -->
>
> Since there's no good reason for marking these global functions as
> "inline" this patch therefore removes the inline's.
>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
>
Magnus already fixed this for pg-sh4, but the SH7705 implementation was
overlooked, so I applied your patch there. Thanks.
WARNING: multiple messages have this Message-ID (diff)
From: Paul Mundt <lethal@linux-sh.org>
To: Adrian Bunk <bunk@kernel.org>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>,
linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] fix sh ptep_get_and_clear breakage
Date: Thu, 17 Jul 2008 14:54:34 +0900 [thread overview]
Message-ID: <20080717055434.GC12007@linux-sh.org> (raw)
In-Reply-To: <20080716164540.GF17329@cs181140183.pp.htv.fi>
On Wed, Jul 16, 2008 at 07:45:40PM +0300, Adrian Bunk wrote:
> Commit 1ea0704e0da65b2b46f9142ff1391163aac24060
> (mm: add a ptep_modify_prot transaction abstraction)
> triggered on sh build errors like the following:
>
> <-- snip -->
>
> ...
> CC arch/sh/mm/pg-sh4.o
> cc1: warnings being treated as errors
> include2/asm/pgtable.h:139: error: 'ptep_get_and_clear' declared inline after being called
> include2/asm/pgtable.h:139: error: previous declaration of 'ptep_get_and_clear' was here
> make[2]: *** [arch/sh/mm/pg-sh4.o] Error 1
>
> <-- snip -->
>
> Since there's no good reason for marking these global functions as
> "inline" this patch therefore removes the inline's.
>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
>
Magnus already fixed this for pg-sh4, but the SH7705 implementation was
overlooked, so I applied your patch there. Thanks.
next prev parent reply other threads:[~2008-07-17 5:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-16 16:45 [2.6 patch] fix sh ptep_get_and_clear breakage Adrian Bunk
2008-07-16 16:45 ` Adrian Bunk
2008-07-17 5:54 ` Paul Mundt [this message]
2008-07-17 5:54 ` Paul Mundt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080717055434.GC12007@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=bunk@kernel.org \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.