All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vivek Goyal <vgoyal@redhat.com>
To: Bernhard Walle <bwalle@suse.de>
Cc: Ken'ichi Ohmichi <oomichi@mxs.nes.nec.co.jp>,
	kexec@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: kdump: Report actual value of VMCOREINFO_OSRELEASE in VMCOREINFO
Date: Fri, 18 Jul 2008 10:04:31 -0400	[thread overview]
Message-ID: <20080718140431.GE11492@redhat.com> (raw)
In-Reply-To: <20080718000745.51d32607@kopernikus.site>

On Fri, Jul 18, 2008 at 12:07:45AM +0200, Bernhard Walle wrote:
> The current implementation reports the structure name as
> VMCOREINFO_OSRELEASE in VMCOREINFO, e.g.
> 
>         VMCOREINFO_OSRELEASE=init_uts_ns.name.release
> 
> That doesn't make sense because it's always the same. Instead, use the
> value, e.g.
> 
>         VMCOREINFO_OSRELEASE=2.6.26-rc3
> 
> That's also what the 'makedumpfile -g' does.
> 
> Signed-off-by: Bernhard Walle <bwalle@suse.de>
> 
> diff --git a/include/linux/kexec.h b/include/linux/kexec.h
> index 3265968..3c7784d 100644
> --- a/include/linux/kexec.h
> +++ b/include/linux/kexec.h
> @@ -127,8 +127,8 @@ void vmcoreinfo_append_str(const char *fmt, ...)
>  	__attribute__ ((format (printf, 1, 2)));
>  unsigned long paddr_vmcoreinfo_note(void);
>  
> -#define VMCOREINFO_OSRELEASE(name) \
> -	vmcoreinfo_append_str("OSRELEASE=%s\n", #name)
> +#define VMCOREINFO_OSRELEASE(value) \
> +	vmcoreinfo_append_str("OSRELEASE=%s\n", value)
>  #define VMCOREINFO_PAGESIZE(value) \
>  	vmcoreinfo_append_str("PAGESIZE=%ld\n", value)
>  #define VMCOREINFO_SYMBOL(name) \

Makes sense.

Acked-by: Vivek Goyal <vgoyal@redhat.com>

Thanks
Vivek

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

WARNING: multiple messages have this Message-ID (diff)
From: Vivek Goyal <vgoyal@redhat.com>
To: Bernhard Walle <bwalle@suse.de>
Cc: "Ken'ichi Ohmichi" <oomichi@mxs.nes.nec.co.jp>,
	linux-kernel@vger.kernel.org, kexec@lists.infradead.org
Subject: Re: kdump: Report actual value of VMCOREINFO_OSRELEASE in VMCOREINFO
Date: Fri, 18 Jul 2008 10:04:31 -0400	[thread overview]
Message-ID: <20080718140431.GE11492@redhat.com> (raw)
In-Reply-To: <20080718000745.51d32607@kopernikus.site>

On Fri, Jul 18, 2008 at 12:07:45AM +0200, Bernhard Walle wrote:
> The current implementation reports the structure name as
> VMCOREINFO_OSRELEASE in VMCOREINFO, e.g.
> 
>         VMCOREINFO_OSRELEASE=init_uts_ns.name.release
> 
> That doesn't make sense because it's always the same. Instead, use the
> value, e.g.
> 
>         VMCOREINFO_OSRELEASE=2.6.26-rc3
> 
> That's also what the 'makedumpfile -g' does.
> 
> Signed-off-by: Bernhard Walle <bwalle@suse.de>
> 
> diff --git a/include/linux/kexec.h b/include/linux/kexec.h
> index 3265968..3c7784d 100644
> --- a/include/linux/kexec.h
> +++ b/include/linux/kexec.h
> @@ -127,8 +127,8 @@ void vmcoreinfo_append_str(const char *fmt, ...)
>  	__attribute__ ((format (printf, 1, 2)));
>  unsigned long paddr_vmcoreinfo_note(void);
>  
> -#define VMCOREINFO_OSRELEASE(name) \
> -	vmcoreinfo_append_str("OSRELEASE=%s\n", #name)
> +#define VMCOREINFO_OSRELEASE(value) \
> +	vmcoreinfo_append_str("OSRELEASE=%s\n", value)
>  #define VMCOREINFO_PAGESIZE(value) \
>  	vmcoreinfo_append_str("PAGESIZE=%ld\n", value)
>  #define VMCOREINFO_SYMBOL(name) \

Makes sense.

Acked-by: Vivek Goyal <vgoyal@redhat.com>

Thanks
Vivek

  reply	other threads:[~2008-07-18 14:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-17 22:07 kdump: Report actual value of VMCOREINFO_OSRELEASE in VMCOREINFO Bernhard Walle
2008-07-17 22:07 ` Bernhard Walle
2008-07-18 14:04 ` Vivek Goyal [this message]
2008-07-18 14:04   ` Vivek Goyal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080718140431.GE11492@redhat.com \
    --to=vgoyal@redhat.com \
    --cc=bwalle@suse.de \
    --cc=kexec@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oomichi@mxs.nes.nec.co.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.