interval of TMU

interval of TMU

[Hideo Saito]

Hi Paul,

It seems that TCOR register is set by current value of TCNT register, when tmu_set_mode() is called after the clock starts in tmu_timer_init(). Is this right?

I think that CLOCK_EVT_MODE_PERIODIC is to initialize the timer, not to change interval.

--- ./arch/sh/kernel/timers/timer-tmu.c.org	2008-04-17 11:49:44.000000000 +0900
+++ ./arch/sh/kernel/timers/timer-tmu.c	2008-07-18 18:51:22.000000000 +0900
@@ -68,17 +68,17 @@ static int tmu_set_next_event(unsigned l
 	return 0;
 }
 
 static void tmu_set_mode(enum clock_event_mode mode,
 			 struct clock_event_device *evt)
 {
 	switch (mode) {
 	case CLOCK_EVT_MODE_PERIODIC:
-		ctrl_outl(ctrl_inl(TMU0_TCNT), TMU0_TCOR);
+		ctrl_outl(ctrl_inl(TMU0_TCOR), TMU0_TCNT);
 		break;
 	case CLOCK_EVT_MODE_ONESHOT:
 		ctrl_outl(0, TMU0_TCOR);
 		break;
 	case CLOCK_EVT_MODE_UNUSED:
 	case CLOCK_EVT_MODE_SHUTDOWN:
 	case CLOCK_EVT_MODE_RESUME:
 		break;

Re: interval of TMU

[Paul Mundt]

On Fri, Jul 18, 2008 at 07:40:22PM +0900, Hideo Saito wrote:
> It seems that TCOR register is set by current value of TCNT register,
> when tmu_set_mode() is called after the clock starts in
> tmu_timer_init(). Is this right?
> 
> I think that CLOCK_EVT_MODE_PERIODIC is to initialize the timer, not to
> change interval.
> 
Good question, I don't remember what I was thinking at the time. I'll
check this again on hardware when I'm back in Japan next week after the
PM summit.