All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] ath9k: some more yummy patches
Date: Wed, 23 Jul 2008 13:15:50 -0400	[thread overview]
Message-ID: <20080723171550.GA693@infradead.org> (raw)
In-Reply-To: <43e72e890807231001y13568b36j18d3ac0f97714994@mail.gmail.com>

On Wed, Jul 23, 2008 at 10:01:37AM -0700, Luis R. Rodriguez wrote:
> On Wed, Jul 23, 2008 at 10:00 AM, Christoph Hellwig <hch@infradead.org> wrote:
> > On Wed, Jul 23, 2008 at 09:57:31AM -0700, Luis R. Rodriguez wrote:
> >> I take it we made it too late for .27?
> >
> > Well, we decided to put driver in anytime in the process, so if the
> > driver is cleaned up enough in the next month or so it should be able
> > to make it.
> 
> Great! We are committed so let me know if you find other critical
> areas of cleanups you'd like to see.

Let's start with some easy ones that might not be critical by itself
but help making the driver look like a normal Linux driver:

 - replace enum hal_bool with the normal bool type
 - replace A_MAX usage with the normal max/max_t macros
 - just use ASSERT instead of assert
 - think about doing the same for KASSERT
 - kill memzero
 - kill get_dma_mem_context and copy_dma_mem_context
 - replace the various debug message print helpers with standard
   Linux infrastructure

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: "Luis R. Rodriguez" <mcgrof@gmail.com>
Cc: Christoph Hellwig <hch@infradead.org>,
	"ath9k-devel@lists.ath9k.org" <ath9k-devel@lists.ath9k.org>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: ath9k: some more yummy patches
Date: Wed, 23 Jul 2008 13:15:50 -0400	[thread overview]
Message-ID: <20080723171550.GA693@infradead.org> (raw)
In-Reply-To: <43e72e890807231001y13568b36j18d3ac0f97714994@mail.gmail.com>

On Wed, Jul 23, 2008 at 10:01:37AM -0700, Luis R. Rodriguez wrote:
> On Wed, Jul 23, 2008 at 10:00 AM, Christoph Hellwig <hch@infradead.org> wrote:
> > On Wed, Jul 23, 2008 at 09:57:31AM -0700, Luis R. Rodriguez wrote:
> >> I take it we made it too late for .27?
> >
> > Well, we decided to put driver in anytime in the process, so if the
> > driver is cleaned up enough in the next month or so it should be able
> > to make it.
> 
> Great! We are committed so let me know if you find other critical
> areas of cleanups you'd like to see.

Let's start with some easy ones that might not be critical by itself
but help making the driver look like a normal Linux driver:

 - replace enum hal_bool with the normal bool type
 - replace A_MAX usage with the normal max/max_t macros
 - just use ASSERT instead of assert
 - think about doing the same for KASSERT
 - kill memzero
 - kill get_dma_mem_context and copy_dma_mem_context
 - replace the various debug message print helpers with standard
   Linux infrastructure

  reply	other threads:[~2008-07-23 17:15 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-23 16:13 [ath9k-devel] ath9k: some more yummy patches Luis R. Rodriguez
2008-07-23 16:13 ` Luis R. Rodriguez
2008-07-23 16:29 ` [ath9k-devel] " Christoph Hellwig
2008-07-23 16:29   ` Christoph Hellwig
2008-07-23 16:43   ` [ath9k-devel] " Luis R. Rodriguez
2008-07-23 16:43     ` Luis R. Rodriguez
2008-07-23 16:46     ` [ath9k-devel] " Christoph Hellwig
2008-07-23 16:46       ` Christoph Hellwig
2008-07-23 16:57       ` [ath9k-devel] " Luis R. Rodriguez
2008-07-23 16:57         ` Luis R. Rodriguez
2008-07-23 17:00         ` [ath9k-devel] " Christoph Hellwig
2008-07-23 17:00           ` Christoph Hellwig
2008-07-23 17:01           ` [ath9k-devel] " Luis R. Rodriguez
2008-07-23 17:01             ` Luis R. Rodriguez
2008-07-23 17:15             ` Christoph Hellwig [this message]
2008-07-23 17:15               ` Christoph Hellwig
2008-07-23 17:19               ` [ath9k-devel] " Luis R. Rodriguez
2008-07-23 17:19                 ` Luis R. Rodriguez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080723171550.GA693@infradead.org \
    --to=hch@infradead.org \
    --cc=ath9k-devel@lists.ath9k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.