All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Max Krasnyansky <maxk@qualcomm.com>,
	netdev@vger.kernel.org,
	virtualization@lists.linux-foundation.org, markmc@redhat.com
Subject: Re: [PATCH 3/4] tun: Allow GSO using virtio_net_hdr
Date: Fri, 25 Jul 2008 09:54:18 +1000	[thread overview]
Message-ID: <200807250954.19120.rusty@rustcorp.com.au> (raw)
In-Reply-To: <20080724142044.GA8266@gondor.apana.org.au>

On Friday 25 July 2008 00:20:44 Herbert Xu wrote:
> On Thu, Jun 26, 2008 at 12:30:37AM +1000, Rusty Russell wrote:
> > Add a IFF_VNET_HDR flag.  This uses the same ABI as virtio_net (ie.
> > prepending struct virtio_net_hdr to packets) to indicate GSO and checksum
> > information.
> >
> > Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
>
> I just noticed that we still allocate a linear skb even when GSO
> is enabled.  Please fix this by allocating page frags where
> necessary.  Otherwise GSO is only going to work before memory
> fragmentation sets in.
>
> IIRC I'd sent out a patch to the virt mailing list with code
> that did this.
>
> Thanks,

Hi Herbert,

   Thanks for the reminder.  I have this code in the virtio_net patches which 
Linus failed to pull.  Will just need to share it with the tun code (maybe a 
skb_alloc_large() helper).

Cheers,
Rusty.

  reply	other threads:[~2008-07-24 23:55 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-25 14:28 [PATCH 1/4] tun: Interface to query tun/tap features Rusty Russell
2008-06-25 14:29 ` [PATCH 2/4] tun: TUNSETFEATURES to set gso features Rusty Russell
2008-06-25 14:30   ` [PATCH 3/4] tun: Allow GSO using virtio_net_hdr Rusty Russell
2008-06-25 14:32     ` [PATCH 4/4] lguest: Use GSO/IFF_VNET_HDR extensions on tun/tap Rusty Russell
2008-06-25 19:07       ` Anthony Liguori
2008-06-26  4:40         ` Rusty Russell
2008-06-26  4:40         ` Rusty Russell
2008-06-26 18:16           ` Anthony Liguori
2008-06-26 18:16           ` Anthony Liguori
2008-06-27  3:50             ` Rusty Russell
2008-06-27  3:50             ` Rusty Russell
2008-07-02  5:25           ` Max Krasnyansky
2008-07-02  5:25           ` Max Krasnyansky
2008-06-25 19:07       ` Anthony Liguori
2008-06-25 14:32     ` Rusty Russell
2008-06-25 14:32     ` Rusty Russell
2008-06-25 15:45       ` Rusty Russell
2008-06-25 15:45       ` Rusty Russell
2008-07-02  5:13     ` [PATCH 3/4] tun: Allow GSO using virtio_net_hdr Max Krasnyansky
2008-07-02  7:00       ` Rusty Russell
2008-07-02  7:00       ` Rusty Russell
2008-07-02  5:13     ` Max Krasnyansky
2008-07-24 14:20     ` Herbert Xu
2008-07-24 14:20     ` Herbert Xu
2008-07-24 23:54       ` Rusty Russell [this message]
2008-07-24 23:54       ` Rusty Russell
2008-06-25 14:30   ` Rusty Russell
2008-07-02  5:02   ` [PATCH 2/4] tun: TUNSETFEATURES to set gso features Max Krasnyansky
2008-07-02  5:02   ` Max Krasnyansky
2008-06-25 14:29 ` Rusty Russell
2008-07-02  4:59 ` [PATCH 1/4] tun: Interface to query tun/tap features Max Krasnyansky
2008-07-02  5:27   ` David Miller
2008-07-02  5:27   ` David Miller
2008-07-02  4:59 ` Max Krasnyansky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200807250954.19120.rusty@rustcorp.com.au \
    --to=rusty@rustcorp.com.au \
    --cc=herbert@gondor.apana.org.au \
    --cc=markmc@redhat.com \
    --cc=maxk@qualcomm.com \
    --cc=netdev@vger.kernel.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.