From: Steven Rostedt <rostedt@goodmis.org>
To: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, Linus Torvalds <torvalds@osdl.org>
Cc: Steven Rostedt <srostedt@redhat.com>
Subject: [PATCH 2/2] ftrace: disable tracing on acpi idle calls
Date: Fri, 25 Jul 2008 18:00:42 -0400 [thread overview]
Message-ID: <20080725220334.931959350@goodmis.org> (raw)
In-Reply-To: 20080725220040.911370182@goodmis.org
[-- Attachment #1: ftrace-stop-tracing-acpi-mwait.patch --]
[-- Type: text/plain, Size: 1712 bytes --]
The acpi idle waits calls local_irq_save and then uses mwait to go into
idle. The tracer gets reenabled at local_irq_save but does not detect that
the idle allows for wake ups.
This patch adds code to disable the tracing when acpi puts the CPU to idle.
Signed-off-by: Steven Rostedt <srostedt@redhat.com>
Index: linux-tip.git/drivers/acpi/processor_idle.c
===================================================================
--- linux-tip.git.orig/drivers/acpi/processor_idle.c
+++ linux-tip.git/drivers/acpi/processor_idle.c
@@ -272,6 +272,8 @@ static atomic_t c3_cpu_count;
/* Common C-state entry for C2, C3, .. */
static void acpi_cstate_enter(struct acpi_processor_cx *cstate)
{
+ /* Don't trace irqs off for idle */
+ stop_critical_timings();
if (cstate->entry_method == ACPI_CSTATE_FFH) {
/* Call into architectural FFH based C-state */
acpi_processor_ffh_cstate_enter(cstate);
@@ -284,6 +286,7 @@ static void acpi_cstate_enter(struct acp
gets asserted in time to freeze execution properly. */
unused = inl(acpi_gbl_FADT.xpm_timer_block.address);
}
+ start_critical_timings();
}
#endif /* !CONFIG_CPU_IDLE */
@@ -1418,6 +1421,8 @@ static inline void acpi_idle_update_bm_r
*/
static inline void acpi_idle_do_entry(struct acpi_processor_cx *cx)
{
+ /* Don't trace irqs off for idle */
+ stop_critical_timings();
if (cx->entry_method == ACPI_CSTATE_FFH) {
/* Call into architectural FFH based C-state */
acpi_processor_ffh_cstate_enter(cx);
@@ -1432,6 +1437,7 @@ static inline void acpi_idle_do_entry(st
gets asserted in time to freeze execution properly. */
unused = inl(acpi_gbl_FADT.xpm_timer_block.address);
}
+ start_critical_timings();
}
/**
--
next prev parent reply other threads:[~2008-07-25 22:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-25 22:00 [PATCH 0/2] ftrace minor updates Steven Rostedt
2008-07-25 22:00 ` [PATCH 1/2] ftrace: single CPU tracers use CPU clock Steven Rostedt
2008-07-26 12:40 ` Ingo Molnar
2008-07-26 13:15 ` Steven Rostedt
2008-07-26 13:21 ` Ingo Molnar
2008-07-26 15:03 ` Steven Rostedt
2008-07-26 15:26 ` Ingo Molnar
2008-07-26 18:23 ` Steven Rostedt
2008-07-25 22:00 ` Steven Rostedt [this message]
2008-07-26 12:42 ` [PATCH 2/2] ftrace: disable tracing on acpi idle calls Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080725220334.931959350@goodmis.org \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=srostedt@redhat.com \
--cc=tglx@linutronix.de \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.