From: Ingo Molnar <mingo@elte.hu>
To: Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org
Subject: [patch] crashdump: fix undefined reference to `elfcorehdr_addr'
Date: Sat, 26 Jul 2008 11:25:19 +0200 [thread overview]
Message-ID: <20080726092519.GA4341@elte.hu> (raw)
please apply before -rc1.
Ingo
----------->
>From 72db7cba50b6a05825f8a287f74002cc38f04fb7 Mon Sep 17 00:00:00 2001
From: Ingo Molnar <mingo@elte.hu>
Date: Sat, 26 Jul 2008 11:22:33 +0200
Subject: [PATCH] crashdump: fix undefined reference to `elfcorehdr_addr'
fix build bug introduced by 95b68dec0d5 "calgary iommu: use the first
kernels TCE tables in kdump":
arch/x86/kernel/built-in.o: In function `calgary_iommu_init':
(.init.text+0x8399): undefined reference to `elfcorehdr_addr'
arch/x86/kernel/built-in.o: In function `calgary_iommu_init':
(.init.text+0x856c): undefined reference to `elfcorehdr_addr'
arch/x86/kernel/built-in.o: In function `detect_calgary':
(.init.text+0x8c68): undefined reference to `elfcorehdr_addr'
arch/x86/kernel/built-in.o: In function `detect_calgary':
(.init.text+0x8d0c): undefined reference to `elfcorehdr_addr'
make elfcorehdr_addr a generally available symbol.
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
include/linux/crash_dump.h | 6 ++++++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/include/linux/crash_dump.h b/include/linux/crash_dump.h
index 6cd39a9..025e4f5 100644
--- a/include/linux/crash_dump.h
+++ b/include/linux/crash_dump.h
@@ -8,7 +8,13 @@
#include <linux/proc_fs.h>
#define ELFCORE_ADDR_MAX (-1ULL)
+
+#ifdef CONFIG_PROC_VMCORE
extern unsigned long long elfcorehdr_addr;
+#else
+static const unsigned long long elfcorehdr_addr = ELFCORE_ADDR_MAX;
+#endif
+
extern ssize_t copy_oldmem_page(unsigned long, char *, size_t,
unsigned long, int);
extern const struct file_operations proc_vmcore_operations;
next reply other threads:[~2008-07-26 9:25 UTC|newest]
Thread overview: 94+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-26 9:25 Ingo Molnar [this message]
2008-07-26 10:10 ` [patch] crashdump: fix undefined reference to `elfcorehdr_addr' Andrew Morton
2008-07-26 10:10 ` Andrew Morton
2008-07-27 23:45 ` Simon Horman
2008-07-27 23:45 ` Simon Horman
2008-07-28 1:51 ` Simon Horman
2008-07-28 1:51 ` Simon Horman
2008-07-28 1:51 ` Simon Horman
2008-07-28 2:45 ` Simon Horman
2008-07-28 2:45 ` Simon Horman
2008-07-28 2:45 ` Simon Horman
2008-07-28 3:40 ` Simon Horman
2008-07-28 3:40 ` Simon Horman
2008-07-28 3:40 ` Simon Horman
2008-07-28 12:48 ` Ingo Molnar
2008-07-28 12:48 ` Ingo Molnar
2008-07-28 12:48 ` Ingo Molnar
2008-07-29 0:35 ` Simon Horman
2008-07-29 0:35 ` Simon Horman
2008-07-29 0:35 ` Simon Horman
2008-07-28 21:10 ` [PATCH 1/5] Move elfcorehdr_addr out of vmcore.c (Was: Re: [patch] crashdump: fix undefined reference to `elfcorehdr_addr') Vivek Goyal
2008-07-28 21:10 ` Vivek Goyal
2008-07-28 21:10 ` Vivek Goyal
2008-07-28 21:10 ` [PATCH 1/5] Move elfcorehdr_addr out of vmcore.c (Was: Re: [patch] Vivek Goyal
2008-07-28 21:11 ` [PATCH 2/5] x86: Define elfcorehdr_addr in arch dependent section Vivek Goyal
2008-07-28 21:11 ` Vivek Goyal
2008-07-28 21:11 ` Vivek Goyal
2008-07-28 21:11 ` Vivek Goyal
2008-07-28 21:13 ` [PATCH 3/5] ia64: " Vivek Goyal
2008-07-28 21:13 ` Vivek Goyal
2008-07-28 21:13 ` Vivek Goyal
2008-07-28 21:13 ` Vivek Goyal
2008-07-28 21:14 ` [PATCH 4/5] powerpc: " Vivek Goyal
2008-07-28 21:14 ` Vivek Goyal
2008-07-28 21:14 ` Vivek Goyal
2008-07-28 21:14 ` [PATCH 4/5] powerpc: Define elfcorehdr_addr in arch dependent Vivek Goyal
2008-07-28 21:15 ` [PATCH 5/5] sh: Define elfcorehdr_addr in arch dependent section Vivek Goyal
2008-07-28 21:15 ` Vivek Goyal
2008-07-28 21:15 ` Vivek Goyal
2008-07-28 21:15 ` Vivek Goyal
2008-07-29 14:18 ` Paul Mundt
2008-07-29 14:18 ` Paul Mundt
2008-07-29 14:18 ` Paul Mundt
2008-07-29 14:18 ` Paul Mundt
2008-07-29 4:42 ` [PATCH 3/5] ia64: " Simon Horman
2008-07-29 4:42 ` Simon Horman
2008-07-29 4:42 ` Simon Horman
2008-07-29 4:42 ` [PATCH 3/5] ia64: Define elfcorehdr_addr in arch dependent Simon Horman
2008-07-29 13:53 ` [PATCH 3/5] ia64: Define elfcorehdr_addr in arch dependent section Vivek Goyal
2008-07-29 13:53 ` Vivek Goyal
2008-07-29 13:53 ` Vivek Goyal
2008-07-29 13:53 ` [PATCH 3/5] ia64: Define elfcorehdr_addr in arch dependent Vivek Goyal
2008-07-31 15:29 ` [PATCH 2/5] x86: Define elfcorehdr_addr in arch dependent section Ingo Molnar
2008-07-31 15:29 ` Ingo Molnar
2008-07-31 15:29 ` Ingo Molnar
2008-07-31 15:29 ` [PATCH 2/5] x86: Define elfcorehdr_addr in arch dependent Ingo Molnar
2008-07-28 22:37 ` [PATCH 1/5] Move elfcorehdr_addr out of vmcore.c (Was: Re: [patch] crashdump: fix undefined reference to `elfcorehdr_addr') Eric W. Biederman
2008-07-28 22:37 ` Eric W. Biederman
2008-07-28 22:37 ` Eric W. Biederman
2008-07-28 22:37 ` [PATCH 1/5] Move elfcorehdr_addr out of vmcore.c (Was: Re: [patch] crashdump: fix undefined refe Eric W. Biederman
2008-07-28 22:47 ` [PATCH 1/5] Move elfcorehdr_addr out of vmcore.c (Was: Re: [patch] crashdump: fix undefined reference to `elfcorehdr_addr') Eric W. Biederman
2008-07-28 22:47 ` Eric W. Biederman
2008-07-28 22:47 ` Eric W. Biederman
2008-07-28 22:47 ` [PATCH 1/5] Move elfcorehdr_addr out of vmcore.c (Was: Re: [patch] crashdump: fix undefined refe Eric W. Biederman
2008-07-29 1:22 ` [PATCH 1/5] Move elfcorehdr_addr out of vmcore.c (Was: Re: [patch] crashdump: fix undefined reference to `elfcorehdr_addr') Simon Horman
2008-07-29 1:22 ` Simon Horman
2008-07-29 1:22 ` Simon Horman
2008-07-29 1:22 ` [PATCH 1/5] Move elfcorehdr_addr out of vmcore.c (Was: Simon Horman
2008-07-29 2:28 ` [PATCH 1/5] Move elfcorehdr_addr out of vmcore.c (Was: Re: [patch] crashdump: fix undefined reference to `elfcorehdr_addr') Vivek Goyal
2008-07-29 2:28 ` Vivek Goyal
2008-07-29 2:28 ` Vivek Goyal
2008-07-29 2:28 ` [PATCH 1/5] Move elfcorehdr_addr out of vmcore.c (Was: Vivek Goyal
2008-07-29 3:26 ` [PATCH 1/5] Move elfcorehdr_addr out of vmcore.c (Was: Re: [patch] crashdump: fix undefined reference to `elfcorehdr_addr') Simon Horman
2008-07-29 3:26 ` Simon Horman
2008-07-29 3:26 ` Simon Horman
2008-07-29 3:26 ` [PATCH 1/5] Move elfcorehdr_addr out of vmcore.c (Was: Simon Horman
2008-07-28 5:39 ` [patch] crashdump: fix undefined reference to `elfcorehdr_addr' Eric W. Biederman
2008-07-28 5:39 ` Eric W. Biederman
2008-07-28 5:39 ` Eric W. Biederman
2008-07-28 6:24 ` Muli Ben-Yehuda
2008-07-28 6:24 ` Muli Ben-Yehuda
2008-07-28 6:24 ` Muli Ben-Yehuda
2008-07-28 13:44 ` Vivek Goyal
2008-07-28 13:44 ` Vivek Goyal
2008-07-28 13:44 ` Vivek Goyal
2008-07-28 19:12 ` Eric W. Biederman
2008-07-28 19:12 ` Eric W. Biederman
2008-07-28 19:12 ` Eric W. Biederman
2008-07-28 13:31 ` Vivek Goyal
2008-07-28 13:31 ` Vivek Goyal
2008-07-28 13:31 ` Vivek Goyal
2008-07-29 0:33 ` Simon Horman
2008-07-29 0:33 ` Simon Horman
2008-07-29 0:33 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080726092519.GA4341@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.