From: Ingo Molnar <mingo@elte.hu>
To: Vivek Goyal <vgoyal@redhat.com>
Cc: Muli Ben-Yehuda <muli@il.ibm.com>,
Tony Luck <tony.luck@intel.com>,
linux-ia64@vger.kernel.org, Paul Mundt <lethal@linux-sh.org>,
Chandru <chandru@in.ibm.com>,
kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
linuxppc-dev@ozlabs.org, Terry Loftin <terry.loftin@hp.com>,
Simon Horman <horms@verge.net.au>,
Paul Mackerras <paulus@samba.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH 2/5] x86: Define elfcorehdr_addr in arch dependent section
Date: Thu, 31 Jul 2008 17:29:26 +0200 [thread overview]
Message-ID: <20080731152926.GA20909@elte.hu> (raw)
In-Reply-To: <20080728211156.GB9985@redhat.com>
* Vivek Goyal <vgoyal@redhat.com> wrote:
> o Move elfcorehdr_addr definition in arch dependent crash dump file. This is
> equivalent to defining elfcorehdr_addr under CONFIG_CRASH_DUMP instead of
> CONFIG_PROC_VMCORE. This is needed by is_kdump_kernel() which can be
> used irrespective of the fact whether CONFIG_PROC_VMCORE is enabled or
> not.
>
> Signed-off-by: Vivek Goyal <vgoyal@redhat.com>
> ---
>
> arch/x86/kernel/crash_dump_32.c | 3 +++
> arch/x86/kernel/crash_dump_64.c | 3 +++
> arch/x86/kernel/setup.c | 8 +++++++-
> 3 files changed, 13 insertions(+), 1 deletion(-)
the x86 bits look fine to me.
Acked-by: Ingo Molnar <mingo@elte.hu>
Ingo
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
WARNING: multiple messages have this Message-ID (diff)
From: Ingo Molnar <mingo@elte.hu>
To: Vivek Goyal <vgoyal@redhat.com>
Cc: Simon Horman <horms@verge.net.au>,
Andrew Morton <akpm@linux-foundation.org>,
Muli Ben-Yehuda <muli@il.ibm.com>,
Tony Luck <tony.luck@intel.com>,
linux-ia64@vger.kernel.org, Chandru <chandru@in.ibm.com>,
kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
Terry Loftin <terry.loftin@hp.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Paul Mundt <lethal@linux-sh.org>,
Paul Mackerras <paulus@samba.org>,
linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 2/5] x86: Define elfcorehdr_addr in arch dependent
Date: Thu, 31 Jul 2008 15:29:26 +0000 [thread overview]
Message-ID: <20080731152926.GA20909@elte.hu> (raw)
In-Reply-To: <20080728211156.GB9985@redhat.com>
* Vivek Goyal <vgoyal@redhat.com> wrote:
> o Move elfcorehdr_addr definition in arch dependent crash dump file. This is
> equivalent to defining elfcorehdr_addr under CONFIG_CRASH_DUMP instead of
> CONFIG_PROC_VMCORE. This is needed by is_kdump_kernel() which can be
> used irrespective of the fact whether CONFIG_PROC_VMCORE is enabled or
> not.
>
> Signed-off-by: Vivek Goyal <vgoyal@redhat.com>
> ---
>
> arch/x86/kernel/crash_dump_32.c | 3 +++
> arch/x86/kernel/crash_dump_64.c | 3 +++
> arch/x86/kernel/setup.c | 8 +++++++-
> 3 files changed, 13 insertions(+), 1 deletion(-)
the x86 bits look fine to me.
Acked-by: Ingo Molnar <mingo@elte.hu>
Ingo
WARNING: multiple messages have this Message-ID (diff)
From: Ingo Molnar <mingo@elte.hu>
To: Vivek Goyal <vgoyal@redhat.com>
Cc: Tony Luck <tony.luck@intel.com>,
linux-ia64@vger.kernel.org, Paul Mundt <lethal@linux-sh.org>,
kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
linuxppc-dev@ozlabs.org, Terry Loftin <terry.loftin@hp.com>,
Simon Horman <horms@verge.net.au>,
Paul Mackerras <paulus@samba.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH 2/5] x86: Define elfcorehdr_addr in arch dependent section
Date: Thu, 31 Jul 2008 17:29:26 +0200 [thread overview]
Message-ID: <20080731152926.GA20909@elte.hu> (raw)
In-Reply-To: <20080728211156.GB9985@redhat.com>
* Vivek Goyal <vgoyal@redhat.com> wrote:
> o Move elfcorehdr_addr definition in arch dependent crash dump file. This is
> equivalent to defining elfcorehdr_addr under CONFIG_CRASH_DUMP instead of
> CONFIG_PROC_VMCORE. This is needed by is_kdump_kernel() which can be
> used irrespective of the fact whether CONFIG_PROC_VMCORE is enabled or
> not.
>
> Signed-off-by: Vivek Goyal <vgoyal@redhat.com>
> ---
>
> arch/x86/kernel/crash_dump_32.c | 3 +++
> arch/x86/kernel/crash_dump_64.c | 3 +++
> arch/x86/kernel/setup.c | 8 +++++++-
> 3 files changed, 13 insertions(+), 1 deletion(-)
the x86 bits look fine to me.
Acked-by: Ingo Molnar <mingo@elte.hu>
Ingo
WARNING: multiple messages have this Message-ID (diff)
From: Ingo Molnar <mingo@elte.hu>
To: Vivek Goyal <vgoyal@redhat.com>
Cc: Simon Horman <horms@verge.net.au>,
Andrew Morton <akpm@linux-foundation.org>,
Muli Ben-Yehuda <muli@il.ibm.com>,
Tony Luck <tony.luck@intel.com>,
linux-ia64@vger.kernel.org, Chandru <chandru@in.ibm.com>,
kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
Terry Loftin <terry.loftin@hp.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Paul Mundt <lethal@linux-sh.org>,
Paul Mackerras <paulus@samba.org>,
linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 2/5] x86: Define elfcorehdr_addr in arch dependent section
Date: Thu, 31 Jul 2008 17:29:26 +0200 [thread overview]
Message-ID: <20080731152926.GA20909@elte.hu> (raw)
In-Reply-To: <20080728211156.GB9985@redhat.com>
* Vivek Goyal <vgoyal@redhat.com> wrote:
> o Move elfcorehdr_addr definition in arch dependent crash dump file. This is
> equivalent to defining elfcorehdr_addr under CONFIG_CRASH_DUMP instead of
> CONFIG_PROC_VMCORE. This is needed by is_kdump_kernel() which can be
> used irrespective of the fact whether CONFIG_PROC_VMCORE is enabled or
> not.
>
> Signed-off-by: Vivek Goyal <vgoyal@redhat.com>
> ---
>
> arch/x86/kernel/crash_dump_32.c | 3 +++
> arch/x86/kernel/crash_dump_64.c | 3 +++
> arch/x86/kernel/setup.c | 8 +++++++-
> 3 files changed, 13 insertions(+), 1 deletion(-)
the x86 bits look fine to me.
Acked-by: Ingo Molnar <mingo@elte.hu>
Ingo
next prev parent reply other threads:[~2008-07-31 15:30 UTC|newest]
Thread overview: 94+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-26 9:25 [patch] crashdump: fix undefined reference to `elfcorehdr_addr' Ingo Molnar
2008-07-26 10:10 ` Andrew Morton
2008-07-26 10:10 ` Andrew Morton
2008-07-27 23:45 ` Simon Horman
2008-07-27 23:45 ` Simon Horman
2008-07-28 1:51 ` Simon Horman
2008-07-28 1:51 ` Simon Horman
2008-07-28 1:51 ` Simon Horman
2008-07-28 2:45 ` Simon Horman
2008-07-28 2:45 ` Simon Horman
2008-07-28 2:45 ` Simon Horman
2008-07-28 3:40 ` Simon Horman
2008-07-28 3:40 ` Simon Horman
2008-07-28 3:40 ` Simon Horman
2008-07-28 12:48 ` Ingo Molnar
2008-07-28 12:48 ` Ingo Molnar
2008-07-28 12:48 ` Ingo Molnar
2008-07-29 0:35 ` Simon Horman
2008-07-29 0:35 ` Simon Horman
2008-07-29 0:35 ` Simon Horman
2008-07-28 21:10 ` [PATCH 1/5] Move elfcorehdr_addr out of vmcore.c (Was: Re: [patch] crashdump: fix undefined reference to `elfcorehdr_addr') Vivek Goyal
2008-07-28 21:10 ` Vivek Goyal
2008-07-28 21:10 ` Vivek Goyal
2008-07-28 21:10 ` [PATCH 1/5] Move elfcorehdr_addr out of vmcore.c (Was: Re: [patch] Vivek Goyal
2008-07-28 21:11 ` [PATCH 2/5] x86: Define elfcorehdr_addr in arch dependent section Vivek Goyal
2008-07-28 21:11 ` Vivek Goyal
2008-07-28 21:11 ` Vivek Goyal
2008-07-28 21:11 ` Vivek Goyal
2008-07-28 21:13 ` [PATCH 3/5] ia64: " Vivek Goyal
2008-07-28 21:13 ` Vivek Goyal
2008-07-28 21:13 ` Vivek Goyal
2008-07-28 21:13 ` Vivek Goyal
2008-07-28 21:14 ` [PATCH 4/5] powerpc: " Vivek Goyal
2008-07-28 21:14 ` Vivek Goyal
2008-07-28 21:14 ` Vivek Goyal
2008-07-28 21:14 ` [PATCH 4/5] powerpc: Define elfcorehdr_addr in arch dependent Vivek Goyal
2008-07-28 21:15 ` [PATCH 5/5] sh: Define elfcorehdr_addr in arch dependent section Vivek Goyal
2008-07-28 21:15 ` Vivek Goyal
2008-07-28 21:15 ` Vivek Goyal
2008-07-28 21:15 ` Vivek Goyal
2008-07-29 14:18 ` Paul Mundt
2008-07-29 14:18 ` Paul Mundt
2008-07-29 14:18 ` Paul Mundt
2008-07-29 14:18 ` Paul Mundt
2008-07-29 4:42 ` [PATCH 3/5] ia64: " Simon Horman
2008-07-29 4:42 ` Simon Horman
2008-07-29 4:42 ` Simon Horman
2008-07-29 4:42 ` [PATCH 3/5] ia64: Define elfcorehdr_addr in arch dependent Simon Horman
2008-07-29 13:53 ` [PATCH 3/5] ia64: Define elfcorehdr_addr in arch dependent section Vivek Goyal
2008-07-29 13:53 ` Vivek Goyal
2008-07-29 13:53 ` Vivek Goyal
2008-07-29 13:53 ` [PATCH 3/5] ia64: Define elfcorehdr_addr in arch dependent Vivek Goyal
2008-07-31 15:29 ` Ingo Molnar [this message]
2008-07-31 15:29 ` [PATCH 2/5] x86: Define elfcorehdr_addr in arch dependent section Ingo Molnar
2008-07-31 15:29 ` Ingo Molnar
2008-07-31 15:29 ` [PATCH 2/5] x86: Define elfcorehdr_addr in arch dependent Ingo Molnar
2008-07-28 22:37 ` [PATCH 1/5] Move elfcorehdr_addr out of vmcore.c (Was: Re: [patch] crashdump: fix undefined reference to `elfcorehdr_addr') Eric W. Biederman
2008-07-28 22:37 ` Eric W. Biederman
2008-07-28 22:37 ` Eric W. Biederman
2008-07-28 22:37 ` [PATCH 1/5] Move elfcorehdr_addr out of vmcore.c (Was: Re: [patch] crashdump: fix undefined refe Eric W. Biederman
2008-07-28 22:47 ` [PATCH 1/5] Move elfcorehdr_addr out of vmcore.c (Was: Re: [patch] crashdump: fix undefined reference to `elfcorehdr_addr') Eric W. Biederman
2008-07-28 22:47 ` Eric W. Biederman
2008-07-28 22:47 ` Eric W. Biederman
2008-07-28 22:47 ` [PATCH 1/5] Move elfcorehdr_addr out of vmcore.c (Was: Re: [patch] crashdump: fix undefined refe Eric W. Biederman
2008-07-29 1:22 ` [PATCH 1/5] Move elfcorehdr_addr out of vmcore.c (Was: Re: [patch] crashdump: fix undefined reference to `elfcorehdr_addr') Simon Horman
2008-07-29 1:22 ` Simon Horman
2008-07-29 1:22 ` Simon Horman
2008-07-29 1:22 ` [PATCH 1/5] Move elfcorehdr_addr out of vmcore.c (Was: Simon Horman
2008-07-29 2:28 ` [PATCH 1/5] Move elfcorehdr_addr out of vmcore.c (Was: Re: [patch] crashdump: fix undefined reference to `elfcorehdr_addr') Vivek Goyal
2008-07-29 2:28 ` Vivek Goyal
2008-07-29 2:28 ` Vivek Goyal
2008-07-29 2:28 ` [PATCH 1/5] Move elfcorehdr_addr out of vmcore.c (Was: Vivek Goyal
2008-07-29 3:26 ` [PATCH 1/5] Move elfcorehdr_addr out of vmcore.c (Was: Re: [patch] crashdump: fix undefined reference to `elfcorehdr_addr') Simon Horman
2008-07-29 3:26 ` Simon Horman
2008-07-29 3:26 ` Simon Horman
2008-07-29 3:26 ` [PATCH 1/5] Move elfcorehdr_addr out of vmcore.c (Was: Simon Horman
2008-07-28 5:39 ` [patch] crashdump: fix undefined reference to `elfcorehdr_addr' Eric W. Biederman
2008-07-28 5:39 ` Eric W. Biederman
2008-07-28 5:39 ` Eric W. Biederman
2008-07-28 6:24 ` Muli Ben-Yehuda
2008-07-28 6:24 ` Muli Ben-Yehuda
2008-07-28 6:24 ` Muli Ben-Yehuda
2008-07-28 13:44 ` Vivek Goyal
2008-07-28 13:44 ` Vivek Goyal
2008-07-28 13:44 ` Vivek Goyal
2008-07-28 19:12 ` Eric W. Biederman
2008-07-28 19:12 ` Eric W. Biederman
2008-07-28 19:12 ` Eric W. Biederman
2008-07-28 13:31 ` Vivek Goyal
2008-07-28 13:31 ` Vivek Goyal
2008-07-28 13:31 ` Vivek Goyal
2008-07-29 0:33 ` Simon Horman
2008-07-29 0:33 ` Simon Horman
2008-07-29 0:33 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080731152926.GA20909@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=chandru@in.ibm.com \
--cc=ebiederm@xmission.com \
--cc=horms@verge.net.au \
--cc=kexec@lists.infradead.org \
--cc=lethal@linux-sh.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=muli@il.ibm.com \
--cc=paulus@samba.org \
--cc=terry.loftin@hp.com \
--cc=tony.luck@intel.com \
--cc=torvalds@linux-foundation.org \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.