From: Andrew Morton <akpm@linux-foundation.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Jeff Garzik <jeff@garzik.org>,
LKML <linux-kernel@vger.kernel.org>,
FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>,
ppc-dev <linuxppc-dev@ozlabs.org>,
Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH] powerpc/ibmveth: fix multiple errors with dma_mapping_error conversion
Date: Sun, 27 Jul 2008 12:24:14 -0700 [thread overview]
Message-ID: <20080727122414.cac4e336.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080728021424.40cf66bc.sfr@canb.auug.org.au>
On Mon, 28 Jul 2008 02:14:24 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> The addition of an argument to dma_mapping_error() in commit
> 8d8bb39b9eba32dd70e87fd5ad5c5dd4ba118e06 "dma-mapping: add the device
> argument to dma_mapping_error()" left a bit of fallout:
Yeah, sorry, that patch was a horror - I fixed it perhaps ten times. I
think people were madly adding new dma_mapping_error() calls while we
were trying to maintain it as well.
It should have been dome as a two-stage conversion.
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
ppc-dev <linuxppc-dev@ozlabs.org>,
LKML <linux-kernel@vger.kernel.org>,
FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>,
Jeff Garzik <jeff@garzik.org>
Subject: Re: [PATCH] powerpc/ibmveth: fix multiple errors with dma_mapping_error conversion
Date: Sun, 27 Jul 2008 12:24:14 -0700 [thread overview]
Message-ID: <20080727122414.cac4e336.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080728021424.40cf66bc.sfr@canb.auug.org.au>
On Mon, 28 Jul 2008 02:14:24 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> The addition of an argument to dma_mapping_error() in commit
> 8d8bb39b9eba32dd70e87fd5ad5c5dd4ba118e06 "dma-mapping: add the device
> argument to dma_mapping_error()" left a bit of fallout:
Yeah, sorry, that patch was a horror - I fixed it perhaps ten times. I
think people were madly adding new dma_mapping_error() calls while we
were trying to maintain it as well.
It should have been dome as a two-stage conversion.
next prev parent reply other threads:[~2008-07-27 19:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-27 16:14 [PATCH] powerpc/ibmveth: fix multiple errors with dma_mapping_error conversion Stephen Rothwell
2008-07-27 16:14 ` Stephen Rothwell
2008-07-27 19:24 ` Andrew Morton [this message]
2008-07-27 19:24 ` Andrew Morton
2008-07-28 0:32 ` Stephen Rothwell
2008-07-28 0:32 ` Stephen Rothwell
2008-07-28 1:07 ` James Morris
2008-07-28 1:07 ` James Morris
2008-07-28 3:04 ` Andrew Morton
2008-07-28 3:04 ` Andrew Morton
2008-07-30 21:18 ` Jeff Garzik
2008-07-30 21:18 ` Jeff Garzik
2008-07-30 22:59 ` Benjamin Herrenschmidt
2008-07-30 22:59 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080727122414.cac4e336.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.