From: Ben Dooks <ben-linux@fluff.org>
To: Adrian Bunk <bunk@kernel.org>
Cc: lethal@linux-sh.org, Yusuke Goda <goda.yusuke@renesas.com>,
Magnus Damm <damm@igel.co.jp>,
linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] SH_AP325RXA must select I2C
Date: Mon, 28 Jul 2008 22:38:28 +0000 [thread overview]
Message-ID: <20080728223828.GF8301@fluff.org.uk> (raw)
In-Reply-To: <20080728201705.GC7713@cs181140183.pp.htv.fi>
On Mon, Jul 28, 2008 at 11:17:05PM +0300, Adrian Bunk wrote:
> This patch fixes the following build error:
>
> <-- snip -->
>
> ...
> LD vmlinux
> arch/sh/boards/renesas/ap325rxa/built-in.o: In function `camera_set_capture':
> setup.c:(.text+0x80): undefined reference to `i2c_get_adapter'
> setup.c:(.text+0x88): undefined reference to `i2c_transfer'
> make[1]: *** [vmlinux] Error 1
>
> <-- snip -->
>
> Reported-by: Adrian Bunk <bunk@kernel.org>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
I suggest fixing the code or moving out to something that
depends on having I2C available.
> ---
> cdcb22706c51f0ae44946f4c3826cc3658960eba
> diff --git a/arch/sh/Kconfig b/arch/sh/Kconfig
> index 7bfb0d2..6f77d0a 100644
> --- a/arch/sh/Kconfig
> +++ b/arch/sh/Kconfig
> @@ -520,6 +520,7 @@ config SH_MIGOR
> config SH_AP325RXA
> bool "AP-325RXA"
> depends on CPU_SUBTYPE_SH7723
> + select I2C
> help
> Renesas "AP-325RXA" support.
> Compatible with ALGO SYSTEM CO.,LTD. "AP-320A"
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
Ben (ben@fluff.org, http://www.fluff.org/)
'a smiley only costs 4 bytes'
WARNING: multiple messages have this Message-ID (diff)
From: Ben Dooks <ben-linux@fluff.org>
To: Adrian Bunk <bunk@kernel.org>
Cc: lethal@linux-sh.org, Yusuke Goda <goda.yusuke@renesas.com>,
Magnus Damm <damm@igel.co.jp>,
linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] SH_AP325RXA must select I2C
Date: Mon, 28 Jul 2008 23:38:28 +0100 [thread overview]
Message-ID: <20080728223828.GF8301@fluff.org.uk> (raw)
In-Reply-To: <20080728201705.GC7713@cs181140183.pp.htv.fi>
On Mon, Jul 28, 2008 at 11:17:05PM +0300, Adrian Bunk wrote:
> This patch fixes the following build error:
>
> <-- snip -->
>
> ...
> LD vmlinux
> arch/sh/boards/renesas/ap325rxa/built-in.o: In function `camera_set_capture':
> setup.c:(.text+0x80): undefined reference to `i2c_get_adapter'
> setup.c:(.text+0x88): undefined reference to `i2c_transfer'
> make[1]: *** [vmlinux] Error 1
>
> <-- snip -->
>
> Reported-by: Adrian Bunk <bunk@kernel.org>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
I suggest fixing the code or moving out to something that
depends on having I2C available.
> ---
> cdcb22706c51f0ae44946f4c3826cc3658960eba
> diff --git a/arch/sh/Kconfig b/arch/sh/Kconfig
> index 7bfb0d2..6f77d0a 100644
> --- a/arch/sh/Kconfig
> +++ b/arch/sh/Kconfig
> @@ -520,6 +520,7 @@ config SH_MIGOR
> config SH_AP325RXA
> bool "AP-325RXA"
> depends on CPU_SUBTYPE_SH7723
> + select I2C
> help
> Renesas "AP-325RXA" support.
> Compatible with ALGO SYSTEM CO.,LTD. "AP-320A"
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
Ben (ben@fluff.org, http://www.fluff.org/)
'a smiley only costs 4 bytes'
next prev parent reply other threads:[~2008-07-28 22:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-28 20:17 [2.6 patch] SH_AP325RXA must select I2C Adrian Bunk
2008-07-28 20:17 ` Adrian Bunk
2008-07-28 20:42 ` Paul Mundt
2008-07-28 20:42 ` Paul Mundt
2008-07-28 22:38 ` Ben Dooks [this message]
2008-07-28 22:38 ` Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080728223828.GF8301@fluff.org.uk \
--to=ben-linux@fluff.org \
--cc=bunk@kernel.org \
--cc=damm@igel.co.jp \
--cc=goda.yusuke@renesas.com \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.