From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Henrik Rydberg <rydberg@euromail.se>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
robfitz@273k.net, akpm@osdl.org, jikos@jikos.cz, vojtech@suse.cz,
dmonakhov@openvz.org, johannes@sipsolutions.net
Subject: Re: [PATCH] bcm5974-0.58: name changes, open/close and suspend/resume serialized
Date: Tue, 29 Jul 2008 01:41:33 -0400 [thread overview]
Message-ID: <20080729054132.GA5345@anvil.corenet.prv> (raw)
In-Reply-To: <488AD712.1020102@euromail.se>
Hi Henrik,
On Sat, Jul 26, 2008 at 09:49:38AM +0200, Henrik Rydberg wrote:
> Hi Dmitry,
>
> one thing about the drivers/input/mouse/Kconfig patch:
>
> The original version contained "select USB", which was later changed
> to "depends on USB" by Andrew Morton. I saw it reappear as "select USB"
> in your latest patch, and simply considered it a change back, but
> maybe it was an oversight?
>
I am of the opinion that it is OK to "select" high-level subsystems that
don't have additional dependencies, especially if they are "past" the
original driver in menuconfig. I don't really like the idea of forcing
users revisiting earlier sub-menus after they selected a new subsystem
to see if there are any new options. Plus, if user wants driver for his
touchpad he does not really care whether it is PS/2 or USB, [s]he just
wants it to work.
So the change was intentional on my part.
--
Dmitry
next prev parent reply other threads:[~2008-07-29 5:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-24 7:37 [PATCH] bcm5974-0.58: name changes, open/close and suspend/resume serialized Henrik Rydberg
2008-07-25 15:42 ` Dmitry Torokhov
2008-07-25 18:25 ` Henrik Rydberg
2008-07-25 18:37 ` Dmitry Torokhov
2008-07-26 7:49 ` Henrik Rydberg
2008-07-29 5:41 ` Dmitry Torokhov [this message]
2008-07-29 6:46 ` Johannes Berg
2008-07-29 7:31 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080729054132.GA5345@anvil.corenet.prv \
--to=dmitry.torokhov@gmail.com \
--cc=akpm@osdl.org \
--cc=dmonakhov@openvz.org \
--cc=jikos@jikos.cz \
--cc=johannes@sipsolutions.net \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robfitz@273k.net \
--cc=rydberg@euromail.se \
--cc=vojtech@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.