From: Henrik Rydberg <rydberg@euromail.se>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
robfitz@273k.net, akpm@osdl.org, jikos@jikos.cz, vojtech@suse.cz,
dmonakhov@openvz.org, johannes@sipsolutions.net
Subject: Re: [PATCH] bcm5974-0.58: name changes, open/close and suspend/resume serialized
Date: Fri, 25 Jul 2008 20:25:29 +0200 [thread overview]
Message-ID: <488A1A99.2070609@euromail.se> (raw)
In-Reply-To: <20080725154250.GA1861@anvil.corenet.prv>
Hello Dmitry,
>
> Thank you for the changes. You don't have to track whether device is
> manually suspended or not - usb_submit_urb will fail and that is it.
>
Perfect.
> Attached are 2 patches. First cleans suspend state tracking as it is not
> really needed and does some formatting and other minor changes and 2nd
> implements runtime pm for the device. Could you please try them and if
> everything still works I will apply the driver.
Patch 1:
Looking good, just a few comments:
* I notice that clamp_val is new since 2.6.24.3
* Regarding the open-fails comment: is EACCES correct?
Patch 2:
Perfect.
Thank you so much, Dmitry - it's a GO!
Henrik
next prev parent reply other threads:[~2008-07-25 18:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-24 7:37 [PATCH] bcm5974-0.58: name changes, open/close and suspend/resume serialized Henrik Rydberg
2008-07-25 15:42 ` Dmitry Torokhov
2008-07-25 18:25 ` Henrik Rydberg [this message]
2008-07-25 18:37 ` Dmitry Torokhov
2008-07-26 7:49 ` Henrik Rydberg
2008-07-29 5:41 ` Dmitry Torokhov
2008-07-29 6:46 ` Johannes Berg
2008-07-29 7:31 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=488A1A99.2070609@euromail.se \
--to=rydberg@euromail.se \
--cc=akpm@osdl.org \
--cc=dmitry.torokhov@gmail.com \
--cc=dmonakhov@openvz.org \
--cc=jikos@jikos.cz \
--cc=johannes@sipsolutions.net \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robfitz@273k.net \
--cc=vojtech@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.