All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: David Brownell <david-b@pacbell.net>
Cc: cooloney@kernel.org, linux-mtd@lists.infradead.org,
	linux-kernel@vger.kernel.org, michael.hennerich@analog.com
Subject: Re: [RESEND PATCH 2.6.26-git 1/2] MTD DataFlash: bugfix, binary page sizes now handled (v3)
Date: Tue, 29 Jul 2008 15:00:52 -0700	[thread overview]
Message-ID: <20080729150052.80e558db.akpm@linux-foundation.org> (raw)
In-Reply-To: <200807251549.12565.david-b@pacbell.net>

On Fri, 25 Jul 2008 15:49:12 -0700
David Brownell <david-b@pacbell.net> wrote:

> This fixes a bug in handling certain newer DataFlash chips (at45db321d
> and at45db642d have current Linux users) when they were configured to
> use binary page sizes (possibly at the factory).
> 
>  - Use JEDEC probing (borrowed from m25p80 driver) to tell if the chip
>    supports binary page sizes ... if so, then query the chip to tell
>    whether it's currently using them.
> 
>  - Print that pagesize during probe; erasesize is still listed in 
>    the /proc/mtd file, useful for making filesystems.
> 
> Also fix a pre-existing bug with 2 MBit parts using the wrong pagesize;
> these are a bit smaller than Linux would normally use (even shared with
> a small FPGA's configuration bitstream).

I'm not sure what kernel this is against, but it gets a reject storm
against 2.6.27-rc1.  As does [2/2].

WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: David Brownell <david-b@pacbell.net>
Cc: cooloney@kernel.org, michael.hennerich@analog.com,
	linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH 2.6.26-git 1/2] MTD DataFlash: bugfix, binary page sizes now handled (v3)
Date: Tue, 29 Jul 2008 15:00:52 -0700	[thread overview]
Message-ID: <20080729150052.80e558db.akpm@linux-foundation.org> (raw)
In-Reply-To: <200807251549.12565.david-b@pacbell.net>

On Fri, 25 Jul 2008 15:49:12 -0700
David Brownell <david-b@pacbell.net> wrote:

> This fixes a bug in handling certain newer DataFlash chips (at45db321d
> and at45db642d have current Linux users) when they were configured to
> use binary page sizes (possibly at the factory).
> 
>  - Use JEDEC probing (borrowed from m25p80 driver) to tell if the chip
>    supports binary page sizes ... if so, then query the chip to tell
>    whether it's currently using them.
> 
>  - Print that pagesize during probe; erasesize is still listed in 
>    the /proc/mtd file, useful for making filesystems.
> 
> Also fix a pre-existing bug with 2 MBit parts using the wrong pagesize;
> these are a bit smaller than Linux would normally use (even shared with
> a small FPGA's configuration bitstream).

I'm not sure what kernel this is against, but it gets a reject storm
against 2.6.27-rc1.  As does [2/2].

  reply	other threads:[~2008-07-29 22:01 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-03  4:26 [PATCH 1/1] MTD DataFlash: fix bug - ATMEL AT45DF321D spi flash card fails to be copied to (v2) Bryan Wu
2008-06-03  4:26 ` Bryan Wu
2008-06-29  5:49 ` David Brownell
2008-06-29  6:21 ` [PATCH 2.6.26-rc8] MTD DataFlash: bugfix, binary page sizes now handled (v3) David Brownell
2008-07-25 22:49   ` [RESEND PATCH 2.6.26-git 1/2] " David Brownell
2008-07-25 22:49     ` David Brownell
2008-07-29 22:00     ` Andrew Morton [this message]
2008-07-29 22:00       ` Andrew Morton
2008-07-29 22:43       ` David Brownell
2008-07-29 22:43         ` David Brownell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080729150052.80e558db.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=cooloney@kernel.org \
    --cc=david-b@pacbell.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=michael.hennerich@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.