* device_create_drvdata missing on older kernels
@ 2008-07-30 3:00 Eliot Blennerhassett
2008-07-30 7:39 ` Jaroslav Kysela
2008-07-30 10:31 ` Takashi Iwai
0 siblings, 2 replies; 4+ messages in thread
From: Eliot Blennerhassett @ 2008-07-30 3:00 UTC (permalink / raw)
To: alsa-devel
I could not compile current git. (Error on acore/init.c)
Adding this to adriver.h fixed it for me. I'm not sure if this is the correct
general fix?
#ifndef CONFIG_SND_HAS_DEVICE_CREATE_DRVDATA
#define device_create_drvdata(c,d,m,p,s,n) device_create((c),(d),(m),(s),(n))
#endif
(My kernel 2.6.24-19-generic)
--
--
Eliot Blennerhassett
www.audioscience.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: device_create_drvdata missing on older kernels
2008-07-30 3:00 device_create_drvdata missing on older kernels Eliot Blennerhassett
@ 2008-07-30 7:39 ` Jaroslav Kysela
2008-07-30 10:31 ` Takashi Iwai
1 sibling, 0 replies; 4+ messages in thread
From: Jaroslav Kysela @ 2008-07-30 7:39 UTC (permalink / raw)
To: Eliot Blennerhassett; +Cc: alsa-devel
On Wed, 30 Jul 2008, Eliot Blennerhassett wrote:
> I could not compile current git. (Error on acore/init.c)
>
> Adding this to adriver.h fixed it for me. I'm not sure if this is the correct
> general fix?
>
> #ifndef CONFIG_SND_HAS_DEVICE_CREATE_DRVDATA
> #define device_create_drvdata(c,d,m,p,s,n) device_create((c),(d),(m),(s),(n))
> #endif
It looks like a correct fix. Applied. Thanks.
Jaroslav
-----
Jaroslav Kysela <perex@perex.cz>
Linux Kernel Sound Maintainer
ALSA Project, Red Hat, Inc.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: device_create_drvdata missing on older kernels
2008-07-30 3:00 device_create_drvdata missing on older kernels Eliot Blennerhassett
2008-07-30 7:39 ` Jaroslav Kysela
@ 2008-07-30 10:31 ` Takashi Iwai
2008-07-30 23:41 ` Eliot Blennerhassett
1 sibling, 1 reply; 4+ messages in thread
From: Takashi Iwai @ 2008-07-30 10:31 UTC (permalink / raw)
To: Eliot Blennerhassett; +Cc: alsa-devel
At Wed, 30 Jul 2008 15:00:34 +1200,
Eliot Blennerhassett wrote:
>
> I could not compile current git. (Error on acore/init.c)
>
> Adding this to adriver.h fixed it for me. I'm not sure if this is the correct
> general fix?
>
> #ifndef CONFIG_SND_HAS_DEVICE_CREATE_DRVDATA
> #define device_create_drvdata(c,d,m,p,s,n) device_create((c),(d),(m),(s),(n))
> #endif
It works right now for vanilla, but not for linux-next, unfortunately.
device_create_drvdata() is gone again in the next kernel. Long live
the function.
Could you check it's fixed on the snapshot tarball?
http://ftp.kernel.org/pub/linux/kernel/people/tiwai/snapshot/
Takashi
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: device_create_drvdata missing on older kernels
2008-07-30 10:31 ` Takashi Iwai
@ 2008-07-30 23:41 ` Eliot Blennerhassett
0 siblings, 0 replies; 4+ messages in thread
From: Eliot Blennerhassett @ 2008-07-30 23:41 UTC (permalink / raw)
To: Takashi Iwai; +Cc: alsa-devel
On Wednesday 30 July 2008 22:31:47 Takashi Iwai wrote:
> Could you check it's fixed on the snapshot tarball?
> http://ftp.kernel.org/pub/linux/kernel/people/tiwai/snapshot/
yes thanks compiles fine for me
--
Eliot
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-07-30 23:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-07-30 3:00 device_create_drvdata missing on older kernels Eliot Blennerhassett
2008-07-30 7:39 ` Jaroslav Kysela
2008-07-30 10:31 ` Takashi Iwai
2008-07-30 23:41 ` Eliot Blennerhassett
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.