From: Robert Millan <rmh@aybabtu.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] show an error instead of segfaulting on grub-probe -t partmap on a unsynced raid
Date: Fri, 1 Aug 2008 15:36:48 +0200 [thread overview]
Message-ID: <20080801133648.GA14359@thorin> (raw)
In-Reply-To: <1217430684.6234.14.camel@fz-deb.local>
On Wed, Jul 30, 2008 at 05:11:24PM +0200, Felix Zielcke wrote:
> Index: disk/raid.c
> ===================================================================
> --- disk/raid.c (Revision 1753)
> +++ disk/raid.c (Arbeitskopie)
> @@ -75,8 +75,10 @@
> grub_disk_memberlist_t list = NULL, tmp;
> unsigned int i;
>
> - for (i = 0; i < array->total_devs; i++)
> + for (i = 0; i < GRUB_RAID_MAX_DEVICES; i++)
The existing code is confusing. What is total_devs for? If we need to
iterate up to 32, sounds like this variable is pointless?
If it's useless, it should be removed (but maybe it isn't!).
--
Robert Millan
The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
how) you may access your data; but nobody's threatening your freedom: we
still allow you to remove your data and not access it at all."
next prev parent reply other threads:[~2008-08-01 13:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-28 23:05 grub-probe crashes on a linux softraid 1 with one disk beginning to sync Felix Zielcke
2008-07-29 20:20 ` [PATCH] show an error instead of segfaulting on grub-probe -t partmap on a unsynced raid Felix Zielcke
2008-07-30 10:37 ` Robert Millan
2008-07-30 11:39 ` Felix Zielcke
2008-07-30 15:11 ` Felix Zielcke
2008-08-01 13:36 ` Robert Millan [this message]
2008-08-01 15:22 ` Felix Zielcke
2008-08-02 19:00 ` Felix Zielcke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080801133648.GA14359@thorin \
--to=rmh@aybabtu.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.