All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Paul E. McKenney" <paulmck-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
To: Ingo Molnar <mingo-X9Un+BFzKDI@public.gmane.org>
Cc: Linus Torvalds
	<torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
	Alexey Dobriyan
	<adobriyan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Nick Piggin <nickpiggin-/E1597aS9LT0CCvOHzKKcA@public.gmane.org>,
	"Rafael J. Wysocki" <rjw-KKrjLPT3xs0@public.gmane.org>,
	Kamalesh Babulal
	<kamalesh-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>,
	Linux Kernel Mailing List
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Adrian Bunk <bunk-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Andrew Morton
	<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
	Natalie Protasevich
	<protasnb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Kernel Testers List
	<kernel-testers-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: 2.6.26-rc9-git4: Reported regressions from 2.6.25
Date: Fri, 1 Aug 2008 14:09:49 -0700	[thread overview]
Message-ID: <20080801210949.GJ14851@linux.vnet.ibm.com> (raw)
In-Reply-To: <20080710180620.GA30844-X9Un+BFzKDI@public.gmane.org>

On Thu, Jul 10, 2008 at 08:06:20PM +0200, Ingo Molnar wrote:
> 
> * Ingo Molnar <mingo-X9Un+BFzKDI@public.gmane.org> wrote:
> 
> > cool! :)
> > 
> > (hm, could anyone please resend Nick's original mail? The original one 
> > is not in my lkml folder nor on lkml.org - only the quoted one.)
> 
> ok, got the mail now now:
> 
> | | Annoyed this wasn't a crazy obscure error in the algorithm I could 
> | | fix :) [...]
> 
> Paul recently ran a formal proof against all sorts of RCU details (and 
> found and fixed a few obscure races that way that no-one ever 
> triggered), so i'd be quite surprised if we found anything in the core 
> algorithm :-)
> 
> | | [...] I spent all day debugging it and had to make a special test 
> | | case (rcutorture didn't seem to trigger it), and a big RCU state 
> | | logging infrastructure to log millions of RCU state transitions and 
> | | events. Oh well.
> 
> nice debugging!

Indeed!!!

> Acked-by: Ingo Molnar <mingo-X9Un+BFzKDI@public.gmane.org>
> 
> i'm wondering why rcutorture didnt trigger it. I do run !HOTPLUG + 
> RCU_PREEMPT kernels and never saw this. Nor did Paul. That aspect is 
> weird.

Turns out that my environment was silently re-enabling HOTPLUG_CPU, so I
only -thought- I was testing !CPU_HOTPLUG.  Once I forced it to really
disable HOTPLUG_CPU (by manually also specifying CONFIG_SUSPEND=n and
CONFIG_HIBERNATION=n), then rcutorture complained within 10 seconds.

Sigh!!!

						Thanx, Paul

WARNING: multiple messages have this Message-ID (diff)
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Alexey Dobriyan <adobriyan@gmail.com>,
	Nick Piggin <nickpiggin@yahoo.com.au>,
	"Rafael J. Wysocki" <rjw@sisk.pl>,
	Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Adrian Bunk <bunk@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Natalie Protasevich <protasnb@gmail.com>,
	Kernel Testers List <kernel-testers@vger.kernel.org>
Subject: Re: 2.6.26-rc9-git4: Reported regressions from 2.6.25
Date: Fri, 1 Aug 2008 14:09:49 -0700	[thread overview]
Message-ID: <20080801210949.GJ14851@linux.vnet.ibm.com> (raw)
In-Reply-To: <20080710180620.GA30844@elte.hu>

On Thu, Jul 10, 2008 at 08:06:20PM +0200, Ingo Molnar wrote:
> 
> * Ingo Molnar <mingo@elte.hu> wrote:
> 
> > cool! :)
> > 
> > (hm, could anyone please resend Nick's original mail? The original one 
> > is not in my lkml folder nor on lkml.org - only the quoted one.)
> 
> ok, got the mail now now:
> 
> | | Annoyed this wasn't a crazy obscure error in the algorithm I could 
> | | fix :) [...]
> 
> Paul recently ran a formal proof against all sorts of RCU details (and 
> found and fixed a few obscure races that way that no-one ever 
> triggered), so i'd be quite surprised if we found anything in the core 
> algorithm :-)
> 
> | | [...] I spent all day debugging it and had to make a special test 
> | | case (rcutorture didn't seem to trigger it), and a big RCU state 
> | | logging infrastructure to log millions of RCU state transitions and 
> | | events. Oh well.
> 
> nice debugging!

Indeed!!!

> Acked-by: Ingo Molnar <mingo@elte.hu>
> 
> i'm wondering why rcutorture didnt trigger it. I do run !HOTPLUG + 
> RCU_PREEMPT kernels and never saw this. Nor did Paul. That aspect is 
> weird.

Turns out that my environment was silently re-enabling HOTPLUG_CPU, so I
only -thought- I was testing !CPU_HOTPLUG.  Once I forced it to really
disable HOTPLUG_CPU (by manually also specifying CONFIG_SUSPEND=n and
CONFIG_HIBERNATION=n), then rcutorture complained within 10 seconds.

Sigh!!!

						Thanx, Paul

  parent reply	other threads:[~2008-08-01 21:09 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-08 21:37 2.6.26-rc9-git4: Reported regressions from 2.6.25 Rafael J. Wysocki
2008-07-08 21:37 ` Rafael J. Wysocki
2008-07-09  4:49 ` Randy Dunlap
2008-07-09  4:49   ` Randy Dunlap
     [not found]   ` <20080708214903.b783ba84.randy.dunlap-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2008-07-09 14:35     ` Rafael J. Wysocki
2008-07-09 14:35       ` Rafael J. Wysocki
     [not found] ` <200807101725.36175.nickpiggin@yahoo.com.au>
     [not found]   ` <200807101725.36175.nickpiggin-/E1597aS9LT0CCvOHzKKcA@public.gmane.org>
2008-07-10  9:03     ` Kamalesh Babulal
2008-07-10  9:03       ` Kamalesh Babulal
2008-07-10 11:02     ` Alexey Dobriyan
2008-07-10 11:02       ` Alexey Dobriyan
     [not found]       ` <20080710110213.GA6688-QDJVlCTZ4KWTKS93B3g+7KFoa47nwP16@public.gmane.org>
2008-07-10 17:21         ` Linus Torvalds
2008-07-10 17:21           ` Linus Torvalds
2008-07-10 17:34           ` Ingo Molnar
     [not found]             ` <20080710173459.GA11648-X9Un+BFzKDI@public.gmane.org>
2008-07-10 18:06               ` Ingo Molnar
2008-07-10 18:06                 ` Ingo Molnar
     [not found]                 ` <20080710180620.GA30844-X9Un+BFzKDI@public.gmane.org>
2008-07-11  4:11                   ` Nick Piggin
2008-07-11  4:11                     ` Nick Piggin
     [not found]                     ` <200807111412.00084.nickpiggin-/E1597aS9LT0CCvOHzKKcA@public.gmane.org>
2008-08-01 21:09                       ` Paul E. McKenney
2008-08-01 21:09                         ` Paul E. McKenney
2008-08-01 21:09                   ` Paul E. McKenney [this message]
2008-08-01 21:09                     ` Paul E. McKenney
     [not found]                 ` <20080710204157.GG6877@linux.vnet.ibm.com>
     [not found]                   ` <20080710204157.GG6877-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2008-08-01 21:09                     ` Paul E. McKenney
2008-08-01 21:09                       ` Paul E. McKenney
2008-08-01 21:09     ` Paul E. McKenney
2008-08-01 21:09       ` Paul E. McKenney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080801210949.GJ14851@linux.vnet.ibm.com \
    --to=paulmck-23vcf4htsmix0ybbhkvfkdbpr1lh4cv8@public.gmane.org \
    --cc=adobriyan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
    --cc=bunk-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=kamalesh-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org \
    --cc=kernel-testers-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mingo-X9Un+BFzKDI@public.gmane.org \
    --cc=nickpiggin-/E1597aS9LT0CCvOHzKKcA@public.gmane.org \
    --cc=protasnb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=rjw-KKrjLPT3xs0@public.gmane.org \
    --cc=torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.